Re: [PATCH] sdio_uart: fix sign of paramter status in sdio_uart_receive_chars()

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Nicolas Pitre <nico@...>

To: Pierre Ossman <drzeus-mmc@...>

Cc: Andre Haupt <andre@...>, lkml <linux-kernel@...>, <kernel-janitors@...>

Subject: Re: [PATCH] sdio_uart: fix sign of paramter status in sdio_uart_receive_chars()

Date: Saturday, November 24, 2007 - 11:35 am

On Sat, 24 Nov 2007, Pierre Ossman wrote:

quoted text> On Wed, 21 Nov 2007 12:33:45 +0100
> Andre Haupt <andre@bitwigglers.org> wrote:
> 
> > I think, the status paramter should be unsigned. Is this correct?
> > This also fixes a sparse warning about different signedness.
> > Only compile tested, because i do not have the hardware.
> > 
> > From: Andre Haupt <andre@bitwigglers.org>
> > Signed-off-by: Andre Haupt <andre@bitwigglers.org>
> 
> Nicolas, does this seem correct to you? I'm not familiar with the 
> serial stuff.

Yes, that should be fine.

Acked-by: Nicolas Pitre <nico@cam.org>


Nicolas
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] sdio_uart: fix sign of paramter status in sdio_uart_..., Andre Haupt, (Wed Nov 21, 7:33 am)

Re: [PATCH] sdio_uart: fix sign of paramter status in sdio_u..., Pierre Ossman, (Sat Nov 24, 10:36 am)

Re: [PATCH] sdio_uart: fix sign of paramter status in sdio_u..., Nicolas Pitre, (Sat Nov 24, 11:35 am)

Navigation

Popular discussions


linux-kernel:
Andrew Morton	Re: [GIT *] Allow request_firmware() to be satisfied from in-kernel, use it in mor...
Bart Van Assche	Re: Integration of SCST in the mainstream Linux kernel
Greg Kroah-Hartman	[PATCH 002/196] Chinese: rephrase English introduction in HOWTO
david	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
linux-netdev:
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
Mark Lord	Re: [BUG] New Kernel Bugs
git:

openbsd-misc:

Colocation donated by: