Home » Mailing list archives » linux-kernel » 2007 » November » 22

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Dave Jones <davej@...>
To: Andi Kleen <ak@...>
Cc: <netdev@...>, <linux-kernel@...>, <sam@...>, <rusty@...>
Subject: Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.
Date: Wednesday, November 21, 2007 - 11:52 pm

On Thu, Nov 22, 2007 at 03:43:06AM +0100, Andi Kleen wrote:

 > There seems to be rough consensus that the kernel currently has too many 
 > exported symbols. A lot of these exports are generally usable utility 
 > functions or important driver interfaces; but another large part are functions
 > intended by only one or two very specific modules for a very specific purpose.
 > One example is the TCP code. It has most of its internals exported, but 
 > only for use by tcp_ipv6.c (and now a few more by the TCP/IP congestion modules) 
 > But it doesn't make sense to include these exported for a specific module
 > functions into a broader "kernel interface".   External modules assume
 > they can use these functions, but they were never intended for that.
 > 
 > This patch allows to export symbols only for specific modules by 
 > introducing symbol name spaces. A module name space has a white
 > list of modules that are allowed to import symbols for it; all others
 > can't use the symbols.

I really like this patchset.   Definitely a step in the right direction imo.
Looks like some nits there that checkpatch will probably pick up on,
but otherwise, looks very straightforward too.

Kudos.

	Dave

-- 
http://www.codemonkey.org.uk
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH RFC] [1/9] Core module symbol namespaces code and int..., Andi Kleen, (Wed Nov 21, 10:43 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Arnd Bergmann, (Thu Nov 29, 5:55 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Thu Nov 29, 6:00 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Arnd Bergmann, (Thu Nov 29, 6:21 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Roland Dreier, (Sun Nov 25, 4:27 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Sun Nov 25, 9:28 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Stephen Hemminger, (Mon Nov 26, 2:25 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Arjan van de Ven, (Thu Nov 29, 12:53 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Thu Nov 29, 10:18 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Dave Jones, (Tue Nov 27, 3:00 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Adrian Bunk, (Tue Nov 27, 5:09 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., , (Tue Nov 27, 7:00 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Dave Jones, (Tue Nov 27, 5:25 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rick Jones, (Tue Nov 27, 5:15 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Adrian Bunk, (Tue Nov 27, 5:38 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rick Jones, (Tue Nov 27, 10:01 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Roland Dreier, (Mon Nov 26, 6:18 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Roland Dreier, (Mon Nov 26, 2:15 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Tue Nov 27, 12:49 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Jon Masters, (Tue Nov 27, 6:31 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Tue Nov 27, 6:37 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Stephen Hemminger, (Tue Nov 27, 7:00 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Tue Nov 27, 7:06 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Adrian Bunk, (Wed Nov 28, 12:48 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Wed Nov 28, 1:31 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Jonathan Corbet, (Tue Nov 27, 11:43 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Christoph Hellwig, (Tue Nov 27, 12:33 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Tue Nov 27, 11:58 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Tom Tucker, (Tue Nov 27, 1:35 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Tue Nov 27, 9:27 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Tom Tucker, (Wed Nov 28, 12:12 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Adrian Bunk, (Tue Nov 27, 1:15 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Tom Tucker, (Tue Nov 27, 1:45 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Adrian Bunk, (Tue Nov 27, 2:59 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Tue Nov 27, 5:02 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Adrian Bunk, (Tue Nov 27, 1:24 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Arnaldo Carvalho de Melo, (Thu Nov 22, 8:01 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Thu Nov 22, 2:17 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Christoph Hellwig, (Thu Nov 22, 7:06 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Thu Nov 22, 7:54 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Christoph Hellwig, (Thu Nov 22, 8:03 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Wed Nov 21, 11:56 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Thu Nov 22, 7:46 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Thu Nov 22, 8:29 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Roland Dreier, (Sun Nov 25, 4:29 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Sun Nov 25, 9:25 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Roland Dreier, (Mon Nov 26, 1:58 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Tue Nov 27, 12:26 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Tue Nov 27, 6:50 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Tue Nov 27, 9:34 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Herbert Xu, (Tue Nov 27, 9:58 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Tue Nov 27, 10:12 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., , (Tue Nov 27, 4:02 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Herbert Xu, (Tue Nov 27, 10:36 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Christoph Hellwig, (Thu Nov 22, 7:05 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Thu Nov 22, 8:25 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Thu Nov 22, 9:36 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Thu Nov 22, 11:35 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Fri Nov 23, 3:53 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Sat Nov 24, 12:53 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Sat Nov 24, 8:39 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Sun Nov 25, 9:23 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Dave Young, (Thu Nov 22, 4:41 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Thu Nov 22, 2:19 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Dave Young, (Thu Nov 22, 10:06 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Dave Jones, (Wed Nov 21, 11:52 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Arjan van de Ven, (Wed Nov 21, 11:03 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Wed Nov 21, 11:37 pm)
[PATCH RFC] [7/9] Convert TCP exports into namespaces, Andi Kleen, (Wed Nov 21, 10:43 pm)
[PATCH RFC] [8/9] Put UDP exports into a namespace, Andi Kleen, (Wed Nov 21, 10:43 pm)
[PATCH RFC] [9/9] Add a inet namespace, Andi Kleen, (Wed Nov 21, 10:43 pm)
[PATCH RFC] [6/9] Implement namespace checking in modpost, Andi Kleen, (Wed Nov 21, 10:43 pm)
[PATCH RFC] [4/9] modpost: Fix format string warnings, Andi Kleen, (Wed Nov 21, 10:43 pm)
Re: [PATCH RFC] [4/9] modpost: Fix format string warnings, Sam Ravnborg, (Mon Dec 10, 2:50 pm)
[PATCH RFC] [5/9] modpost: Fix a buffer overflow in modpost, Andi Kleen, (Wed Nov 21, 10:43 pm)
Re: [PATCH RFC] [5/9] modpost: Fix a buffer overflow in modp..., Sam Ravnborg, (Mon Dec 10, 3:32 pm)
Re: [PATCH RFC] [5/9] modpost: Fix a buffer overflow in modp..., Andi Kleen, (Mon Dec 10, 3:57 pm)
Re: [PATCH RFC] [5/9] modpost: Fix a buffer overflow in modp..., Sam Ravnborg, (Mon Dec 10, 4:07 pm)
[PATCH RFC] [3/9] modpost: Declare the modpost error functio..., Andi Kleen, (Wed Nov 21, 10:43 pm)
Re: [PATCH RFC] [3/9] modpost: Declare the modpost error fun..., Sam Ravnborg, (Mon Dec 10, 2:50 pm)
Re: [PATCH RFC] [3/9] modpost: Declare the modpost error fun..., Rusty Russell, (Tue Dec 11, 9:37 pm)
Re: [PATCH RFC] [3/9] modpost: Declare the modpost error fun..., Andi Kleen, (Mon Dec 10, 2:58 pm)
[PATCH RFC] [2/9] Fix duplicate symbol check to also check f..., Andi Kleen, (Wed Nov 21, 10:43 pm)