Re: 2.6.24-rc3: find complains about /proc/net

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Eric W. Biederman
Date: Tuesday, November 20, 2007 - 3:17 pm

Ingo Molnar <mingo@elte.hu> writes:


Agreed.  I have been debating with myself in the last couple of days
if it is a bug that /proc/self uses the tgid and not the actual pid/tid
value.

If I can be convinced that posix threads don't care I will happily just
switch /proc/self, calling the current implementation a bug.

I think it is a bug the real question is what are the backwards
compatibility implications.  Do posix threads care?

It appears to me that either we need to fix /proc/self or we need
to add /proc/task-self and fix /proc/mounts to point at that.

In the normal case we share all of the same things so I think it is
a don't care.  Except that /proc/self/status | grep Pid returns the
tgid.

Hmm.  I think I am just going to send Andrew a patch for 2.6.25 that
just fixes /proc/self.  I just fail to see how using the tgid is correct.
The only cases we could care seem to do the wrong thing when we use the
tgid.

Eric
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.24-rc3: find complains about /proc/net, Pavel Machek, (Mon Nov 19, 12:10 pm)
Re: 2.6.24-rc3: find complains about /proc/net, Rafael J. Wysocki, (Mon Nov 19, 3:04 pm)
Re: 2.6.24-rc3: find complains about /proc/net, Pavel Emelyanov, (Tue Nov 20, 8:51 am)
Re: 2.6.24-rc3: find complains about /proc/net, Eric W. Biederman, (Tue Nov 20, 2:52 pm)
Re: 2.6.24-rc3: find complains about /proc/net, Ingo Molnar, (Tue Nov 20, 2:59 pm)
Re: 2.6.24-rc3: find complains about /proc/net, Eric W. Biederman, (Tue Nov 20, 3:17 pm)
Re: 2.6.24-rc3: find complains about /proc/net, Ingo Molnar, (Tue Nov 20, 3:35 pm)
Re: 2.6.24-rc3: find complains about /proc/net, Roland McGrath, (Tue Nov 20, 3:54 pm)
Re: [PATCH] proc: Fix the threaded /proc/self., Guillaume Chazarain, (Tue Nov 20, 3:58 pm)
Re: 2.6.24-rc3: find complains about /proc/net, Ingo Molnar, (Tue Nov 20, 4:01 pm)
Re: [PATCH] proc: Fix the threaded /proc/self., Ingo Molnar, (Tue Nov 20, 4:03 pm)
Re: 2.6.24-rc3: find complains about /proc/net, Guillaume Chazarain, (Tue Nov 20, 4:06 pm)
Re: 2.6.24-rc3: find complains about /proc/net, Roland McGrath, (Tue Nov 20, 4:26 pm)
Re: 2.6.24-rc3: find complains about /proc/net, Ulrich Drepper, (Tue Nov 20, 4:32 pm)
Re: 2.6.24-rc3: find complains about /proc/net, Ingo Molnar, (Tue Nov 20, 4:43 pm)
Re: 2.6.24-rc3: find complains about /proc/net, Ingo Molnar, (Tue Nov 20, 4:45 pm)
Re: 2.6.24-rc3: find complains about /proc/net, Roland McGrath, (Tue Nov 20, 4:51 pm)
Re: 2.6.24-rc3: find complains about /proc/net, Eric W. Biederman, (Tue Nov 20, 5:41 pm)
Re: 2.6.24-rc3: find complains about /proc/net, Rafael J. Wysocki, (Tue Nov 20, 6:01 pm)
Re: 2.6.24-rc3: find complains about /proc/net, Eric W. Biederman, (Tue Nov 20, 6:19 pm)
Re: 2.6.24-rc3: find complains about /proc/net, Eric W. Biederman, (Tue Nov 20, 11:36 pm)
Re: 2.6.24-rc3: find complains about /proc/net, Pavel Emelyanov, (Wed Nov 21, 2:36 am)
[CFT][PATCH] proc_net: Remove userspace visible changes., Eric W. Biederman, (Sat Nov 24, 4:34 pm)
Re: [CFT][PATCH] proc_net: Remove userspace visible changes., Eric W. Biederman, (Mon Nov 26, 1:43 am)
[PATCH 2.6.24-rc3] Fix /proc/net breakage, Eric W. Biederman, (Mon Nov 26, 3:17 pm)
Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage, Pavel Emelyanov, (Tue Nov 27, 4:20 am)
Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage, Eric W. Biederman, (Tue Nov 27, 5:36 am)
Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage, Andrew Morton, (Fri Dec 7, 3:23 am)
Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage, Denis V. Lunev, (Fri Dec 7, 4:11 am)
Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage, Andreas Mohr, (Thu Dec 27, 10:40 am)
Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage, Alexey Dobriyan, (Thu Dec 27, 11:41 am)
Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage, Andreas Mohr, (Thu Dec 27, 3:17 pm)
Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage, Alexey Dobriyan, (Thu Dec 27, 11:22 pm)
Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage, Andreas Mohr, (Fri Dec 28, 12:21 am)