[patch 18/29] i386: avoid temporarily inconsistent pte-s

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Greg Kroah-Hartman
Date: Tuesday, November 20, 2007 - 11:24 am

2.6.23-stable review patch.  If anyone has any objections, please let us
know.

------------------
From: Jan Beulich <jbeulich@novell.com>

patch aa506dc7b12d03fbf8fd11aab752aed1aadd9c07 in mainline.

i386: avoid temporarily inconsistent pte-s

One more of these issues (which were considered fixed a few releases
back): other than on x86-64, i386 allows set_fixmap() to replace
already present mappings. Consequently, on PAE, care must be taken to
not update the high half of a pte while the low half is still holding
the old value.

[ tglx: arch/x86 adaptation ]

Signed-off-by: Jan Beulich <jbeulich@novell.com>
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 arch/i386/mm/pgtable.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/arch/i386/mm/pgtable.c
+++ b/arch/i386/mm/pgtable.c
@@ -97,8 +97,7 @@ static void set_pte_pfn(unsigned long va
 	}
 	pte = pte_offset_kernel(pmd, vaddr);
 	if (pgprot_val(flags))
-		/* <pfn,flags> stored as-is, to permit clearing entries */
-		set_pte(pte, pfn_pte(pfn, flags));
+		set_pte_present(&init_mm, vaddr, pte, pfn_pte(pfn, flags));
 	else
 		pte_clear(&init_mm, vaddr, pte);
 

-- 
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 00/29] 2.6.23-stable review, Greg Kroah-Hartman, (Tue Nov 20, 11:22 am)
[patch 01/29] i2c-pasemi: Fix NACK detection, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 02/29] i2c/eeprom: Recognize VGN as a valid Sony Va ..., Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 03/29] i2c/eeprom: Hide Sony Vaio serial numbers, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 04/29] drivers/video/ps3fb: fix memset size error, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 06/29] raid5: fix unending write sequence, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 07/29] knfsd: fix spurious EINVAL errors on first a ..., Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 08/29] nfsd4: recheck for secure ports in fh_verify, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 09/29] dmaengine: fix broken device refcounting, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 10/29] x86: disable preemption in delay_tsc(), Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 11/29] reiserfs: dont drop PG_dirty when releasing ..., Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 13/29] libata: sata_sis: use correct S/G table size, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 12/29] sata_sis: fix SCR read breakage, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 15/29] Fix divide-by-zero in the 2.6.23 scheduler code, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 16/29] geode: Fix not inplace encryption, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 17/29] libcrc32c: keep intermediate crc state in cp ..., Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 18/29] i386: avoid temporarily inconsistent pte-s, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 19/29] x86: fix off-by-one in find_next_zero_string, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 20/29] x86: mark read_crX() asm code as volatile, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 22/29] x86: return correct error code from child_ri ..., Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 23/29] ntp: fix typo that makes sync_cmos_clock erratic, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 24/29] x86: fix freeze in x86_64 RTC update code in ..., Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 25/29] softlockup watchdog fixes and cleanups, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 26/29] softlockup: use cpu_clock() instead of sched ..., Greg Kroah-Hartman, (Tue Nov 20, 11:25 am)
[patch 27/29] USB: unusual_devs modification for Nikon D200, Greg Kroah-Hartman, (Tue Nov 20, 11:25 am)
[patch 28/29] USB: Nikon D40X unusual_devs entry, Greg Kroah-Hartman, (Tue Nov 20, 11:25 am)
Re: [patch 00/29] 2.6.23-stable review, Greg Kroah-Hartman, (Tue Nov 20, 11:29 am)