Home » Mailing list archives » linux-kernel » 2007 » November » 20

[patch 16/29] geode: Fix not inplace encryption

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Greg Kroah-Hartman
Subject: [patch 16/29] geode: Fix not inplace encryption
Date: Tuesday, November 20, 2007 - 11:24 am

2.6.23-stable review patch.  If anyone has any objections, please let us
know.

------------------
From: Sebastian Siewior <sebastian@breakpoint.cc>

patch 2e21630ddc3fb717dc645356b75771c6a52dc627 in mainline.

Currently the Geode AES module fails to encrypt or decrypt if
the coherent bits are not set what is currently the case if the
encryption does not occur inplace. However, the encryption works
on my Geode machine _only_ if the coherent bits are always set.

Signed-off-by: Sebastian Siewior <sebastian@breakpoint.cc>
Acked-by: Jordan Crouse <jordan.crouse@amd.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/crypto/geode-aes.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/crypto/geode-aes.c
+++ b/drivers/crypto/geode-aes.c
@@ -110,8 +110,7 @@ geode_aes_crypt(struct geode_aes_op *op)
 	 * we don't need to worry
 	 */
 
-	if (op->src == op->dst)
-		flags |= (AES_CTRL_DCA | AES_CTRL_SCA);
+	flags |= (AES_CTRL_DCA | AES_CTRL_SCA);
 
 	if (op->dir == AES_DIR_ENCRYPT)
 		flags |= AES_CTRL_ENCRYPT;

-- 
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 00/29] 2.6.23-stable review, Greg Kroah-Hartman, (Tue Nov 20, 11:22 am)
[patch 01/29] i2c-pasemi: Fix NACK detection, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 02/29] i2c/eeprom: Recognize VGN as a valid Sony Va ..., Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 03/29] i2c/eeprom: Hide Sony Vaio serial numbers, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 04/29] drivers/video/ps3fb: fix memset size error, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 06/29] raid5: fix unending write sequence, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 07/29] knfsd: fix spurious EINVAL errors on first a ..., Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 08/29] nfsd4: recheck for secure ports in fh_verify, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 09/29] dmaengine: fix broken device refcounting, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 10/29] x86: disable preemption in delay_tsc(), Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 11/29] reiserfs: dont drop PG_dirty when releasing ..., Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 13/29] libata: sata_sis: use correct S/G table size, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 12/29] sata_sis: fix SCR read breakage, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 15/29] Fix divide-by-zero in the 2.6.23 scheduler code, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 16/29] geode: Fix not inplace encryption, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 17/29] libcrc32c: keep intermediate crc state in cp ..., Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 18/29] i386: avoid temporarily inconsistent pte-s, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 19/29] x86: fix off-by-one in find_next_zero_string, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 20/29] x86: mark read_crX() asm code as volatile, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 22/29] x86: return correct error code from child_ri ..., Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 23/29] ntp: fix typo that makes sync_cmos_clock erratic, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 24/29] x86: fix freeze in x86_64 RTC update code in ..., Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 25/29] softlockup watchdog fixes and cleanups, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 26/29] softlockup: use cpu_clock() instead of sched ..., Greg Kroah-Hartman, (Tue Nov 20, 11:25 am)
[patch 27/29] USB: unusual_devs modification for Nikon D200, Greg Kroah-Hartman, (Tue Nov 20, 11:25 am)
[patch 28/29] USB: Nikon D40X unusual_devs entry, Greg Kroah-Hartman, (Tue Nov 20, 11:25 am)
Re: [patch 00/29] 2.6.23-stable review, Greg Kroah-Hartman, (Tue Nov 20, 11:29 am)