[patch 02/29] i2c/eeprom: Recognize VGN as a valid Sony Vaio name prefix

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Greg Kroah-Hartman
Date: Tuesday, November 20, 2007 - 11:23 am

2.6.23-stable review patch.  If anyone has any objections, please let us
know.

------------------
From: Jean Delvare <khali@linux-fr.org>

patch 8b925a3dd8a4d7451092cb9aa11da727ba69e0f0 in mainline.

Recent (i.e. 2005 and later) Sony Vaio laptops have names beginning
with VGN rather than PCG. Update the eeprom driver so that it
recognizes these.

Why this matters: the eeprom driver hides private data from the
EEPROMs it recognizes as Vaio EEPROMs (passwords, serial number...) so
if the driver fails to recognize a Vaio EEPROM as such, the private
data is exposed to the world.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/i2c/chips/eeprom.c |   14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

--- a/drivers/i2c/chips/eeprom.c
+++ b/drivers/i2c/chips/eeprom.c
@@ -197,12 +197,16 @@ static int eeprom_detect(struct i2c_adap
 		goto exit_kfree;
 
 	/* Detect the Vaio nature of EEPROMs.
-	   We use the "PCG-" prefix as the signature. */
+	   We use the "PCG-" or "VGN-" prefix as the signature. */
 	if (address == 0x57) {
-		if (i2c_smbus_read_byte_data(new_client, 0x80) == 'P'
-		 && i2c_smbus_read_byte(new_client) == 'C'
-		 && i2c_smbus_read_byte(new_client) == 'G'
-		 && i2c_smbus_read_byte(new_client) == '-') {
+		char name[4];
+
+		name[0] = i2c_smbus_read_byte_data(new_client, 0x80);
+		name[1] = i2c_smbus_read_byte(new_client);
+		name[2] = i2c_smbus_read_byte(new_client);
+		name[3] = i2c_smbus_read_byte(new_client);
+
+		if (!memcmp(name, "PCG-", 4) || !memcmp(name, "VGN-", 4)) {
 			dev_info(&new_client->dev, "Vaio EEPROM detected, "
 				"enabling password protection\n");
 			data->nature = VAIO;

-- 
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 00/29] 2.6.23-stable review, Greg Kroah-Hartman, (Tue Nov 20, 11:22 am)
[patch 01/29] i2c-pasemi: Fix NACK detection, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 02/29] i2c/eeprom: Recognize VGN as a valid Sony Va ..., Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 03/29] i2c/eeprom: Hide Sony Vaio serial numbers, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 04/29] drivers/video/ps3fb: fix memset size error, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 06/29] raid5: fix unending write sequence, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 07/29] knfsd: fix spurious EINVAL errors on first a ..., Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 08/29] nfsd4: recheck for secure ports in fh_verify, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 09/29] dmaengine: fix broken device refcounting, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 10/29] x86: disable preemption in delay_tsc(), Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 11/29] reiserfs: dont drop PG_dirty when releasing ..., Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 13/29] libata: sata_sis: use correct S/G table size, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 12/29] sata_sis: fix SCR read breakage, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 15/29] Fix divide-by-zero in the 2.6.23 scheduler code, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 16/29] geode: Fix not inplace encryption, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 17/29] libcrc32c: keep intermediate crc state in cp ..., Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 18/29] i386: avoid temporarily inconsistent pte-s, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 19/29] x86: fix off-by-one in find_next_zero_string, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 20/29] x86: mark read_crX() asm code as volatile, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 22/29] x86: return correct error code from child_ri ..., Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 23/29] ntp: fix typo that makes sync_cmos_clock erratic, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 24/29] x86: fix freeze in x86_64 RTC update code in ..., Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 25/29] softlockup watchdog fixes and cleanups, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 26/29] softlockup: use cpu_clock() instead of sched ..., Greg Kroah-Hartman, (Tue Nov 20, 11:25 am)
[patch 27/29] USB: unusual_devs modification for Nikon D200, Greg Kroah-Hartman, (Tue Nov 20, 11:25 am)
[patch 28/29] USB: Nikon D40X unusual_devs entry, Greg Kroah-Hartman, (Tue Nov 20, 11:25 am)
Re: [patch 00/29] 2.6.23-stable review, Greg Kroah-Hartman, (Tue Nov 20, 11:29 am)