[patch 01/29] i2c-pasemi: Fix NACK detection

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Greg Kroah-Hartman
Date: Tuesday, November 20, 2007 - 11:23 am

2.6.23-stable review patch.  If anyone has any objections, please let us know.

------------------
From: Jean Delvare <khali@linux-fr.org>

patch be8a1f7cd4501c3b4b32543577a33aee6d2193ac in mainline.

Turns out we don't actually check the status to see if there was a
device out there to talk to, just if we had a timeout when doing so.

Add the proper check, so we don't falsly think there are devices
on the bus that are not there, etc.

Signed-off-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/i2c/busses/i2c-pasemi.c |    5 +++++
 1 file changed, 5 insertions(+)

--- a/drivers/i2c/busses/i2c-pasemi.c
+++ b/drivers/i2c/busses/i2c-pasemi.c
@@ -51,6 +51,7 @@ struct pasemi_smbus {
 #define MRXFIFO_DATA_M	0x000000ff
 
 #define SMSTA_XEN	0x08000000
+#define SMSTA_MTN	0x00200000
 
 #define CTL_MRR		0x00000400
 #define CTL_MTR		0x00000200
@@ -98,6 +99,10 @@ static unsigned int pasemi_smb_waitready
 		status = reg_read(smbus, REG_SMSTA);
 	}
 
+	/* Got NACK? */
+	if (status & SMSTA_MTN)
+		return -ENXIO;
+
 	if (timeout < 0) {
 		dev_warn(&smbus->dev->dev, "Timeout, status 0x%08x\n", status);
 		reg_write(smbus, REG_SMSTA, status);

-- 
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 00/29] 2.6.23-stable review, Greg Kroah-Hartman, (Tue Nov 20, 11:22 am)
[patch 01/29] i2c-pasemi: Fix NACK detection, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 02/29] i2c/eeprom: Recognize VGN as a valid Sony Va ..., Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 03/29] i2c/eeprom: Hide Sony Vaio serial numbers, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 04/29] drivers/video/ps3fb: fix memset size error, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 06/29] raid5: fix unending write sequence, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 07/29] knfsd: fix spurious EINVAL errors on first a ..., Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 08/29] nfsd4: recheck for secure ports in fh_verify, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 09/29] dmaengine: fix broken device refcounting, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 10/29] x86: disable preemption in delay_tsc(), Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 11/29] reiserfs: dont drop PG_dirty when releasing ..., Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 13/29] libata: sata_sis: use correct S/G table size, Greg Kroah-Hartman, (Tue Nov 20, 11:23 am)
[patch 12/29] sata_sis: fix SCR read breakage, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 15/29] Fix divide-by-zero in the 2.6.23 scheduler code, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 16/29] geode: Fix not inplace encryption, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 17/29] libcrc32c: keep intermediate crc state in cp ..., Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 18/29] i386: avoid temporarily inconsistent pte-s, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 19/29] x86: fix off-by-one in find_next_zero_string, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 20/29] x86: mark read_crX() asm code as volatile, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 22/29] x86: return correct error code from child_ri ..., Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 23/29] ntp: fix typo that makes sync_cmos_clock erratic, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 24/29] x86: fix freeze in x86_64 RTC update code in ..., Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 25/29] softlockup watchdog fixes and cleanups, Greg Kroah-Hartman, (Tue Nov 20, 11:24 am)
[patch 26/29] softlockup: use cpu_clock() instead of sched ..., Greg Kroah-Hartman, (Tue Nov 20, 11:25 am)
[patch 27/29] USB: unusual_devs modification for Nikon D200, Greg Kroah-Hartman, (Tue Nov 20, 11:25 am)
[patch 28/29] USB: Nikon D40X unusual_devs entry, Greg Kroah-Hartman, (Tue Nov 20, 11:25 am)
Re: [patch 00/29] 2.6.23-stable review, Greg Kroah-Hartman, (Tue Nov 20, 11:29 am)