Re: [patch][v2] x86, ptrace: support for branch trace store(BTS)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andi Kleen
Date: Tuesday, November 20, 2007 - 5:45 am

> - the internal buffer interpretation as well as the corresponding

I still think it would be far better if you would switch this over to be table
driven. e.g. define a record that contains offsetof()/sizeof() of the 
different formats and use generic functions. That would decrease
code size considerably.

Also those manpages are really needed.

And your patch seems to be word wrapped.

-Andi
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [patch][v2] x86, ptrace: support for branch trace stor ..., Andi Kleen, (Tue Nov 20, 5:45 am)
RE: [patch][v2] x86, ptrace: support for branch trace stor ..., Metzger, Markus T, (Tue Nov 20, 8:39 am)
RE: [patch][v2] x86, ptrace: support for branch trace stor ..., Metzger, Markus T, (Tue Nov 20, 8:49 am)
RE: [patch][v2] x86, ptrace: support for branch trace stor ..., Metzger, Markus T, (Wed Nov 21, 4:02 am)
RE: [patch][v2] x86, ptrace: support for branch trace stor ..., Metzger, Markus T, (Thu Nov 22, 1:06 pm)