[PATCH 05/18] x86 vDSO: harmonize asm-offsets

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>, Linus Torvalds <torvalds@...>, Thomas Gleixner <tglx@...>, Ingo Molnar <mingo@...>, H. Peter Anvin <hpa@...>
Cc: <linux-kernel@...>
Date: Monday, November 19, 2007 - 6:03 pm

This change harmonizes the asm-offsets macros used in the 32-bit vDSO
across 32-bit and 64-bit builds.  It's a purely cosmetic change for now,
but it paves the way for consolidating the 32-bit vDSO builds.

Signed-off-by: Roland McGrath <roland@redhat.com>
---
 arch/x86/kernel/asm-offsets_32.c        |   20 ++++++------
 arch/x86/kernel/vsyscall-sigreturn_32.S |   54 +++++++++++++++---------------
 2 files changed, 37 insertions(+), 37 deletions(-)

diff --git a/arch/x86/kernel/asm-offsets_32.c b/arch/x86/kernel/asm-offsets_32.c
index 0e45981..c578a2b 100644
--- a/arch/x86/kernel/asm-offsets_32.c
+++ b/arch/x86/kernel/asm-offsets_32.c
@@ -38,15 +38,15 @@ void foo(void);
 
 void foo(void)
 {
-	OFFSET(SIGCONTEXT_eax, sigcontext, eax);
-	OFFSET(SIGCONTEXT_ebx, sigcontext, ebx);
-	OFFSET(SIGCONTEXT_ecx, sigcontext, ecx);
-	OFFSET(SIGCONTEXT_edx, sigcontext, edx);
-	OFFSET(SIGCONTEXT_esi, sigcontext, esi);
-	OFFSET(SIGCONTEXT_edi, sigcontext, edi);
-	OFFSET(SIGCONTEXT_ebp, sigcontext, ebp);
-	OFFSET(SIGCONTEXT_esp, sigcontext, esp);
-	OFFSET(SIGCONTEXT_eip, sigcontext, eip);
+	OFFSET(IA32_SIGCONTEXT_eax, sigcontext, eax);
+	OFFSET(IA32_SIGCONTEXT_ebx, sigcontext, ebx);
+	OFFSET(IA32_SIGCONTEXT_ecx, sigcontext, ecx);
+	OFFSET(IA32_SIGCONTEXT_edx, sigcontext, edx);
+	OFFSET(IA32_SIGCONTEXT_esi, sigcontext, esi);
+	OFFSET(IA32_SIGCONTEXT_edi, sigcontext, edi);
+	OFFSET(IA32_SIGCONTEXT_ebp, sigcontext, ebp);
+	OFFSET(IA32_SIGCONTEXT_esp, sigcontext, esp);
+	OFFSET(IA32_SIGCONTEXT_eip, sigcontext, eip);
 	BLANK();
 
 	OFFSET(CPUINFO_x86, cpuinfo_x86, x86);
@@ -94,7 +94,7 @@ void foo(void)
 	BLANK();
 
 	OFFSET(EXEC_DOMAIN_handler, exec_domain, handler);
-	OFFSET(RT_SIGFRAME_sigcontext, rt_sigframe, uc.uc_mcontext);
+	OFFSET(IA32_RT_SIGFRAME_sigcontext, rt_sigframe, uc.uc_mcontext);
 	BLANK();
 
 	OFFSET(pbe_address, pbe, address);
diff --git a/arch/x86/kernel/vsyscall-sigreturn_32.S b/arch/x86/kernel/vsyscall-sigreturn_32.S
index a92262f..e939253 100644
--- a/arch/x86/kernel/vsyscall-sigreturn_32.S
+++ b/arch/x86/kernel/vsyscall-sigreturn_32.S
@@ -91,27 +91,27 @@ __kernel_rt_sigreturn:
 	.sleb128 offset;		/*       offset */		\
 1:
 
-	do_cfa_expr(SIGCONTEXT_esp+4)
-	do_expr(0, SIGCONTEXT_eax+4)
-	do_expr(1, SIGCONTEXT_ecx+4)
-	do_expr(2, SIGCONTEXT_edx+4)
-	do_expr(3, SIGCONTEXT_ebx+4)
-	do_expr(5, SIGCONTEXT_ebp+4)
-	do_expr(6, SIGCONTEXT_esi+4)
-	do_expr(7, SIGCONTEXT_edi+4)
-	do_expr(8, SIGCONTEXT_eip+4)
+	do_cfa_expr(IA32_SIGCONTEXT_esp+4)
+	do_expr(0, IA32_SIGCONTEXT_eax+4)
+	do_expr(1, IA32_SIGCONTEXT_ecx+4)
+	do_expr(2, IA32_SIGCONTEXT_edx+4)
+	do_expr(3, IA32_SIGCONTEXT_ebx+4)
+	do_expr(5, IA32_SIGCONTEXT_ebp+4)
+	do_expr(6, IA32_SIGCONTEXT_esi+4)
+	do_expr(7, IA32_SIGCONTEXT_edi+4)
+	do_expr(8, IA32_SIGCONTEXT_eip+4)
 
 	.byte 0x42	/* DW_CFA_advance_loc 2 -- nop; popl eax. */
 
-	do_cfa_expr(SIGCONTEXT_esp)
-	do_expr(0, SIGCONTEXT_eax)
-	do_expr(1, SIGCONTEXT_ecx)
-	do_expr(2, SIGCONTEXT_edx)
-	do_expr(3, SIGCONTEXT_ebx)
-	do_expr(5, SIGCONTEXT_ebp)
-	do_expr(6, SIGCONTEXT_esi)
-	do_expr(7, SIGCONTEXT_edi)
-	do_expr(8, SIGCONTEXT_eip)
+	do_cfa_expr(IA32_SIGCONTEXT_esp)
+	do_expr(0, IA32_SIGCONTEXT_eax)
+	do_expr(1, IA32_SIGCONTEXT_ecx)
+	do_expr(2, IA32_SIGCONTEXT_edx)
+	do_expr(3, IA32_SIGCONTEXT_ebx)
+	do_expr(5, IA32_SIGCONTEXT_ebp)
+	do_expr(6, IA32_SIGCONTEXT_esi)
+	do_expr(7, IA32_SIGCONTEXT_edi)
+	do_expr(8, IA32_SIGCONTEXT_eip)
 
 	.align 4
 .LENDFDEDLSI1:
@@ -128,15 +128,15 @@ __kernel_rt_sigreturn:
 	   slightly less complicated than the above, since we don't
 	   modify the stack pointer in the process.  */
 
-	do_cfa_expr(RT_SIGFRAME_sigcontext-4 + SIGCONTEXT_esp)
-	do_expr(0, RT_SIGFRAME_sigcontext-4 + SIGCONTEXT_eax)
-	do_expr(1, RT_SIGFRAME_sigcontext-4 + SIGCONTEXT_ecx)
-	do_expr(2, RT_SIGFRAME_sigcontext-4 + SIGCONTEXT_edx)
-	do_expr(3, RT_SIGFRAME_sigcontext-4 + SIGCONTEXT_ebx)
-	do_expr(5, RT_SIGFRAME_sigcontext-4 + SIGCONTEXT_ebp)
-	do_expr(6, RT_SIGFRAME_sigcontext-4 + SIGCONTEXT_esi)
-	do_expr(7, RT_SIGFRAME_sigcontext-4 + SIGCONTEXT_edi)
-	do_expr(8, RT_SIGFRAME_sigcontext-4 + SIGCONTEXT_eip)
+	do_cfa_expr(IA32_RT_SIGFRAME_sigcontext-4 + IA32_SIGCONTEXT_esp)
+	do_expr(0, IA32_RT_SIGFRAME_sigcontext-4 + IA32_SIGCONTEXT_eax)
+	do_expr(1, IA32_RT_SIGFRAME_sigcontext-4 + IA32_SIGCONTEXT_ecx)
+	do_expr(2, IA32_RT_SIGFRAME_sigcontext-4 + IA32_SIGCONTEXT_edx)
+	do_expr(3, IA32_RT_SIGFRAME_sigcontext-4 + IA32_SIGCONTEXT_ebx)
+	do_expr(5, IA32_RT_SIGFRAME_sigcontext-4 + IA32_SIGCONTEXT_ebp)
+	do_expr(6, IA32_RT_SIGFRAME_sigcontext-4 + IA32_SIGCONTEXT_esi)
+	do_expr(7, IA32_RT_SIGFRAME_sigcontext-4 + IA32_SIGCONTEXT_edi)
+	do_expr(8, IA32_RT_SIGFRAME_sigcontext-4 + IA32_SIGCONTEXT_eip)
 
 	.align 4
 .LENDFDEDLSI2:
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/18] x86 vDSO revamp, Roland McGrath, (Mon Nov 19, 5:59 pm)
[PATCH 16/18] x86 vDSO: ia32 vsyscall removal, Roland McGrath, (Mon Nov 19, 6:06 pm)
[PATCH 17/18] x86 vDSO: reorder vdso32 code, Roland McGrath, (Mon Nov 19, 6:07 pm)
[PATCH 15/18] x86 vDSO: consolidate vdso32, Roland McGrath, (Mon Nov 19, 6:06 pm)
Re: [PATCH 15/18] x86 vDSO: consolidate vdso32, Zachary Amsden, (Tue Nov 20, 8:13 pm)
Re: [PATCH 15/18] x86 vDSO: consolidate vdso32, Roland McGrath, (Tue Nov 20, 8:32 pm)
Re: [PATCH 15/18] x86 vDSO: consolidate vdso32, Andi Kleen, (Tue Nov 20, 8:15 pm)
Re: [PATCH 15/18] x86 vDSO: consolidate vdso32, Ingo Molnar, (Tue Nov 20, 8:13 pm)
[PATCH 14/18] x86 vDSO: ia32 vdso32-syscall build, Roland McGrath, (Mon Nov 19, 6:06 pm)
[PATCH 18/18] x86 vDSO: makefile cleanup, Roland McGrath, (Mon Nov 19, 6:07 pm)
[PATCH 13/18] x86 vDSO: ia32 sysenter_return, Roland McGrath, (Mon Nov 19, 6:06 pm)
Re: [PATCH 13/18] x86 vDSO: ia32 sysenter_return, Zachary Amsden, (Tue Nov 20, 8:05 pm)
Re: [PATCH 13/18] x86 vDSO: ia32 sysenter_return, Roland McGrath, (Tue Nov 20, 8:34 pm)
[PATCH 12/18] x86 vDSO: ia32_sysenter_target, Roland McGrath, (Mon Nov 19, 6:06 pm)
[PATCH 08/18] x86 vDSO: i386 vdso32, Roland McGrath, (Mon Nov 19, 6:05 pm)
[PATCH 11/18] x86 vDSO: vdso32 setup, Roland McGrath, (Mon Nov 19, 6:06 pm)
[PATCH 10/18] x86 vDSO: i386 vdso32 install, Roland McGrath, (Mon Nov 19, 6:05 pm)
[PATCH 09/18] x86 vDSO: absolute relocs, Roland McGrath, (Mon Nov 19, 6:05 pm)
[PATCH 07/18] x86 vDSO: vdso32 build, Roland McGrath, (Mon Nov 19, 6:05 pm)
Re: [PATCH 07/18] x86 vDSO: vdso32 build, Sam Ravnborg, (Wed Nov 21, 2:02 am)
Re: [PATCH 07/18] x86 vDSO: vdso32 build, Roland McGrath, (Wed Nov 21, 3:10 am)
Re: [PATCH 07/18] x86 vDSO: vdso32 build, Sam Ravnborg, (Wed Nov 21, 3:32 am)
Re: [PATCH 07/18] x86 vDSO: vdso32 build, Roland McGrath, (Wed Nov 21, 3:55 am)
[PATCH 06/18] x86 vDSO: arch/x86/vdso/vdso32, Roland McGrath, (Mon Nov 19, 6:04 pm)
Re: [PATCH 06/18] x86 vDSO: arch/x86/vdso/vdso32, Thomas Gleixner, (Tue Nov 20, 9:05 am)
Re: [PATCH 06/18] x86 vDSO: arch/x86/vdso/vdso32, Roland McGrath, (Tue Nov 20, 4:57 pm)
Re: [PATCH 06/18] x86 vDSO: arch/x86/vdso/vdso32, Thomas Gleixner, (Tue Nov 20, 7:07 pm)
Re: [PATCH 06/18] x86 vDSO: arch/x86/vdso/vdso32, Roland McGrath, (Tue Nov 20, 7:27 pm)
Re: [PATCH 06/18] x86 vDSO: arch/x86/vdso/vdso32, Linus Torvalds, (Mon Nov 26, 9:53 pm)
Re: [PATCH 06/18] x86 vDSO: arch/x86/vdso/vdso32, Roland McGrath, (Mon Nov 26, 10:01 pm)
Re: [PATCH 06/18] x86 vDSO: arch/x86/vdso/vdso32, Thomas Gleixner, (Tue Nov 20, 7:50 pm)
[PATCH 04/18] x86 vDSO: new layout, Roland McGrath, (Mon Nov 19, 6:03 pm)
[PATCH 05/18] x86 vDSO: harmonize asm-offsets, Roland McGrath, (Mon Nov 19, 6:03 pm)
[PATCH 03/18] x86 vDSO: remove vdso-syms.o, Roland McGrath, (Mon Nov 19, 6:02 pm)
[PATCH 02/18] x86 vDSO: use vdso-syms.lds, Roland McGrath, (Mon Nov 19, 6:02 pm)
[PATCH 01/18] x86 vDSO: generate vdso-syms.lds, Roland McGrath, (Mon Nov 19, 6:01 pm)