Home » Mailing list archives » linux-kernel » 2007 » November » 17

[patch] Printk kernel version in WARN_ON

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Arjan van de Ven <arjan@...>
To: <linux-kernel@...>
Cc: <mingo@...>, <tglx@...>, <akpm@...>
Subject: [patch] Printk kernel version in WARN_ON
Date: Saturday, November 17, 2007 - 2:15 pm

Hi,

today, all oopses contain a version number of the kernel, which is nice
because the people who actually do bother to read the oops get this
vital bit of information always without having to ask the reporter in
another round trip.

However, WARN_ON() right now lacks this information; the patch below
adds this. This information is essential for getting people to use
their time effectively when looking at these things; in addition, it's
essential for tools that try to collect statistics about defects.

Please consider, maybe even for 2.6.24 since its so simple and
important for long term quality

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>

--- linux-2.6.24-rc3/include/asm-generic/bug.h.org	2007-11-17 09:55:00.000000000 -0800
+++ linux-2.6.24-rc3/include/asm-generic/bug.h	2007-11-17 10:11:23.000000000 -0800
@@ -2,6 +2,7 @@
 #define _ASM_GENERIC_BUG_H
 
 #include <linux/compiler.h>
+#include <linux/utsrelease.h>
 
 #ifdef CONFIG_BUG
 
@@ -35,8 +36,8 @@ struct bug_entry {
 #define WARN_ON(condition) ({						\
 	int __ret_warn_on = !!(condition);				\
 	if (unlikely(__ret_warn_on)) {					\
-		printk("WARNING: at %s:%d %s()\n", __FILE__,		\
-			__LINE__, __FUNCTION__);			\
+		printk("WARNING: at %s:%d %s()  (%s)\n", __FILE__,	\
+			__LINE__, __FUNCTION__, UTS_RELEASE);		\
 		dump_stack();						\
 	}								\
 	unlikely(__ret_warn_on);					\


-- 
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch] Printk kernel version in WARN_ON, Arjan van de Ven, (Sat Nov 17, 2:15 pm)
Re: [patch] Printk kernel version in WARN_ON, Denys Vlasenko, (Sat Nov 17, 7:02 pm)
Re: [patch] Printk kernel version in WARN_ON, Sam Ravnborg, (Sat Nov 17, 3:28 pm)
Re: [patch] Printk kernel version in WARN_ON, Andrew Morton, (Sat Nov 17, 2:27 pm)
Re: [patch] Printk kernel version in WARN_ON, Arjan van de Ven, (Sat Nov 17, 2:39 pm)
Re: [patch] Printk kernel version in WARN_ON, Andrew Morton, (Sat Nov 17, 2:46 pm)
Re: [patch] Printk kernel version in WARN_ON, Arjan van de Ven, (Sat Nov 17, 3:35 pm)
Re: [patch] Printk kernel version in WARN_ON, Ingo Molnar, (Sat Nov 17, 8:42 pm)
Re: [patch] Printk kernel version in WARN_ON, Andrew Morton, (Sat Nov 17, 8:57 pm)
Re: [patch] Printk kernel version in WARN_ON, Arjan van de Ven, (Sun Nov 18, 1:18 pm)
Re: [patch] Printk kernel version in WARN_ON, Ingo Molnar, (Sat Nov 17, 9:04 pm)
Re: [patch] Printk kernel version in WARN_ON, Sam Ravnborg, (Sat Nov 17, 3:42 pm)
Re: [patch] Printk kernel version in WARN_ON, Pavel Machek, (Wed Nov 21, 8:51 am)