login
Header Space

 
 

Re: [PATCH/RFC] eradicate bashisms in scripts/patch-kernel

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Randy Dunlap <rdunlap@...>
Cc: Andreas Mohr <andi@...>, Herbert Xu <herbert@...>, Andrew Morton <akpm@...>, Linux Kernel Mailing List <linux-kernel@...>
Date: Saturday, November 17, 2007 - 12:33 pm

Hi,

On Wed, Nov 14, 2007 at 02:46:27PM -0800, Randy Dunlap wrote:

Sorry, no, using dash (0.5.3-5) there's still a remaining

$ linux-2.6.22/scripts/patch-kernel linux-2.6.22 /usr/src/patch-2.6
Current kernel version is 2.6.22 ( Holy Dancing Manatees, Batman!)
linux-2.6.22/scripts/patch-kernel: 207: Syntax error: Bad substitution

error in the

# strip EXTRAVERSION to just a number (drop leading '.' and trailing additions)
EXTRAVER=
if [ x$EXTRAVERSION != "x" ]
then
                EXTRAVER=${EXTRAVERSION:1}
        else
                EXTRAVER=$EXTRAVERSION
        fi
        EXTRAVER=${EXTRAVER%%[[:punct:]]*}
        #echo "$PNAME: changing EXTRAVERSION from $EXTRAVERSION to $EXTRAVER"
fi

part, which the sed expression (moderately successfully) tried to
take care of.

The good part of the story is that the current corrected almost fully
working version still works with bash (3.1dfsg-8), just like the
original patch-kernel version.

Signed-off-by would be fine by me.

Thanks,

Andreas Mohr
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH/RFC] eradicate bashisms in scripts/patch-kernel, Andreas Mohr, (Wed Oct 31, 5:13 pm)
Re: [PATCH/RFC] eradicate bashisms in scripts/patch-kernel, Andreas Mohr, (Sat Nov 17, 12:33 pm)
[PATCH] eradicate bashisms in scripts/patch-kernel, Andreas Mohr, (Sat Nov 17, 4:51 pm)
Re: [PATCH] eradicate bashisms in scripts/patch-kernel, Randy Dunlap, (Wed Jan 2, 7:00 pm)
speck-geostationary