Re: [Patch] Fix UML broken (was Re: User Mode Linux still broken in 2.6.23.1)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Greg KH <greg@...>
Cc: Rob Landley <rob@...>, WANG Cong <xiyou.wangcong@...>, <linux-kernel@...>, <akpm@...>, Chris Wright <chrisw@...>
Date: Friday, November 16, 2007 - 11:51 am

On Thu, Nov 15, 2007 at 11:15:27PM -0800, Greg KH wrote:

I wouldn't.

sparc includes swap.h in its pgtable.h.  Adding pagemap.h to swap.h
completes an include loop on sparc which blows up its build.

I have a set of patches to fix this in a different way, which I sent
out for comments a few weeks ago.  They
	add uaccess.h to various futexes.h because these will start
failing to build when the next patch is applied
	break the recursion by removing highmem.h from pagemap.h,
which needs nothing related to highmem, and sprinkle includes of
highmem.h in all the files which formerly got it through pagemap.h
	now, pagemap.h can be added to swap.h without blowing up sparc
	also, the other arches can include swap.h in their pgtables.h,
which they probably should since they define operations on
swp_entry_t, which is defined in swap.h.

				Jeff

-- 
Work email - jdike at linux dot intel dot com

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
User Mode Linux still broken in 2.6.23.1, Rob Landley, (Sun Nov 4, 12:51 am)
Re: User Mode Linux still broken in 2.6.23.1, Greg KH, (Wed Nov 14, 2:54 pm)
Re: User Mode Linux still broken in 2.6.23.1, Rob Landley, (Thu Nov 15, 1:58 am)
Re: User Mode Linux still broken in 2.6.23.1, Greg KH, (Thu Nov 15, 2:02 am)
Re: User Mode Linux still broken in 2.6.23.1, Rob Landley, (Thu Nov 15, 4:57 pm)
Re: User Mode Linux still broken in 2.6.23.1, Greg KH, (Thu Nov 15, 5:06 pm)
Re: [Patch] Fix UML broken (was Re: User Mode Linux still br..., Jeff Dike, (Fri Nov 16, 11:51 am)