Re: [PATCH 38/54] efivars: remove new_var and del_var files from sysfs

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Matt Domsch <Matt_Domsch@...>

To: Greg Kroah-Hartman <gregkh@...>

Cc: <linux-kernel@...>, Kay Sievers <kay.sievers@...>, Matt Tolentino <matthew.e.tolentino@...>

Subject: Re: [PATCH 38/54] efivars: remove new_var and del_var files from sysfs

Date: Friday, November 16, 2007 - 11:01 am

On Fri, Nov 02, 2007 at 04:59:16PM -0700, Greg Kroah-Hartman wrote:
quoted text> WTF?  Passing binary structures into a sysfs file, expecting it to be in
> the correct format/endianness?  That's just wrong on so many levels.
> 
> So, these files are deleted.  If you want to add them back, please do so
> in configfs, or in debugfs.  Or use text strings, which is what sysfs is
> only for.

I have tested gregkh's patches tree, which includes this patch, the
patch to put these back as binary blob interfaces, as well as other
cleanups, on an Itanium2 system.  The efibootmgr userspace application
continues to work as it did before this patch series, which I claim is
success.  For the patches that touch drivers/firmware/efivars.c I can
say:

Tested-by: Matt Domsch <Matt_Domsch@dell.com>

Thanks,
Matt

-- 
Matt Domsch
Linux Technology Strategist, Dell Office of the CTO
linux.dell.com & www.dell.com/linux
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[RFC] kobject and kset core changes and cleanups, Greg KH, (Fri Nov 2, 7:57 pm)

Re: [RFC] kobject and kset core changes and cleanups, Andrew Morton, (Tue Nov 6, 4:04 am)

Re: [RFC] kobject and kset core changes and cleanups, Andrew Morton, (Tue Nov 6, 3:11 am)

Re: [RFC] kobject and kset core changes and cleanups, Stephane Eranian, (Tue Nov 6, 4:14 am)

Re: [RFC] kobject and kset core changes and cleanups, Greg KH, (Tue Nov 6, 5:15 pm)

Re: [RFC] kobject and kset core changes and cleanups, Stephane Eranian, (Tue Nov 6, 5:33 pm)

Re: [RFC] kobject and kset core changes and cleanups, Andrew Morton, (Tue Nov 6, 2:25 am)

[PATCH 54/54] kset: remove decl_subsys macro, Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 53/54] kset: convert ocfs2 to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 47/54] kobject: convert parisc/pdc_stable to kobj_att..., Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 52/54] firmware: remove firmware_(un)register(), Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 51/54] kset: convert acpi to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 50/54] kset: convert edd to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 48/54] kset: convert parisc/pdc_stable.c to use kset_..., Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 49/54] Driver Core: kill subsys_attribute and default..., Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 46/54] kset: convert s390 ipl.c to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

Re: [PATCH 46/54] kset: convert s390 ipl.c to use kset_create, Cornelia Huck, (Mon Nov 5, 6:27 am)

Re: [PATCH 46/54] kset: convert s390 ipl.c to use kset_create, Greg KH, (Mon Nov 5, 1:05 pm)

[PATCH 45/54] kobject: convert s390 ipl.c to kobj_attr inter..., Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 42/54] kset: convert efivars to use kset_create for t..., Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 44/54] kobject: convert pseries/power.c to kobj_attr ..., Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 38/54] efivars: remove new_var and del_var files from..., Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

Re: [PATCH 38/54] efivars: remove new_var and del_var files ..., Matt Domsch, (Fri Nov 16, 11:01 am)

Re: [PATCH 38/54] efivars: remove new_var and del_var files ..., Greg KH, (Tue Nov 27, 1:47 am)

[PATCH 43/54] kobject: convert arm/mach-omap1/pm.c to kobj_a..., Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 40/54] firmware: export firmware_kset so that people ..., Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 41/54] kset: convert efivars to use kset_create for t..., Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 39/54] kobject: convert efivars to kobj_attr interface, Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 37/54] ecryptfs: remove version_str file from sysfs, Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 33/54] driver core: remove fields from struct bus_type, Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

Re: [PATCH 33/54] driver core: remove fields from struct bus..., Cornelia Huck, (Mon Nov 5, 6:33 am)

Re: [PATCH 33/54] driver core: remove fields from struct bus..., Greg KH, (Mon Nov 5, 1:00 pm)

[PATCH 35/54] Driver Core: switch all dynamic ksets to kobj_..., Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 36/54] fix struct user_info export's sysfs interaction, Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 34/54] Driver Core: add kobj_attribute handling, Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

Re: [PATCH 34/54] Driver Core: add kobj_attribute handling, Cornelia Huck, (Mon Nov 5, 8:42 am)

Re: [PATCH 34/54] Driver Core: add kobj_attribute handling, Kay Sievers, (Mon Nov 5, 12:23 pm)

Re: [PATCH 34/54] Driver Core: add kobj_attribute handling, Greg KH, (Mon Nov 5, 1:11 pm)

Re: [PATCH 34/54] Driver Core: add kobj_attribute handling, Kay Sievers, (Mon Nov 5, 1:25 pm)

Re: [PATCH 34/54] Driver Core: add kobj_attribute handling, Cornelia Huck, (Mon Nov 5, 1:43 pm)

Re: [PATCH 34/54] Driver Core: add kobj_attribute handling, Kay Sievers, (Mon Nov 5, 2:07 pm)

Re: [PATCH 34/54] Driver Core: add kobj_attribute handling, Cornelia Huck, (Mon Nov 5, 2:17 pm)

Re: [PATCH 34/54] Driver Core: add kobj_attribute handling, Kay Sievers, (Mon Nov 5, 2:39 pm)

Re: [PATCH 34/54] Driver Core: add kobj_attribute handling, Cornelia Huck, (Mon Nov 5, 2:59 pm)

Re: [PATCH 34/54] Driver Core: add kobj_attribute handling, Greg KH, (Mon Nov 5, 4:01 pm)

Re: [PATCH 34/54] Driver Core: add kobj_attribute handling, Greg KH, (Mon Nov 5, 2:46 pm)

[PATCH 31/54] driver core: add way to get to bus kset, Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 32/54] driver core: add way to get to bus device klist, Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 30/54] driver core: remove owner field from struct bu..., Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 28/54] kset: convert struct bus_device->devices to..., Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 29/54] kset: convert struct bus_device->drivers to..., Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 27/54] kset: convert s390 hypervisor kset to use kset..., Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

Re: [PATCH 27/54] kset: convert s390 hypervisor kset to use ..., Cornelia Huck, (Mon Nov 5, 9:18 am)

Re: [PATCH 27/54] kset: convert s390 hypervisor kset to use ..., Greg KH, (Mon Nov 5, 1:06 pm)

[PATCH 26/54] kset: convert /sys/power to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 25/54] kset: convert /sys/module to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 22/54] kset: convert /sys/devices/system to use kset_..., Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

Re: [PATCH 22/54] kset: convert /sys/devices/system to use k..., Cornelia Huck, (Mon Nov 5, 2:11 pm)

Re: [PATCH 22/54] kset: convert /sys/devices/system to use k..., Greg KH, (Mon Nov 5, 2:58 pm)

Re: [PATCH 22/54] kset: convert /sys/devices/system to use k..., Cornelia Huck, (Mon Nov 5, 3:11 pm)

Re: [PATCH 22/54] kset: convert /sys/devices/system to use k..., Greg KH, (Mon Nov 5, 4:03 pm)

Re: [PATCH 22/54] kset: convert /sys/devices/system to use k..., Andrew Morton, (Tue Nov 13, 7:14 pm)

Re: [PATCH 22/54] kset: convert /sys/devices/system to use k..., Andrew Morton, (Tue Nov 13, 8:01 pm)

Re: [PATCH 22/54] kset: convert /sys/devices/system to use k..., Greg KH, (Tue Nov 13, 8:35 pm)

Re: [PATCH 22/54] kset: convert /sys/devices/system to use k..., Andrew Morton, (Wed Nov 14, 3:35 am)

[PATCH 24/54] kset: move /sys/slab to /sys/kernel/slab, Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 23/54] kset: convert slub to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 7:59 pm)

[PATCH 16/54] kset: convert kernel_subsys to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 20/54] kset: convert /sys/devices to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 21/54] kset: convert /sys/hypervisor to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 19/54] kset: convert drivers/base/firmware.c kset_cre..., Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 17/54] kset: convert drivers/base/bus.c kset_create_a..., Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 18/54] kset: convert drivers/base/class.c kset_create..., Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 15/54] kset: remove decl_subsys_name, Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 13/54] kset: convert dlm to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 14/54] kset: convert pci hotplug to use kset_create_a..., Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 12/54] kset: convert gfs2 dlm to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 11/54] kset: convert gfs2 to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 10/54] kset: convert main fs kset to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 09/54] kset: convert ecryptfs to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 06/54] kset: convert securityfs to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 08/54] kset: convert configfs to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 07/54] kset: convert debugfs to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 05/54] kset: convert fuse to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 04/54] kset: add kset_create_and_register function, Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 03/54] KOBJECT: remove kobj_set_kset_s as no one is u..., Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 02/54] KOBJECT: remove struct kobj_type from struct k..., Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

[PATCH 01/54] ecryptfs: clean up attribute mess, Greg Kroah-Hartman, (Fri Nov 2, 7:58 pm)

Navigation

Popular discussions


linux-kernel:
Tony Lindgren	[PATCH 26/90] ARM: OMAP: abstract debug card setup (smc, leds)
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Vladislav Bolkhovitin	Re: Integration of SCST in the mainstream Linux kernel
Jesper Juhl	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
git:

linux-netdev:
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
Frans Pop	svc: failed to register lockdv1 RPC service (errno 97).
openbsd-misc:

Colocation donated by:

Online users

Syndicate