Re: x86: disable preemption in delay_tsc()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: Arjan van de Ven <arjan@...>, Linux Kernel Mailing List <linux-kernel@...>
Date: Friday, November 16, 2007 - 3:26 am

On Fri, 16 Nov 2007 08:17:08 +0100 Ingo Molnar <mingo@elte.hu> wrote:


Ow.  So the above timeout would take 10x longer.  That probably won't break
anything, but quite a few drivers do udelay(1) for post-IO settling times
and they might not like it.


Yup, with a few smarts in there we could work out which is the best to use,
and also compensate for the setup costs.

It doesn't sound very 2.6.24ish though.

As a quicky things perhaps we could only do the preempt_disable()/preempt_enable()
if the TSCs are unsynced?  Do we reliably know that?  I guess not..
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: x86: disable preemption in delay_tsc(), Arjan van de Ven, (Thu Nov 15, 11:41 pm)
Re: x86: disable preemption in delay_tsc(), Avi Kivity, (Fri Nov 16, 4:08 am)
Re: x86: disable preemption in delay_tsc(), Ingo Molnar, (Fri Nov 16, 4:36 am)
[patch] x86: make delay_tsc() preemptible again, Ingo Molnar, (Fri Nov 16, 4:47 am)
Re: [patch] x86: make delay_tsc() preemptible again, Peter Zijlstra, (Fri Nov 16, 5:39 am)
Re: [patch] x86: make delay_tsc() preemptible again, Ingo Molnar, (Fri Nov 16, 6:50 am)
Re: x86: disable preemption in delay_tsc(), Andrew Morton, (Thu Nov 15, 11:52 pm)
Re: x86: disable preemption in delay_tsc(), Ingo Molnar, (Fri Nov 16, 2:13 am)
Re: x86: disable preemption in delay_tsc(), Andrew Morton, (Fri Nov 16, 3:08 am)
Re: x86: disable preemption in delay_tsc(), Ingo Molnar, (Fri Nov 16, 3:17 am)
Re: x86: disable preemption in delay_tsc(), Andrew Morton, (Fri Nov 16, 3:26 am)