linux-kernel mailing list

FromSubjectsort iconDate
Jeff Dike
mm creation/destruction hooks
The changelog for commit d6dd61c831226f9cd7750885da04d360d6455101 says arch_dup_mmap, which is called when a new mmap is created at fork Is there a reason that you're not tracking mm creation in exec? Jeff -
Nov 15, 7:46 pm 2007
THUNDERBALL END OF Y...
hello!!!
You have been awarded the sum of 250,000.00GBP by the thunderballpromotions. contact this email. gill_william60@hotmail.com phone:+447045708596 Thank you -
Nov 15, 7:39 pm 2007
Andrew Morton
Re: [PATCH 3/4] bas_gigaset: suspend support (v2)
On Tue, 13 Nov 2007 18:30:30 +0100 (CET) that's pretty peculiar. We'd only expect to see atomics being used in conjunction with atomic_add/sub/inc/etc. Here the driver is using an atomic_t as a state variable. And here's the magic bit: spin_lock_irqsave(&ucs->lock, flags); state = atomic_read(&ucs->basstate); atomic_set(&ucs->basstate, (state & ~clear) | set); spin_unlock_irqrestore(&ucs->lock, flags); I'm suspecting that a plain old `int' would be more a...
Nov 15, 6:50 pm 2007
Tilman Schmidt
Re: [PATCH 3/4] bas_gigaset: suspend support (v2)
You're right. That's a prehistoric leftover. That variable was originally accessed using atomic_set_mask() and atomic_clear_mask() which are unfortunately x86 platform specific. I'll prepare a cleanup patch. Thanks, Tilman --=20 Tilman Schmidt E-Mail: tilman@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Unge=F6ffnet mindestens haltbar bis: (siehe R=FCckseite)
Nov 15, 7:51 pm 2007
Stefan Monnier
Treat disk space like memory space
The normal situation on the memory is side is that most of the memory is in use, but some pages are ready to be discarded, they're just kept around because we have nothing better to do (yet) with that page. Is there a tool to do something similar with file systems. I have a lot of unimportant files in my file-system, typically browser caches and things like that, which can be thrown away without any risk of losing data. I just keep them around because I have nothing better to do with my disk sp...
Nov 15, 6:24 pm 2007
Rob Mueller
Re: mmap dirty limits on 32 bit kernels (Was: [BUG] New Kern...
From our perspective, the main issue is that some of these machines we spent quite a bit of money on the big RAM (for it's day) + lots of 15k RPM SCSI drives + multi-year support contracts. They're highly IO bound, and barely use 10-20% of their old 2.4Ghz Prestonia Xeon CPUs. It's hard to justify junking those machines < 5 years. We have a couple of 6G machines and some 8G machines using PAE. On the whole, they actually have been working really well (hmmm, apart from the recent dirty pa...
Nov 15, 6:24 pm 2007
Hiroshi Shimamoto
[PATCH] x86: clean up nmi_32/64.c
Subject: [PATCH] x86: clean up nmi_32/64.c clean up and make nmi_32/64.c more similar. - white space and coding style clean up. - nmi_cpu_busy is available on CONFIG_SMP. - move functions __acpi_nmi_enable, acpi_nmi_enable, __acpi_nmi_disable and acpi_nmi_disable. - make variables name more similar. Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> --- arch/x86/kernel/nmi_32.c | 18 +++++---- arch/x86/kernel/nmi_64.c | 92 +++++++++++++++++++++++----------------------- ...
Nov 15, 6:14 pm 2007
Jeremy Fitzhardinge
Why preallocate pmd in x86 32-bit PAE?
I'm looking at unifying asm-x86/pgalloc*.h, and so I'm trying to make things as similar as possible between 32 and 64-bit. Once difference is that 64-bit incrementally allocates all levels of the pagetable, whereas 32-bit PAE preallocates the 4 pmds when it allocates the pgd. What's the rationale for this? What pitfalls would there be in making them incrementally allocated? Preallocation makes sense from the perspective that they will all be allocated almost immediately in a typical process. B...
Nov 15, 5:57 pm 2007
Linus Torvalds
Re: Why preallocate pmd in x86 32-bit PAE?
IIRC, the present bit is ignored in the magic 4-entry PGD. All entries have to be present. What earlier CPU's did was to basically load all four values into the CPU when you loaded %cr3. There was no "three-level page table walker" at all: it was still a two-level page table walker, there were just for magic internal page tables that were indexed off the two high bits. Linus -
Nov 15, 6:12 pm 2007
H. Peter Anvin
Re: Why preallocate pmd in x86 32-bit PAE?
This is true, although you could point a PGD to an all-zero page if you really wanted to. You have to re-load CR3 after modifying the top-level They still are. Loading CR3 in PAE really loads four registers from memory. x86-64 is different, of course. -hpa -
Nov 15, 6:42 pm 2007
Jeremy Fitzhardinge
[PATCH RESEND] xen: mask _PAGE_PCD from ptes
_PAGE_PCD maps a page with caching disabled, which is typically used for mapping harware registers. Xen never allows it to be set on a mapping, and unprivileged guests never need it since they can't see the real underlying hardware. However, some uncached mappings are made early when probing the (non-existent) APIC, and its OK to mask off the PCD flag in these cases. This became necessary because Xen started checking for this bit, rather than silently masking it off. Signed-off-by: Jeremy Fitz...
Nov 15, 5:49 pm 2007
Lucy McCoy
Re: [PATCH] keyspan: init termios properly
Hi Boris, Actually the 19HS is the usa90 so it is included in the switch but that isn't a problem. I'm not familiar with the termios stuff on Linux so can you take a look at the following modified code to see if this solves your NULL ptr problem? Also,.... Does cflag need to be set to anything other than CS8? Is keyspan_open_port() always followed by a keyspan_set_termios()? Thanks, Lucy static int keyspan_open (struct usb_serial_port *port, struct file *filp) { struct keyspan...
Nov 15, 5:10 pm 2007
Nicholas A. Bellinger
[ANNOUNCE] - Linux-iSCSI.org Storage Engine goes online!
Greetings all, It is my great pleasure to announce that the Linux-iSCSI.org project has reached its first 2.9-BETA release and its now offering the ability to build source against any RPM or DEB based kernel and distribution. The Linux-iSCSI.org West cluster is offering binaries for CentOS 5 and Debian 4, and instructions are now online. This project provides the infrastructure pieces required to run a production IP storage fabric, and is constantly evolving. The complete target stack, which i...
Nov 15, 4:25 pm 2007
Ingo Molnar
[git pull] scheduler fixes
Linus, please pull the latest scheduler git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git it includes 3 fixes and 3 cleanups. Build and boot tested on 64-bit and 32-bit x86. Thanks, Ingo ------------------> Adrian Bunk (1): sched: make sched_nr_latency static Christian Borntraeger (1): sched: fix accounting of interrupts during guest execution on s390 Dmitry Adamushko (2): sched: fix __set_task_cpu() SMP race sche...
Nov 15, 4:09 pm 2007
Dave Jones
strange oops in iput. (2.6.23.1)
I got a report from a user this morning with the following oops. Unable to handle kernel NULL pointer dereference at 0000000000000038 RIP: [<ffffffff810ad479>] iput+0x18/0x7b PGD 6fdf9067 PUD 7810c067 PMD 0 Oops: 0000 [1] SMP CPU 1 Modules linked in: berry_charge tun vfat fat usb_storage appletalk ipx p8023 i915 drm dcdbas ipt_MASQUERADE iptable_nat nf_nat bridge rfcomm l2cap autofs4 sunrpc nf_conntrack_netbios_ns ipt_REJECT nf_conntrack_ipv4 xt_state nf_conntrack nfnetlink iptable_filter ip_...
Nov 15, 3:05 pm 2007
Jean Delvare
[GIT PULL] i2c fixes for 2.6.24
Linus, Please pull the i2c subsystem fixes for Linux 2.6.24 from: git://jdelvare.pck.nerim.net/jdelvare-2.6 i2c-for-linus There are fixes to the i2c-dev, i2c-pasemi and eeprom drivers, and comment updates. drivers/i2c/busses/i2c-pasemi.c | 7 +++- drivers/i2c/chips/eeprom.c | 37 +++++++++++------ drivers/i2c/i2c-core.c | 3 +- drivers/i2c/i2c-dev.c | 86 ++++++++++++++++++++++++++++++++++++++- include/linux/i2c.h | 5 -- 5 files changed, 1...
Nov 15, 2:50 pm 2007
Cyrill Gorcunov
[PATCH] PPC: Fix potential NULL dereference
This patch does fix potential NULL pointer dereference that could take place inside of strcmp() if of_get_property() call failed. Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- arch/powerpc/platforms/83xx/usb.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/platforms/83xx/usb.c b/arch/powerpc/platforms/83xx/usb.c index eafe760..b45160f 100644 --- a/arch/powerpc/platforms/83xx/usb.c +++ b/arch/powerpc/platforms/83xx/usb.c @@ -130,7...
Nov 15, 2:47 pm 2007
Steven Rostedt
2.6.24-rc2-rt1
Finally! We are pleased to announce 2.6.24-rc2-rt1. This is probably one of the toughest ports the -rt patch had to face. It was definitely the toughest one I had to perform. With a 50 Meg difference between 2.6.23 and 2.6.24-rc2 it caused a lot of problems with conflicts. The 2.6.23.1-rt11 patch consisted of 386 patches. Of them 25 of them were incorporated into mainline (mostly hrtimers for x86_64 and other archs). With fixes and such, the 2.6.24-rc2-rt1 has 370 patches. 361 of them came ...
Nov 15, 2:40 pm 2007
Mark Knecht
Re: 2.6.24-rc2-rt1
<SNIP> Hi Steve, Not sure I've ever posted on this list. Always looking to help out at my low level. Anyway, I tried building the kernel. My 1st two attempts, done running make menuconfig from scratch, didn't boot. I gave up on that for now and tried using make oldconfig from my 2.6.23-rt1 kernel (I'm so far behind!!) and ended up with this error. Not sure it's enough for you to find the bug. If you want/need more or want the config file let me know. I'm sure this is just me s...
Nov 15, 4:41 pm 2007
Steven Rostedt
Re: 2.6.24-rc2-rt1
Definitely looks like a config bug. You can send me your config off list. Hmm, I need to do a allyesconfig, but I'm not even sure 2.6.24-rc2 would compile with that. Thanks, -- Steve -
Nov 15, 4:54 pm 2007
Mark Knecht Nov 15, 5:09 pm 2007
Ulrich Drepper
[PATCHv2 2/4] x86&x86-64 support for sys_indirect
This part adds support for sys_indirect on x86 and x86-64. arch/x86/ia32/ia32entry.S | 1 + b/arch/x86/kernel/syscall_table_32.S | 1 + b/include/asm-x86/indirect.h | 5 +++++ b/include/asm-x86/indirect_32.h | 23 +++++++++++++++++++++++ b/include/asm-x86/indirect_64.h | 24 ++++++++++++++++++++++++ b/include/asm-x86/unistd_32.h | 3 ++- b/include/asm-x86/unistd_64.h | 2 ++ 7 files changed, 58 insertions(+), 1 deletion(-) --- a/arc...
Nov 15, 2:22 pm 2007
Frederik Deweerdt
Re: [PATCHv2 2/4] x86&x86-64 support for sys_indirect
Hello Ulrich, Regards, Frederik -
Nov 15, 3:29 pm 2007
Ulrich Drepper
Re: [PATCHv2 2/4] x86&x86-64 support for sys_indirect
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Frederik Deweerdt wrote: \>> + sys_call_table[INDIRECT_SYSCALL(regs)->eax] ((regs)->ebx, Yep, my bad. I've retired the 32-bit machines around here. - -- ➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iD8DBQFHPKcp2ijCOnn/RHQRAjqMAKCLra+KisV6inTbPrbLtqruDVKyxACgxRLf kFDyF...
Nov 15, 4:08 pm 2007
Ingo Molnar
Re: [PATCHv2 2/4] x86&x86-64 support for sys_indirect
weird - i built it on 32-bit and it should have failed the build? Ingo -
Nov 15, 4:12 pm 2007
Ulrich Drepper
Re: [PATCHv2 2/4] x86&x86-64 support for sys_indirect
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Not weird, since I've changed that file after Linus' comment. The mistake I made was to reuse the old 0/0 mail with your s-o-b line without asking you again. Sorry. - -- ➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iD8DBQFHPKkm2ijCOnn/RHQRAkY2AKCRfOhk5pUrYuTSMWnBBgu0Ou0fJACfQVz1 qzh...
Nov 15, 4:16 pm 2007
Ulrich Drepper
[PATCHv2 3/4] x86&x86-64 UML support for sys_indirect
This part adds support for sys_indirect on UML on x86 and x86-64. indirect.h | 6 ++++++ 1 file changed, 6 insertions(+) --- /dev/null 2007-09-23 16:36:38.465394704 -0700 +++ b/include/asm-um/indirect.h 2007-11-15 09:56:23.000000000 -0800 @@ -0,0 +1,6 @@ +#ifndef __UM_INDIRECT_H +#define __UM_INDIRECT_H + +#include "asm/arch/indirect.h" + +#endif -
Nov 15, 2:22 pm 2007
Ulrich Drepper
[PATCHv2 0/4] sys_indirect system call
The following patches provide an alternative implementation of the sys_indirect system call which has been discussed a few times. This no system call allows us to extend existing system call interfaces with adding more system calls. Davide's previous implementation is IMO far more complex than warranted. This code here is trivial, as you can see. I've discussed this approach with Linus last week and for a brief moment we actually agreed on something. *=*=* CHANGED We pass an additional block ...
Nov 15, 2:22 pm 2007
Ulrich Drepper
[PATCHv2 1/4] actual sys_indirect code
This is the actual architecture-independent part of the system call implementation. b/include/linux/indirect.h | 13 ++++++++++++ b/include/linux/syscalls.h | 3 ++ b/kernel/Makefile | 2 - b/kernel/indirect.c | 46 +++++++++++++++++++++++++++++++++++++++++++++ include/linux/sched.h | 4 +++ 5 files changed, 67 insertions(+), 1 deletion(-) --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -80,6 +80,7 @@ struct sched_param { #include <linux/rcupd...
Nov 15, 2:22 pm 2007
Ulrich Drepper
[PATCHv2 4/4] first use of sys_indirect system call
This is a first user of sys_indirect. Several of the socket-related system calls which produce a file handle now can be passed an additional parameter to set the FD_CLOEXEC flag. socket.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) --- a/net/socket.c +++ b/net/socket.c @@ -344,11 +344,11 @@ static struct dentry_operations sockfs_dentry_operations = { * but we take care of internal coherence yet. */ -static int sock_alloc_fd(struct file **filep) +sta...
Nov 15, 2:22 pm 2007
Dan Aloni
[PATCH] x86_64: fix a deadlock in set_rtc_mmss()
Patch is valid only for 2.6.23.x, guessing from the recent arch/ changes in 2.6.24-rc. set_rtc_mmss() was used to be called from interrupt context in 2.6.22, however in 2.6.23, it is called from a timer context, where interrupts are enabled. This patch ensures that rtc_interrupt() won't dead-lock with set_rtc_mmss(). -- BUG: spinlock recursion on CPU#1, swapper/0 lock: ffffffff8063ffe0, .magic: dead4ead, .owner: swapper/0, .owner_cpu: 1 Call Trace: <IRQ> [<ffffffff80361297>]...
Nov 15, 12:55 pm 2007
Aristeu Rozanski
Re: [PATCH] x86_64: fix a deadlock in set_rtc_mmss()
I think it's a good idea to update or just remove the comment above. -- Aristeu -
Nov 15, 2:30 pm 2007
Ulrich Drepper
[PATCH 0/4] sys_indirect system call
The following patches provide an alternative implementation of the sys_indirect system call which has been discussed a few times. This no system call allows us to extend existing system call interfaces with adding more system calls. Davide's previous implementation is IMO far more complex than warranted. This code here is trivial, as you can see. I've discussed this approach with Linus last week and for a brief moment we actually agreed on something. We pass an additional block of data to the ...
Nov 15, 12:41 pm 2007
Zach Brown
Re: [PATCH 0/4] sys_indirect system call
I might quarrel with some details, but I really like the general notion. I think we can use this to pass per-syscall syslet data to the scheduler. Today the patches have submission syscalls which basically wrap some data for the scheduler around the syscall ABI. This might save the syslet patches from needing to know about each arch's ABI. We'll see. I'll give it a try. - z -
Nov 15, 6:19 pm 2007
Linus Torvalds
Re: [PATCH 0/4] sys_indirect system call
Yes, I mentioned this to Ulrich as one of the things that would make sense. Uli doesn't care that much about async syscalls, but I think that from a kernel standpoint, we'd want to use this same indirect call for async scheduling, rather than have two separate interfaces (because async scheduling will want to have all the same flags intefaces for open/socket/etc *too* and a doubly-indirect setup would be insanity!) And it definitely fits the bill as a really simple syslet model for the...
Nov 15, 6:33 pm 2007
Ulrich Drepper
Re: [PATCH 0/4] sys_indirect system call
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 At the moment I just care a lot more about getting the API straightened out. An asynchronous incomplete/unsafe API is still an incomplete/unsafe API. BTW, I've botched the x86-on-x86_64 support. I have a patch but need to patch it before I'll submit v3 of the patch set. If you want to work on the patch and get syslet support going, let me know, I'll send the latest version. - -- ➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Moun...
Nov 15, 7:30 pm 2007
Zach Brown
Re: [PATCH 0/4] sys_indirect system call
I probably won't come around to trying sys_indirect with syslets until next week, so it's probably fine for me to just wait for you to get v3 out. (and I'm more likely to test native i386 or x86_64 anyway, so.. :)) - z -
Nov 15, 7:40 pm 2007
Ulrich Drepper
[PATCH 3/4] x86&x86-64 UML support for sys_indirect
This part adds support for sys_indirect on UML on x86 and x86-64. b/arch/um/Makefile | 2 +- b/include/asm-um/indirect-i386.h | 6 ++++++ b/include/asm-um/indirect-x86_64.h | 10 ++++++++++ 3 files changed, 17 insertions(+), 1 deletion(-) --- a/arch/um/Makefile +++ b/arch/um/Makefile @@ -20,7 +20,7 @@ core-y += $(ARCH_DIR)/kernel/ \ # Have to precede the include because the included Makefiles reference them. SYMLINK_HEADERS := archparam.h system.h sigcontext...
Nov 15, 12:41 pm 2007
Ulrich Drepper
[PATCH 1/4] actual sys_indirect code
This is the actual architecture-independent part of the system call implementation. b/include/linux/indirect.h | 13 +++++++++++++ b/include/linux/syscalls.h | 3 +++ b/kernel/Makefile | 2 +- b/kernel/indirect.c | 25 +++++++++++++++++++++++++ b/include/linux/sched.h | 4 ++++ 5 files changed, 46 insertions(+), 1 deletion(-) --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -80,6 +80,7 @@ struct sched_param { #include <linux/rcupdate.h> #i...
Nov 15, 12:41 pm 2007
Ulrich Drepper
[PATCH 2/4] x86&x86-64 support for sys_indirect
This part adds support for sys_indirect on x86 and x86-64. b/arch/x86/ia32/ia32entry.S | 1 + b/arch/x86/kernel/syscall_table_32.S | 1 + b/include/asm-x86/indirect.h | 5 +++++ b/include/asm-x86/indirect_32.h | 27 +++++++++++++++++++++++++++ b/include/asm-x86/indirect_64.h | 30 ++++++++++++++++++++++++++++++ b/include/asm-x86/unistd_32.h | 3 ++- b/include/asm-x86/unistd_64.h | 2 ++ 7 files changed, 68 insertions(+), 1 deletion(-) ...
Nov 15, 12:41 pm 2007
Linus Torvalds
Re: [PATCH 2/4] x86&x86-64 support for sys_indirect
[ Ingo, Thomas - see the whole series on linux-kernel ] The thing is, not all system calls can do this. Some system calls are magic, and don't just take the arguments in registers: they also care about the actual stack pointer and the whole pt_regs struct when returning to user mode. So this does need more infrastructure: some way of marking which system calls cannot be executed indirectly. The magic system calls are things like: - sys_iopl() - this one changes the eflags value re...
Nov 15, 1:02 pm 2007
Ulrich Drepper
[PATCH 4/4] first use of sys_indirect system call
This is a first user of sys_indirect. Several of the socket-related system calls which produce a file handle now can be passed an additional parameter to set the FD_CLOEXEC flag. socket.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) --- a/net/socket.c +++ b/net/socket.c @@ -344,11 +344,11 @@ static struct dentry_operations sockfs_dentry_operations = { * but we take care of internal coherence yet. */ -static int sock_alloc_fd(struct file **filep) +s...
Nov 15, 12:41 pm 2007
Adrian Bunk
[2.6 patch] x86: revert X86_HT semantics change
The x86 unification resulted in CONFIG_X86_HT no longer being set if (X86_32 && MK8). After grep'ing through the tree I think the problem is that different places have different assumptions about the semantics of CONFIG_X86_HT, either: - hyperthreading or - multicore and the SCHED_SMT and SCHED_MC dependencies are just one of the symptoms. This should be sorted out properly, but until then we should keep the 2.6.23 status quo. Signed-off-by: Adrian Bunk <bunk@kernel.org> ...
Nov 15, 12:17 pm 2007
Sam Ravnborg
Re: [2.6 patch] x86: revert X86_HT semantics change
Yup - my bad. I wrongly assumed MK8 was an X86_64 thing. Acked-by: Sam Ravnborg <sam@ravnborg.org> I assume Thomas & Co will forward the patch. Sam -
Nov 15, 2:04 pm 2007
Thomas Gleixner
Re: [2.6 patch] x86: revert X86_HT semantics change
After looking what does what and fixing it. Right now this patch is not a 1:1 replacement of the .23 status quo, as it now makes SCHED_SMT and SCHED_HT depend on !MK8 for 64bit. tglx -
Nov 15, 2:07 pm 2007
Sam Ravnborg
Re: [2.6 patch] x86: revert X86_HT semantics change
I assumed this was intentional - Adrian? Sam -
Nov 15, 2:42 pm 2007
Adrian Bunk
Re: [2.6 patch] x86: revert X86_HT semantics change
cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -
Nov 15, 2:48 pm 2007
Adrian Bunk
[2.6 patch] x86: revert X86_HT semantics change
*searches brown paperbag* cu Adrian <-- snip --> The x86 unification resulted in CONFIG_X86_HT no longer being set if (X86_32 && MK8). After grep'ing through the tree I think the problem is that different places have different assumptions about the semantics of CONFIG_X86_HT, either - hyperthreading or - multicore This should be sorted out properly, but until then we should keep the 2.6.23 status quo. Signed-off-by: Adrian Bunk <bunk@kernel.org> --- ...
Nov 15, 2:19 pm 2007
Alexey Dobriyan
[PATCH] proc: remove useless check on symlink removal
proc symlinks always have valid ->data containing destination of symlink. No need to check it on removal -- proc_symlink() already done it. Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru> --- fs/proc/generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/proc/generic.c +++ b/fs/proc/generic.c @@ -704,7 +704,7 @@ void free_proc_entry(struct proc_dir_entry *de) release_inode_number(ino); - if (S_ISLNK(de->mode) && de->data) + if (S_ISLNK(d...
Nov 15, 12:14 pm 2007
Alexey Dobriyan
[PATCH] proc: prototypes redux
Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru> --- fs/proc/generic.c | 18 ++++++------------ fs/proc/proc_tty.c | 3 --- 2 files changed, 6 insertions(+), 15 deletions(-) --- a/fs/proc/generic.c +++ b/fs/proc/generic.c @@ -25,12 +25,6 @@ #include "internal.h" -static ssize_t proc_file_read(struct file *file, char __user *buf, - size_t nbytes, loff_t *ppos); -static ssize_t proc_file_write(struct file *file, const char __user *buffer, - size_t count, lo...
Nov 15, 12:13 pm 2007
previous daytodaynext day
November 14, 2007November 15, 2007November 16, 2007