Home » Mailing list archives » linux-kernel » 2007 » November » 15

[PATCH] proc: remove useless check on symlink removal

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Alexey Dobriyan <adobriyan@...>
To: <akpm@...>
Cc: <linux-kernel@...>, <devel@...>
Subject: [PATCH] proc: remove useless check on symlink removal
Date: Thursday, November 15, 2007 - 12:14 pm

proc symlinks always have valid ->data containing destination of symlink.
No need to check it on removal -- proc_symlink() already done it.

Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
---

 fs/proc/generic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -704,7 +704,7 @@ void free_proc_entry(struct proc_dir_entry *de)
 
 	release_inode_number(ino);
 
-	if (S_ISLNK(de->mode) && de->data)
+	if (S_ISLNK(de->mode))
 		kfree(de->data);
 	kfree(de);
 }

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] proc: remove useless check on symlink removal, Alexey Dobriyan, (Thu Nov 15, 12:14 pm)