Re: [bug] SLOB crash, 2.6.24-rc2

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <mingo@...>
Cc: <mpm@...>, <rjw@...>, <linux-kernel@...>, <akpm@...>, <torvalds@...>
Date: Thursday, November 15, 2007 - 6:51 am

From: Ingo Molnar <mingo@elte.hu>
Date: Thu, 15 Nov 2007 11:43:32 +0100


Yeah I wish udev would just leave the damn devices alone.

It even does things like try to rename a network device to the same
name it already has, and other strange stuff.

But that log difference is a good clue.

Because udev can try to rename a network device stupidly to a name the
device already has we added a patch to just short circuit this case in
the networking.  We did this because otherwise the generic device
layer gives an ugly stack backtrace via dev_rename().

Therefore, you might want to see if reverting that patch (attached
below) has some effect, once you are able to trigger it again.

Thanks Ingo.

commit c8d90dca3211966ba5189e0f3d4bccd558d9ae08
Author: Stephen Hemminger <shemminger@linux-foundation.org>
Date:   Fri Oct 26 03:53:42 2007 -0700

    [NET] dev_change_name: ignore changes to same name
    
    Prevent error/backtrace from dev_rename() when changing
    name of network device to the same name. This is a common
    situation with udev and other scripts that bind addr to device.
    
    Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/core/dev.c b/net/core/dev.c
index f1647d7..ddfef3b 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -883,6 +883,9 @@ int dev_change_name(struct net_device *dev, char *newname)
 	if (!dev_valid_name(newname))
 		return -EINVAL;
 
+	if (strncmp(newname, dev->name, IFNAMSIZ) == 0)
+		return 0;
+
 	memcpy(oldname, dev->name, IFNAMSIZ);
 
 	if (strchr(newname, '%')) {
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.24-rc2: Reported regressions from 2.6.23 (updated), Rafael J. Wysocki, (Sun Nov 11, 3:58 pm)
[bug] SLOB crash, 2.6.24-rc2, Ingo Molnar, (Wed Nov 14, 7:20 am)
Re: [bug] SLOB crash, 2.6.24-rc2, Matt Mackall, (Wed Nov 14, 1:36 pm)
Re: [bug] SLOB crash, 2.6.24-rc2, Matt Mackall, (Wed Nov 14, 2:39 pm)
Re: [bug] SLOB crash, 2.6.24-rc2, Ingo Molnar, (Wed Nov 14, 3:05 pm)
Re: [bug] SLOB crash, 2.6.24-rc2, David Miller, (Wed Nov 14, 6:39 pm)
Re: [bug] SLOB crash, 2.6.24-rc2, Matt Mackall, (Wed Nov 14, 6:53 pm)
Re: [bug] SLOB crash, 2.6.24-rc2, David Miller, (Wed Nov 14, 7:10 pm)
Re: [bug] SLOB crash, 2.6.24-rc2, Matt Mackall, (Wed Nov 14, 7:37 pm)
Re: [bug] SLOB crash, 2.6.24-rc2, David Miller, (Wed Nov 14, 7:41 pm)
Re: [bug] SLOB crash, 2.6.24-rc2, Ingo Molnar, (Thu Nov 15, 6:43 am)
Re: [bug] SLOB crash, 2.6.24-rc2, Nick Piggin, (Thu Nov 15, 6:57 am)
Re: [bug] SLOB crash, 2.6.24-rc2, Ingo Molnar, (Thu Nov 15, 7:28 am)
Re: [bug] SLOB crash, 2.6.24-rc2, Dave Haywood, (Thu Nov 15, 8:18 am)
Re: [bug] SLOB crash, 2.6.24-rc2, Nick Piggin, (Thu Nov 15, 7:39 am)
[patch] slob: fix memory corruption, Ingo Molnar, (Thu Nov 15, 7:32 am)
Re: [patch] slob: fix memory corruption, Matt Mackall, (Thu Nov 15, 12:00 pm)
Re: [patch] slob: fix memory corruption, Ingo Molnar, (Thu Nov 15, 8:48 am)
Re: [patch] slob: fix memory corruption, Nick Piggin, (Thu Nov 15, 4:25 pm)
Re: [bug] SLOB crash, 2.6.24-rc2, David Miller, (Thu Nov 15, 6:51 am)
Re: [bug] SLOB crash, 2.6.24-rc2, Ingo Molnar, (Thu Nov 15, 7:03 am)
Re: [bug] SLOB crash, 2.6.24-rc2, David Miller, (Thu Nov 15, 7:05 am)
Re: [bug] SLOB crash, 2.6.24-rc2, Matt Mackall, (Wed Nov 14, 8:09 pm)
Re: [bug] SLOB crash, 2.6.24-rc2, Matt Mackall, (Wed Nov 14, 3:42 pm)
Re: 2.6.24-rc2: Reported regressions from 2.6.23 (updated), Francois Romieu, (Sun Nov 11, 4:33 pm)
Re: 2.6.24-rc2: Reported regressions from 2.6.23 (updated), Bartlomiej Zolnierkiewicz..., (Sun Nov 11, 6:22 pm)
Re: 2.6.24-rc2: Reported regressions from 2.6.23 (updated), Thomas Lindroth, (Tue Nov 13, 10:09 am)
Re: 2.6.24-rc2: Reported regressions from 2.6.23 (updated), Rafael J. Wysocki, (Sun Nov 11, 4:34 pm)