From: Ingo Molnar <mingo@elte.hu> Date: Thu, 15 Nov 2007 11:43:32 +0100Yeah I wish udev would just leave the damn devices alone. It even does things like try to rename a network device to the same name it already has, and other strange stuff. But that log difference is a good clue. Because udev can try to rename a network device stupidly to a name the device already has we added a patch to just short circuit this case in the networking. We did this because otherwise the generic device layer gives an ugly stack backtrace via dev_rename(). Therefore, you might want to see if reverting that patch (attached below) has some effect, once you are able to trigger it again. Thanks Ingo. commit c8d90dca3211966ba5189e0f3d4bccd558d9ae08 Author: Stephen Hemminger <shemminger@linux-foundation.org> Date: Fri Oct 26 03:53:42 2007 -0700 [NET] dev_change_name: ignore changes to same name Prevent error/backtrace from dev_rename() when changing name of network device to the same name. This is a common situation with udev and other scripts that bind addr to device. Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org> Signed-off-by: David S. Miller <davem@davemloft.net> diff --git a/net/core/dev.c b/net/core/dev.c index f1647d7..ddfef3b 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -883,6 +883,9 @@ int dev_change_name(struct net_device *dev, char *newname) if (!dev_valid_name(newname)) return -EINVAL; + if (strncmp(newname, dev->name, IFNAMSIZ) == 0) + return 0; + memcpy(oldname, dev->name, IFNAMSIZ); if (strchr(newname, '%')) { -
| David Newall | Re: Slow DOWN, please!!! |
| Greg Kroah-Hartman | [PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO |
| Fernando Luis | [PATCH] affinity is not defined in non-smp kernels - x86_64 |
git: | |
| David Miller | [GIT]: Networking |
| Jarek Poplawski | Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| Gerrit Renker | [PATCH 28/37] dccp: Integration of dynamic feature activation - part 3 (client side) |
| Jean-Louis Dupond | tg3 driver not advertising 1000mbit |
