Home » Mailing list archives » linux-kernel » 2007 » November » 15

Re: [patch 16/19] x86 setup: handle boot loaders which set up the stack incorrectly

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: H. Peter Anvin <hpa@...>
To: Greg KH <gregkh@...>
Cc: Linux Kernel Mailing List <linux-kernel@...>
Subject: Re: [patch 16/19] x86 setup: handle boot loaders which set up the stack incorrectly
Date: Thursday, November 15, 2007 - 3:27 am

Greg KH wrote:

Just FYI:

It has been reported that while this patch fixes old LILO, and possibly 
some other boot loaders (unknown), it has also broken older versions of 
SYSLINUX: they still boot, but the command line is truncated (exactly 
how much depends on the BIOS, but typical values are around 130 bytes.)

This is definitely traceable to a bug in SYSLINUX that was already fixed 
in release 3.50 (the current version of SYSLINUX is 3.52).

I have chosen to leave the patch in mainline, rather than trying yet 
another recipe and hope it doesn't break on some other random 
combination of bootloaders, since:

a) SYSLINUX is generally easily updated, compared to other bootloaders;
b) The failure mode is less severe (it still boots.)

... however, you may choose to call differently.

	-hpa
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 00/19] 2.6.23-stable review, arch specific stuff, Greg KH, (Thu Nov 15, 2:14 am)
[patch 19/19] revert "x86_64: allocate sparsemem memmap abov..., Greg KH, (Thu Nov 15, 2:15 am)
[patch 18/19] x86: fix TSC clock source calibration error, Greg KH, (Thu Nov 15, 2:15 am)
[patch 17/19] x86 setup: sizeof() is unsigned, unbreak compa..., Greg KH, (Thu Nov 15, 2:15 am)
[patch 16/19] x86 setup: handle boot loaders which set up th..., Greg KH, (Thu Nov 15, 2:15 am)
Re: [patch 16/19] x86 setup: handle boot loaders which set u..., H. Peter Anvin, (Thu Nov 15, 3:27 am)
Re: [patch 16/19] x86 setup: handle boot loaders which set u..., Greg KH, (Thu Nov 15, 12:42 pm)
[patch 10/19] UML - kill subprocesses on exit, Greg KH, (Thu Nov 15, 2:14 am)
[patch 15/19] x86: fix global_flush_tlb() bug, Greg KH, (Thu Nov 15, 2:15 am)
[patch 11/19] xen: add batch completion callbacks, Greg KH, (Thu Nov 15, 2:14 am)
[patch 14/19] xfs: eagerly remove vmap mappings to avoid ups..., Greg KH, (Thu Nov 15, 2:15 am)
[patch 13/19] xen: fix incorrect vcpu_register_vcpu_info hyp..., Greg KH, (Thu Nov 15, 2:15 am)
[patch 12/19] xen: deal with stale cr3 values when unpinning..., Greg KH, (Thu Nov 15, 2:15 am)
[patch 09/19] UML - stop using libc asm/user.h, Greg KH, (Thu Nov 15, 2:14 am)
[patch 07/19] UML - Stop using libc asm/page.h, Greg KH, (Thu Nov 15, 2:14 am)
[patch 06/19] POWERPC: Make sure to of_node_get() the result..., Greg KH, (Thu Nov 15, 2:14 am)
[patch 04/19] MIPS: R1: Fix hazard barriers to make kernels ..., Greg KH, (Thu Nov 15, 2:14 am)
[patch 08/19] UML - Fix kernel vs libc symbols clash, Greg KH, (Thu Nov 15, 2:14 am)
[patch 05/19] POWERPC: Fix handling of stfiwx math emulation, Greg KH, (Thu Nov 15, 2:14 am)
[patch 02/19] Fix sparc64 MAP_FIXED handling of framebuffer ..., Greg KH, (Thu Nov 15, 2:14 am)
[patch 03/19] MIPS: MT: Fix bug in multithreaded kernels., Greg KH, (Thu Nov 15, 2:14 am)
[patch 01/19] Fix sparc64 niagara optimized RAID xor asm, Greg KH, (Thu Nov 15, 2:14 am)