Home » Mailing list archives » linux-kernel » 2007 » November » 15

[patch 08/23] softmac: fix wext MLME request reason code endianness

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Greg KH <gregkh@...>
To: <linux-kernel@...>, <stable@...>, John W. Linville <linville@...>
Cc: Justin Forbes <jmforbes@...>, Zwane Mwaikambo <zwane@...>, Theodore Ts'o <tytso@...>, Randy Dunlap <rdunlap@...>, Dave Jones <davej@...>, Chuck Wolber <chuckw@...>, Chris Wedgwood <reviews@...>, Michael Krufky <mkrufky@...>, Chuck Ebbert <cebbert@...>, Domenico Andreoli <cavokz@...>, <torvalds@...>, <akpm@...>, <alan@...>, linux-wireless <linux-wireless@...>, Johannes Berg <johannes@...>
Subject: [patch 08/23] softmac: fix wext MLME request reason code endianness
Date: Thursday, November 15, 2007 - 2:20 am

-stable review patch.  If anyone has any objections, please let us know.

------------------

From: Johannes Berg <johannes@sipsolutions.net>

patch 94e10bfb8a7372df3ef2759c9ec2a37de2f24aca in mainline.

The MLME request reason code is host-endian and our passing
it to the low level functions is host-endian as well since
they do the swapping. I noticed that the reason code 768 was
sent (0x300) rather than 3 when wpa_supplicant terminates.
This removes the superfluous cpu_to_le16() call.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 net/ieee80211/softmac/ieee80211softmac_wx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/ieee80211/softmac/ieee80211softmac_wx.c
+++ b/net/ieee80211/softmac/ieee80211softmac_wx.c
@@ -469,7 +469,7 @@ ieee80211softmac_wx_set_mlme(struct net_
 {
 	struct ieee80211softmac_device *mac = ieee80211_priv(dev);
 	struct iw_mlme *mlme = (struct iw_mlme *)extra;
-	u16 reason = cpu_to_le16(mlme->reason_code);
+	u16 reason = mlme->reason_code;
 	struct ieee80211softmac_network *net;
 	int err = -EINVAL;
 

-- 
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 00/23] 2.6.23-stable review, network changes, Greg KH, (Thu Nov 15, 2:18 am)
[patch 22/23] mac80211: only honor IW_SCAN_THIS_ESSID in STA..., Greg KH, (Thu Nov 15, 2:21 am)
[patch 23/23] mac80211: make ieee802_11_parse_elems return v..., Greg KH, (Thu Nov 15, 2:21 am)
[patch 20/23] mac80211: store SSID in sta_bss_list, Greg KH, (Thu Nov 15, 2:21 am)
[patch 19/23] mac80211: store channel info in sta_bss_list, Greg KH, (Thu Nov 15, 2:21 am)
[patch 21/23] mac80211: honor IW_SCAN_THIS_ESSID in siwscan ..., Greg KH, (Thu Nov 15, 2:21 am)
[patch 16/23] NETFILTER: nf_conntrack_tcp: fix connection re..., Greg KH, (Thu Nov 15, 2:20 am)
[patch 17/23] ieee80211: fix TKIP QoS bug, Greg KH, (Thu Nov 15, 2:20 am)
[patch 18/23] mac80211: reorder association debug output, Greg KH, (Thu Nov 15, 2:21 am)
[patch 15/23] Fix netlink timeouts., Greg KH, (Thu Nov 15, 2:20 am)
[patch 14/23] Fix crypto_alloc_comp() error checking., Greg KH, (Thu Nov 15, 2:20 am)
[patch 08/23] softmac: fix wext MLME request reason code end..., Greg KH, (Thu Nov 15, 2:20 am)
[patch 13/23] Fix SET_VLAN_INGRESS_PRIORITY_CMD error return., Greg KH, (Thu Nov 15, 2:20 am)
[patch 11/23] Fix endianness bug in U32 classifier., Greg KH, (Thu Nov 15, 2:20 am)
[patch 12/23] Fix VLAN address syncing., Greg KH, (Thu Nov 15, 2:20 am)
[patch 10/23] Fix TEQL oops., Greg KH, (Thu Nov 15, 2:20 am)
[patch 09/23] Fix error returns in sys_socketpair(), Greg KH, (Thu Nov 15, 2:20 am)
[patch 07/23] Fix kernel_accept() return handling., Greg KH, (Thu Nov 15, 2:20 am)
[patch 05/23] Fix 9P protocol build, Greg KH, (Thu Nov 15, 2:20 am)
[patch 06/23] Fix SKB_WITH_OVERHEAD calculations., Greg KH, (Thu Nov 15, 2:20 am)
Re: [patch 06/23] Fix SKB_WITH_OVERHEAD calculations., Herbert Xu, (Thu Nov 15, 2:29 am)
Re: [patch 06/23] Fix SKB_WITH_OVERHEAD calculations., David Miller, (Thu Nov 15, 3:00 am)
Re: [patch 06/23] Fix SKB_WITH_OVERHEAD calculations., Herbert Xu, (Thu Nov 15, 3:31 am)
Re: [stable] [patch 06/23] Fix SKB_WITH_OVERHEAD calculations., Greg KH, (Thu Nov 15, 8:31 pm)
Re: [stable] [patch 06/23] Fix SKB_WITH_OVERHEAD calculations., David Miller, (Thu Nov 15, 10:42 pm)
[patch 04/23] Fix advertised packet scheduler timer resolution, Greg KH, (Thu Nov 15, 2:20 am)
[patch 03/23] Add get_unaligned to ieee80211_get_radiotap_len, Greg KH, (Thu Nov 15, 2:20 am)
[patch 02/23] mac80211: Improve sanity checks on injected pa..., Greg KH, (Thu Nov 15, 2:20 am)
[patch 01/23] mac80211: filter locally-originated multicast ..., Greg KH, (Thu Nov 15, 2:20 am)