Re: [RFC][PATCH] Freezer: Make freezing failures less verbose by default

Previous thread: [PATCH] time: fix typo that makes sync_cmos_clock erratic by David P. Reed on Wednesday, November 14, 2007 - 6:49 pm. (1 message)

Next thread: Repeated oopses with inode == 0xffffffff in 2.6.23 by Chuck Ebbert on Wednesday, November 14, 2007 - 7:51 pm. (2 messages)
To: pm list <linux-pm@...>
Cc: Arkadiusz Miskiewicz <arekm@...>, Pavel Machek <pavel@...>, LKML <linux-kernel@...>
Date: Wednesday, November 14, 2007 - 7:38 pm

From: Rafael J. Wysocki <rjw@sisk.pl>

Currently freezing failures are extremely verbose which sometimes is
unnecessary and prevents the user from seeing which task could not be frozen.

Make them less verbose by default (ie. if CONFIG_PM_VERBOSE is unset).

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
kernel/power/process.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)

Index: linux-2.6/kernel/power/process.c
===================================================================
--- linux-2.6.orig/kernel/power/process.c
+++ linux-2.6/kernel/power/process.c
@@ -163,6 +163,15 @@ static void cancel_freezing(struct task_
}
}

+#ifdef CONFIG_PM_VERBOSE
+static inline void freezer_show_state(void)
+{
+ show_state();
+}
+#else /* !CONFIG_PM_VERBOSE */
+static inline void freezer_show_state(void) {}
+#endif /* !CONFIG_PM_VERBOSE */
+
static int try_to_freeze_tasks(int freeze_user_space)
{
struct task_struct *g, *p;
@@ -214,7 +223,7 @@ static int try_to_freeze_tasks(int freez
printk(KERN_ERR "Freezing of tasks failed after %d.%02d seconds "
"(%d tasks refusing to freeze):\n",
elapsed_csecs / 100, elapsed_csecs % 100, todo);
- show_state();
+ freezer_show_state();
read_lock(&tasklist_lock);
do_each_thread(g, p) {
task_lock(p);
-

To: Rafael J. Wysocki <rjw@...>
Cc: pm list <linux-pm@...>, Arkadiusz Miskiewicz <arekm@...>, LKML <linux-kernel@...>
Date: Wednesday, November 14, 2007 - 8:25 pm

I don't think compile time option is right thing to do.

Dump just the stacks of the non-frozen tasks?

acpi_sleep=verbose?

Reorder dmesg so that you get backtraces, and _then_ list of the
tasks?

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-

To: Pavel Machek <pavel@...>
Cc: Rafael J. Wysocki <rjw@...>, pm list <linux-pm@...>, Arkadiusz Miskiewicz <arekm@...>, LKML <linux-kernel@...>
Date: Thursday, November 15, 2007 - 1:06 pm

rozen.

That'd be good too.

johannes

Previous thread: [PATCH] time: fix typo that makes sync_cmos_clock erratic by David P. Reed on Wednesday, November 14, 2007 - 6:49 pm. (1 message)

Next thread: Repeated oopses with inode == 0xffffffff in 2.6.23 by Chuck Ebbert on Wednesday, November 14, 2007 - 7:51 pm. (2 messages)