Re: [PATCH 0/5][RFC] Physical PCI slot objects

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Kenji Kaneshige
Date: Wednesday, November 14, 2007 - 4:43 am

Hi,

I tried the series of patches and I encountered some problems.
Since I don't have enough time to investigate them, I can only
report them at present. My environment was ia64 machine with 64
hotplug slots (shpc & pcie). Those slots can be handled by
acpiphp too, though I have not tried it yet.

- Problem(1)
  Two kind of Call Traces were displayed so many times at the
  boot time. Those are attached below. I guess it relate to
  the ACPI Namespace definition.

- Problem(2)
  Many of the shpc slot initializations failed with the
  following error messages. I guess the cause is Problem(1).

  shpchp: pci_hp_register failed with error -17
  shpchp: shpchp: slot initialization failed

- Problem(3)
  All of the pcie slot initializations failed with the
  following error messages. I guess the cause is Problem(1).

  pciehp: pci_hp_register failed with error -17
  pciehp: pciehp: slot initialization failed

BTW, I have some comments about the patches.

- I think your patches assume that all the hotplug slots have
  ACPI _SUN method regardless of the hotplug controller type,
  because pci_slot.c is the only place to call pci_slot_create().
  But I think there are hotplug slots without _SUN. If the
  hotplug slot doesn't have _SUN, slot initialization by the
  hotplug controller driver doesn't work (does it?), because
  there are no slot directory.

- I think pci_slot.o should be kernel module so that users can
  select to enable or disable this functionality.

Here is the Call Trace mentioned above:

Unable to register kobject 1024<3>pci_slot: pci_create_slot returned -22
ACPI: Invalid ACPI Bus context for device <NULL>
sysfs: duplicate filename '1024' can not be created
WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()

Call Trace:
 [<a000000100014b60>] show_stack+0x40/0xa0
                                sp=e000014101befaf0 bsp=e000014101be0f60
 [<a000000100014bf0>] dump_stack+0x30/0x60
                                sp=e000014101befcc0 bsp=e000014101be0f48
 [<a0000001001d6990>] sysfs_add_one+0xb0/0x240
                                sp=e000014101befcc0 bsp=e000014101be0f18
 [<a0000001001d7900>] create_dir+0x80/0x100
                                sp=e000014101befcc0 bsp=e000014101be0ee0
 [<a0000001001d7a30>] sysfs_create_dir+0xb0/0x100
                                sp=e000014101befce0 bsp=e000014101be0ec0
 [<a0000001003b4f50>] kobject_add+0x250/0x460
                                sp=e000014101befcf0 bsp=e000014101be0e80
 [<a0000001003b52d0>] kobject_register+0x50/0xa0
                                sp=e000014101befcf0 bsp=e000014101be0e58
 [<a0000001003d6f40>] pci_create_slot+0x140/0x260
                                sp=e000014101befcf0 bsp=e000014101be0e10
 [<a00000010043acd0>] register_slot+0x170/0x1c0
                                sp=e000014101befcf0 bsp=e000014101be0dc0
 [<a000000100419ef0>] acpi_ns_walk_namespace+0x2b0/0x300
                                sp=e000014101befd20 bsp=e000014101be0d50
 [<a000000100415a50>] acpi_walk_namespace+0x90/0xc0
                                sp=e000014101befd20 bsp=e000014101be0d00
 [<a00000010043ab20>] acpi_pci_slot_add+0x1c0/0x200
                                sp=e000014101befd20 bsp=e000014101be0cd8
 [<a0000001004367e0>] acpi_pci_register_driver+0xe0/0x160
                                sp=e000014101befd30 bsp=e000014101be0ca8
 [<a000000100920620>] acpi_pci_slot_init+0x20/0x40
                                sp=e000014101befd30 bsp=e000014101be0c90
 [<a0000001008f06e0>] kernel_init+0x460/0x7e0
                                sp=e000014101befd30 bsp=e000014101be0c48
 [<a000000100013110>] kernel_thread_helper+0x30/0x60
                                sp=e000014101befe30 bsp=e000014101be0c20
 [<a0000001000089c0>] start_kernel_thread+0x20/0x40
                                sp=e000014101befe30 bsp=e000014101be0c20
kobject_add failed for 1024 with -EEXIST, don't try to register things with the
same name in the same directory.

Call Trace:
 [<a000000100014b60>] show_stack+0x40/0xa0
                                sp=e000014101befb20 bsp=e000014101be0ed8
 [<a000000100014bf0>] dump_stack+0x30/0x60
                                sp=e000014101befcf0 bsp=e000014101be0ec0
 [<a0000001003b50e0>] kobject_add+0x3e0/0x460
                                sp=e000014101befcf0 bsp=e000014101be0e80
 [<a0000001003b52d0>] kobject_register+0x50/0xa0
                                sp=e000014101befcf0 bsp=e000014101be0e58
 [<a0000001003d6f40>] pci_create_slot+0x140/0x260
                                sp=e000014101befcf0 bsp=e000014101be0e10
 [<a00000010043acd0>] register_slot+0x170/0x1c0
                                sp=e000014101befcf0 bsp=e000014101be0dc0
 [<a000000100419ef0>] acpi_ns_walk_namespace+0x2b0/0x300
                                sp=e000014101befd20 bsp=e000014101be0d50
 [<a000000100415a50>] acpi_walk_namespace+0x90/0xc0
                                sp=e000014101befd20 bsp=e000014101be0d00
 [<a00000010043ab20>] acpi_pci_slot_add+0x1c0/0x200
                                sp=e000014101befd20 bsp=e000014101be0cd8
 [<a0000001004367e0>] acpi_pci_register_driver+0xe0/0x160
                                sp=e000014101befd30 bsp=e000014101be0ca8
 [<a000000100920620>] acpi_pci_slot_init+0x20/0x40
                                sp=e000014101befd30 bsp=e000014101be0c90
 [<a0000001008f06e0>] kernel_init+0x460/0x7e0
                                sp=e000014101befd30 bsp=e000014101be0c48
 [<a000000100013110>] kernel_thread_helper+0x30/0x60
                                sp=e000014101befe30 bsp=e000014101be0c20
 [<a0000001000089c0>] start_kernel_thread+0x20/0x40
                                sp=e000014101befe30 bsp=e000014101be0c20
Unable to register kobject 1024<3>pci_slot: pci_create_slot returned -22


Thanks,
Kenji Kaneshige


Alex Chiang ????????:


-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/5][RFC] Physical PCI slot objects, Alex Chiang, (Mon Nov 12, 5:08 pm)
[PATCH 1/5] Remove path attribute from sgi_hotplug, Alex Chiang, (Mon Nov 12, 5:12 pm)
[PATCH 2/5] Construct one fakephp slot per pci slot, Alex Chiang, (Mon Nov 12, 5:13 pm)
[PATCH 3/5, RFC] Introduce pci_slot, Alex Chiang, (Mon Nov 12, 5:14 pm)
[PATCH 4/5, RFC] ACPI PCI slot detection driver, Alex Chiang, (Mon Nov 12, 5:17 pm)
[PATCH 5/5] Add pci_slot_add_hotplug() interface, Alex Chiang, (Mon Nov 12, 5:18 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Greg KH, (Tue Nov 13, 10:01 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Matthew Wilcox, (Tue Nov 13, 11:33 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Greg KH, (Tue Nov 13, 11:51 am)
Re: [PATCH 2/5] Construct one fakephp slot per pci slot, Linas Vepstas, (Tue Nov 13, 12:48 pm)
Re: [PATCH 2/5] Construct one fakephp slot per pci slot, Matthew Wilcox, (Tue Nov 13, 12:52 pm)
Re: [PATCH 3/5, RFC] Introduce pci_slot, Linas Vepstas, (Tue Nov 13, 12:56 pm)
Re: [PATCH 3/5, RFC] Introduce pci_slot, Matthew Wilcox, (Tue Nov 13, 1:03 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Matthew Wilcox, (Tue Nov 13, 1:11 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Greg KH, (Tue Nov 13, 1:19 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Alex Chiang, (Tue Nov 13, 1:21 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Linas Vepstas, (Tue Nov 13, 1:24 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Greg KH, (Tue Nov 13, 1:26 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Alex Chiang, (Tue Nov 13, 1:36 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Alex Chiang, (Tue Nov 13, 1:59 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Matt Domsch, (Tue Nov 13, 2:15 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Greg KH, (Tue Nov 13, 2:30 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Alex Chiang, (Tue Nov 13, 2:31 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Greg KH, (Tue Nov 13, 2:32 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Greg KH, (Tue Nov 13, 2:36 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Linas Vepstas, (Tue Nov 13, 2:41 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Matthew Wilcox, (Tue Nov 13, 2:58 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Bjorn Helgaas, (Tue Nov 13, 3:01 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Greg KH, (Tue Nov 13, 3:16 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Rick Jones, (Tue Nov 13, 3:51 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Greg KH, (Tue Nov 13, 3:56 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Kristen Carlson Accardi, (Tue Nov 13, 3:59 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Matthew Wilcox, (Tue Nov 13, 4:04 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Greg KH, (Tue Nov 13, 4:07 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Gary Hade, (Tue Nov 13, 4:08 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Alex Chiang, (Tue Nov 13, 4:14 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Kristen Carlson Accardi, (Tue Nov 13, 4:33 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Matthew Wilcox, (Tue Nov 13, 5:10 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Andi Kleen, (Tue Nov 13, 6:07 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Alex Chiang, (Tue Nov 13, 6:37 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Scott Murray, (Tue Nov 13, 11:00 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Kenji Kaneshige, (Wed Nov 14, 2:55 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Kenji Kaneshige, (Wed Nov 14, 4:43 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Matthew Wilcox, (Wed Nov 14, 7:17 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Andi Kleen, (Wed Nov 14, 7:35 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Alex Chiang, (Wed Nov 14, 7:42 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Matthew Wilcox, (Wed Nov 14, 8:00 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Andi Kleen, (Wed Nov 14, 8:08 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Matthew Wilcox, (Wed Nov 14, 8:12 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Alex Chiang, (Wed Nov 14, 8:20 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Bjorn Helgaas, (Wed Nov 14, 10:37 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Matthew Garrett, (Wed Nov 14, 10:44 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Greg KH, (Wed Nov 14, 10:51 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Greg KH, (Wed Nov 14, 10:53 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Matthew Garrett, (Wed Nov 14, 11:03 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Gary Hade, (Wed Nov 14, 11:13 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Alex Chiang, (Wed Nov 14, 11:36 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Kristen Carlson Accardi, (Wed Nov 14, 11:38 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Alex Chiang, (Wed Nov 14, 12:53 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Alex Chiang, (Wed Nov 14, 2:24 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Alex Chiang, (Wed Nov 14, 2:42 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Gary Hade, (Wed Nov 14, 5:40 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Alex Chiang, (Thu Nov 15, 10:36 am)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Alex Chiang, (Thu Nov 15, 1:20 pm)
Re: [PATCH 0/5][RFC] Physical PCI slot objects, Gary Hade, (Thu Nov 15, 4:38 pm)