login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
November
»
14
Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of moduleparam.h
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Julia Lawall <julia@...>
To: Robert P. J. Day <rpjday@...>
Cc: <khali@...>, <i2c@...>, <linux-kernel@...>, <kernel-janitors@...>
Subject:
Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of moduleparam.h
Date: Wednesday, November 14, 2007 - 2:09 am
>> From: Julia Lawall <julia@diku.dk>
quoted text
>> >> Drop #include <linux/moduleparam.h> in files that also include #include >> <linux/module.h>. module.h includes moduleparam.h already. > > i'm not convinced that's a good idea. while module.h does currently > (and unfortunately) include moduleparam.h, there may come a day when > those header files are refactored to actually make sense, at which > point all those missing moduleparam.h inclusions will cause all sorts > of bad things to happen.
They were removed from the drivers/media files in August: 9c12224a607a4b22ab86784e3394b52810b9507c Perhaps they should be put back there then? julia -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 1/4] drivers/i2c: Drop redundant includes of modulepa...
, Julia Lawall
, (Tue Nov 13, 5:32 pm)
Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of modu...
, Robert P. J. Day
, (Tue Nov 13, 5:34 pm)
Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of modu...
, Julia Lawall
, (Wed Nov 14, 2:09 am)
Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of modu...
, Robert P. J. Day
, (Wed Nov 14, 5:21 am)
Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of mod...
, Jean Delvare
, (Thu Nov 15, 8:19 am)
Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of mod...
, Robert P. J. Day
, (Thu Nov 15, 8:42 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Davide Libenzi
[patch 7/8] fdmap v2 - implement sys_socket2
Greg Kroah-Hartman
[PATCH 018/196] coda: convert struct class_device to struct device
Bart Van Assche
Integration of SCST in the mainstream Linux kernel
David Newall
Re: Slow DOWN, please!!!
git
:
linux-netdev
:
Christoph Lameter
Network latency regressions from 2.6.22 to 2.6.29
David Miller
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Arjan van de Ven
Re: [GIT]: Networking
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
1 user
and
667 guests
online.
Online users
Jeremy
Syndicate