login
Search
The mm snapshot broken-out-2007-11-13-04-14.tar.gz has been uploaded to ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-11-13-04-14.tar.gz It contains the following patches against ...
Hi Andrew,
The build fails, with the build error
drivers/pci/hotplug/rpadlpar_sysfs.c:28: warning: ˜struct kobjet declared inside parameter list
drivers/pci/hotplug/rpadlpar_sysfs.c:28: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/pci/hotplug/rpadlpar_sysfs.c:59: warning: ˜struct kobjet declared inside parameter list
drivers/pci/hotplug/rpadlpar_sysfs.c: In function ˜remove_slot_store:
drivers/pci/hotplug/rpadlpar_sysfs.c:79: error: expected ˜; before ˜return
drivers/pci/hotplug/rpadlpar_sysfs.c: At top level:
drivers/pci/hotplug/rpadlpar_sysfs.c:89: warning: initialization from incompatible pointer type
drivers/pci/hotplug/rpadlpar_sysfs.c:92: warning: initialization from incompatible pointer type
drivers/pci/hotplug/rpadlpar_sysfs.c: In function ˜remove_slot_store:
drivers/pci/hotplug/rpadlpar_sysfs.c:80: warning: control reaches end of
non-void function
make[3]: *** [drivers/pci/hotplug/rpadlpar_sysfs.o] Error 1
make[2]: *** [drivers/pci/hotplug] Error 2
make[1]: *** [drivers/pci] Error 2
make: *** [drivers] Error 2
This is caused by the patch gregkh-driver-kobject-clean-up-rpadlpar-horrid-sysfs-abuse.patch.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
--- drivers/pci/hotplug/rpadlpar_sysfs.c 2007-11-13 19:42:26.000000000 +0530
+++ drivers/pci/hotplug/~rpadlpar_sysfs.c 2007-11-13 20:29:09.000000000 +0530
@@ -54,7 +54,7 @@ static ssize_t add_slot_show(struct kobj
return sprintf(buf, "0\n");
}
-static ssize_t remove_slot_store(struct kobjet *kobj,
+static ssize_t remove_slot_store(struct kobject *kobj,
struct kobj_attribute *attr,
const char *buf, size_t nbytes)
{
@@ -74,7 +74,7 @@ static ssize_t remove_slot_store(struct
rc = dlpar_remove_slot(drc_name);
if (rc)
- return rc
+ return rc;
return nbytes;
}
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
Hi Andrew,
The build fails, with the build error
drivers/pci/hotplug/rpadlpar_sysfs.c:28: warning: ˜struct kobjet declared inside parameter list
drivers/pci/hotplug/rpadlpar_sysfs.c:28: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/pci/hotplug/rpadlpar_sysfs.c:59: warning: ˜struct kobjet declared inside parameter list
drivers/pci/hotplug/rpadlpar_sysfs.c: In function ˜remove_slot_store:
drivers/pci/hotplug/rpadlpar_sysfs.c:79: error: expected ˜; before ˜return
drivers/pci/hotplug/rpadlpar_sysfs.c: At top level:
drivers/pci/hotplug/rpadlpar_sysfs.c:89: warning: initialization from incompatible pointer type
drivers/pci/hotplug/rpadlpar_sysfs.c:92: warning: initialization from incompatible pointer type
drivers/pci/hotplug/rpadlpar_sysfs.c: In function ˜remove_slot_store:
drivers/pci/hotplug/rpadlpar_sysfs.c:80: warning: control reaches end of non-void function
make[3]: *** [drivers/pci/hotplug/rpadlpar_sysfs.o] Error 1
make[2]: *** [drivers/pci/hotplug] Error 2
make[1]: *** [drivers/pci] Error 2
make: *** [drivers] Error 2
This is caused by the patch
gregkh-driver-kobject-clean-up-rpadlpar-horrid-sysfs-abuse.patch.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
--- linux-2.6.24-rc2/drivers/pci/hotplug/rpadlpar_sysfs.c 2007-11-13 19:42:26.000000000 +0530
+++ linux-2.6.24-rc2/drivers/pci/hotplug/~rpadlpar_sysfs.c 2007-11-13 20:29:09.000000000 +0530
@@ -54,7 +54,7 @@ static ssize_t add_slot_show(struct kobj
return sprintf(buf, "0\n");
}
-static ssize_t remove_slot_store(struct kobjet *kobj,
+static ssize_t remove_slot_store(struct kobject *kobj,
struct kobj_attribute *attr,
const char *buf, size_t nbytes)
{
@@ -74,7 +74,7 @@ static ssize_t remove_slot_store(struct
rc = dlpar_remove_slot(drc_name);
if (rc)
- return rc
+ return rc;
return nbytes;
}
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
<snip> How exactly do I go about trying out this snapshot? I did the following: - exported 2.6.24-rc2 from my cloned git tree to a separate folder - installed quilt - extracted the patches to the "patches" directory at the top level of the 2.6.24-rc2 tree - copied the list of patches from your mail into a "series" file which I placed in the "patches" directory - ran "quilt push -a" The result was that all of the patches seem to have been applied, but there were many offsets and at least one fuzzed patch. Should they have applied cleanly? Is quilt the way I am supposed to be applying these patches? Is there a reason that there is no "series" file in the archive with the patches? Slightly confused, -- Kevin Winchester -
The tarball contains a copy of the series file. For some reason LARGE Yes, the -mm patches contain large amount of fuzz. I'll occasionally go in and do a mass defuzzing (shaving?) but it all goes fuzzy again within a day. I _could_ rediff all the time, but I keep all the patches under revision control and I often need to grab the previous version of a patch (when I've just dropped an earlier patch, and that earlier patch had caused me to redo this patch). Having lots of revisions due to unnecessary rediffing would It's in there ;) btw, I put the patches in a directory called "broken-out" so that you can untar them in your kernel tree and not have them stomped all over your existing patches/ directory. symlink it... -
It's not at the same directory level as the patches. For some reason, that would help me find it. --- ~Randy -
$ uname -a Linux bellona 2.6.23-rc8-mm2_64 #58 SMP Fri Sep 28 08:52:12 CEST 2007 x86_64 x86_64 x86_64 GNU/Linux $ make O=../bu cscope FILELST cscope.files find: /home/l/latest/xxx/arch/x86_64: není souborem ani adresářem MAKE cscope.out regards, -- Jiri Slaby (jirislaby@gmail.com) Faculty of Informatics, Masaryk University -
I have following fix queued in my inbox: This patch fixed the following errors when doing "make cscope" and "make cscope ARCH=um". FILELST cscope.files find: arch/i386: No such file or directory MAKE cscope.out FILELST cscope.files find: include/asm-i386: No such file or directory MAKE cscope.out Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com> Cc: Sam Ravnborg <sam@ravnborg.org> --- diff --git a/Makefile b/Makefile index e28dde8..01335ca 100644 --- a/Makefile +++ b/Makefile @@ -1322,6 +1322,7 @@ ALLINCLUDE_ARCHS := $(ARCH) $(SUBARCH) else ALLINCLUDE_ARCHS := $(SRCARCH) endif +ALLINCLUDE_ARCHS := $(shell echo $(ALLINCLUDE_ARCHS)|sed -e "s/i386/x86/" -e "s/x86_64/x86/") else #Allow user to specify only ALLSOURCE_PATHS on the command line, keeping existing behavour. ALLINCLUDE_ARCHS := $(ALLSOURCE_ARCHS) @@ -1331,7 +1332,7 @@ endif ifeq ($(ARCH), $(SRCARCH)) ALLSOURCE_ARCHS := $(ARCH) else -ALLSOURCE_ARCHS := $(ARCH) $(SRCARCH) +ALLSOURCE_ARCHS := $(shell echo $(ARCH) $(SRCARCH)|sed -e "s/i386/x86/" -e "s/x86_64/x86/") endif define find-sources -
Ok, thanks, -- Jiri Slaby (jirislaby@gmail.com) Faculty of Informatics, Masaryk University -
ERROR: "nfs_put_super" [fs/nfs/nfs.ko] undefined! ERROR: "nfs_sb_deactive" [fs/nfs/nfs.ko] undefined! make[2]: *** [__modpost] Error 1 make[1]: *** [modules] Error 2 config: http://www.fi.muni.cz/~xslaby/sklad/config_64 regards, -- Jiri Slaby (jirislaby@gmail.com) Faculty of Informatics, Masaryk University -
<queues nfs-stop-sillyname-renames-and-unmounts-from-racing-fix-fix-fix.patch> Thanks. -
Hi Andrew, The kernel build fails, with following build error mm/memory.c: In function ‘free_pte_range’: mm/memory.c:126: error: implicit declaration of function ‘pmd_pgtable’ mm/memory.c:126: warning: initialization makes pointer from integer without a cast mm/memory.c: In function ‘apply_to_pte_range’: mm/memory.c:1389: warning: assignment makes pointer from integer without a cast make[1]: *** [mm/memory.o] Error 1 make: *** [mm] Error 2 The patch causing this issue is config_highpte-vs-sub-page-page-tables.patch. Where the marco is defined #ifndef CONFIG_PPC_64K_PAGES. -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. -
Hmm, the default config for ppc compiled. Can you send me the .config for the failed compile? I'll fix it up. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -
Forget the request for the .config. Found the problem, fixup patch below. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. --- diff -urpN linux-2.6/include/asm-powerpc/pgalloc-64.h linux-2.6-patched/include/asm-powerpc/pgalloc-64.h --- linux-2.6/include/asm-powerpc/pgalloc-64.h 2007-11-12 17:31:58.000000000 +0100 +++ linux-2.6-patched/include/asm-powerpc/pgalloc-64.h 2007-11-13 16:23:50.000000000 +0100 @@ -68,6 +68,7 @@ static inline void pmd_populate_kernel(s #define pmd_populate(mm, pmd, pte_page) \ pmd_populate_kernel(mm, pmd, page_address(pte_page)) +#define pmd_pgtable(pmd) pmd_page(pmd) #endif /* CONFIG_PPC_64K_PAGES */ -
Hi Andrew, The kernel build fails, with the following error LD init/built-in.o LD .tmp_vmlinux1 fs/built-in.o(.text+0x5d632): In function `nfs_free_unlinkdata': fs/nfs/unlink.c:32: undefined reference to `nfs_sb_deactive' fs/built-in.o(.rodata+0x5c5c): In function `do_execve': fs/exec.c:1355: undefined reference to `nfs_put_super' make: *** [.tmp_vmlinux1] Error 1 I suspect nfs-stop-sillyname-renames-and-unmounts-from-racing.patch, is causing the problem. The definition of the function is between CONFIG_NFS_V4 in fs/nfs/super.c. During the compilation # CONFIG_NFS_V4 is not set. -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. # # Automatically generated make config: don't edit # Linux kernel version: 2.6.24-rc2-mm1-autokern1 # Tue Nov 13 06:26:42 2007 # CONFIG_X86_64=y CONFIG_64BIT=y CONFIG_X86=y CONFIG_GENERIC_TIME=y CONFIG_GENERIC_TIME_VSYSCALL=y CONFIG_GENERIC_CMOS_UPDATE=y CONFIG_CLOCKSOURCE_WATCHDOG=y CONFIG_GENERIC_CLOCKEVENTS=y CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y CONFIG_ZONE_DMA32=y CONFIG_LOCKDEP_SUPPORT=y CONFIG_STACKTRACE_SUPPORT=y CONFIG_SEMAPHORE_SLEEPERS=y CONFIG_MMU=y CONFIG_ZONE_DMA=y CONFIG_RWSEM_GENERIC_SPINLOCK=y CONFIG_GENERIC_HWEIGHT=y CONFIG_GENERIC_CALIBRATE_DELAY=y CONFIG_X86_CMPXCHG=y CONFIG_FAST_CMPXCHG_LOCAL=y CONFIG_GENERIC_ISA_DMA=y CONFIG_GENERIC_IOMAP=y CONFIG_ARCH_MAY_HAVE_PC_FDC=y CONFIG_ARCH_POPULATES_NODE_MAP=y CONFIG_DMI=y CONFIG_AUDIT_ARCH=y CONFIG_GENERIC_BUG=y # CONFIG_ARCH_HAS_ILOG2_U32 is not set # CONFIG_ARCH_HAS_ILOG2_U64 is not set CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config" # # General setup # CONFIG_EXPERIMENTAL=y CONFIG_LOCK_KERNEL=y CONFIG_INIT_ENV_ARG_LIMIT=32 CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y CONFIG_SWAP=y CONFIG_SYSVIPC=y CONFIG_SYSVIPC_SYSCTL=y # CONFIG_POSIX_MQUEUE is not set # CONFIG_BSD_PROCESS_ACCT is not set # CONFIG_TASKSTATS is not set # CONFIG_USER_NS is not set # CONFIG_PID_NS is not set # ...
Reported and hopefully fixed. Patch is here: http://lkml.org/lkml/2007/11/13/211 --- ~Randy -
| Greg KH | Og dreams of kernels |
| Jens Axboe | [PATCH 31/33] Fusion: sg chaining support |
| Arnd Bergmann | Re: finding your own dead "CONFIG_" variables |
| Mark Brown | [PATCH 2/2] Subject: natsemi: Allow users to disable workaround for DspCfg reset |
| Tony Breeds | [LGUEST] Look in object dir for .config |
git: | |
| Brian Downing | Re: Git in a Nutshell guide |
| John Benes | Re: master has some toys |
| Matthias Lederhofer | [PATCH 4/7] introduce GIT_WORK_TREE to specify the work tree |
| Alexander Sulfrian | [RFC/PATCH] RE: git calls SSH_ASKPASS even if DISPLAY is not set |
| Junio C Hamano | Re: Rss produced by git is not valid xml? |
| Linux Kernel Mailing List | iSeries: fix section mismatch in iseries_veth |
| Linux Kernel Mailing List | ixbge: remove TX lock and redo TX accounting. |
| Linux Kernel Mailing List | ixgbe: fix several counter register errata |
| Linux Kernel Mailing List | b43: fix build with CONFIG_SSB_PCIHOST=n |