Re: x86 merge: Keep kernel/cpu for CPU specific code?

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andi Kleen
Date: Tuesday, November 13, 2007 - 6:53 am

"Robert Richter" <robert.richter@amd.com> writes:


Well it's already used as it has been pointed out. 

Regarding the core initialization code:

The 32bit set up here is kind of crappy. Initcalls that are commented
out, weird ordering, unrelated stuff mixed toegether etc. If you
consider "improving" 64bit here then I would suggest to do some major
clean up in the 32bit parts first.

I personally consider the single file cleaner to hack, but then 64bit
is already vastly simpler anyways because it has much less CPUs to support.

If anything it would probably make sense to separate out generic
stuff (like GDT initialization) from CPU specific initialization.
64bit already separates that better too, but it's also not fully complete.

-Andi
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
x86 merge: Keep kernel/cpu for CPU specific code?, Robert Richter, (Tue Nov 13, 4:44 am)
Re: x86 merge: Keep kernel/cpu for CPU specific code?, Adrian Bunk, (Tue Nov 13, 5:02 am)
Re: x86 merge: Keep kernel/cpu for CPU specific code?, Andi Kleen, (Tue Nov 13, 6:53 am)
Re: x86 merge: Keep kernel/cpu for CPU specific code?, Robert Richter, (Tue Nov 13, 7:14 am)
Re: x86 merge: Keep kernel/cpu for CPU specific code?, H. Peter Anvin, (Tue Nov 13, 10:59 am)