Re: [PATCH] Introduce ext4_find_next_bit

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Aneesh Kumar K.V <aneesh.kumar@...>
Cc: <linux-ext4@...>, <linux-kernel@...>
Date: Tuesday, November 13, 2007 - 3:59 am

On Fri, 21 Sep 2007 10:55:05 +0530 "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:


arm allmodconfig:

fs/ext4/mballoc.c: In function `ext4_mb_generate_buddy':
fs/ext4/mballoc.c:836: error: implicit declaration of function `ext2_find_next_bit'

This patch makes my head spin.

Why did we declare generic_find_next_le_bit() in
include/asm-powerpc/bitops.h (wrong) as well as in
include/asm-generic/bitops/le.h (presumably correct)?

Why is it touching a powerpc file and no any other architectures? 
Something screwed up in powerpc land?

And why did arm break?

Shudder.  Anyway, please fix, and if that fix requires that various
braindamaged be repaired, please repair the braindamage rather than going
along with it.

Thanks.

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Introduce ext4_find_next_bit, Aneesh Kumar K.V, (Fri Sep 21, 1:25 am)
Re: [PATCH] Introduce ext4_find_next_bit, Andrew Morton, (Tue Nov 13, 3:59 am)
Re: [PATCH] Introduce ext4_find_next_bit, Aneesh Kumar K.V, (Tue Nov 13, 3:11 pm)
Re: [PATCH] Introduce ext4_find_next_bit, Andrew Morton, (Tue Nov 13, 4:43 pm)
Re: [PATCH] Introduce ext4_find_next_bit, Balbir Singh, (Fri Sep 21, 2:43 am)
Re: [PATCH] Introduce ext4_find_next_bit, Aneesh Kumar K.V, (Fri Sep 21, 5:08 am)
[PATCH] ext4: Fix spare warnings, Aneesh Kumar K.V, (Fri Sep 21, 1:25 am)
Re: [PATCH] ext4: Fix spare warnings, Balbir Singh, (Fri Sep 21, 2:02 am)
Re: [PATCH] ext4: Fix spare warnings, Aneesh Kumar K.V, (Fri Sep 21, 5:04 am)