Home » Mailing list archives » linux-kernel » 2007 » November » 13

Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Tetsuo Handa <penguin-kernel@...>
To: Andrew Morton <akpm@...>
Cc: <ebiederm@...>, <linux-kernel@...>
Subject: Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
Date: Monday, November 12, 2007 - 11:50 pm

Hello.

Andrew Morton wrote:
I'll leave it to you.
But if you want to allow args->nlen == CTL_MAXNAME,
you also need to update do_sysctl().

int do_sysctl(int __user *name, int nlen, void __user *oldval, size_t __user *oldlenp,
               void __user *newval, size_t newlen)
{
        ...
        if (nlen <= 0 || nlen >= CTL_MAXNAME)
                return -ENOTDIR;
        ...
}

Thanks.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] sysctl: Check length at deprecated_sysctl_warning., Tetsuo Handa, (Wed Nov 7, 10:57 pm)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Andrew Morton, (Wed Nov 7, 11:22 pm)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Tetsuo Handa, (Thu Nov 8, 4:19 am)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Eric W. Biederman, (Mon Nov 12, 5:44 am)
[PATCH] sysctl: Check length at deprecated_sysctl_warning., Tetsuo Handa, (Mon Nov 12, 11:07 pm)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Andrew Morton, (Mon Nov 12, 11:13 pm)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Tetsuo Handa, (Mon Nov 12, 11:50 pm)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Eric W. Biederman, (Tue Nov 13, 9:24 am)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Tetsuo Handa, (Mon Nov 12, 7:42 am)