Home » Mailing list archives » linux-kernel » 2007 » November » 12

Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Tetsuo Handa <penguin-kernel@...>
To: <ebiederm@...>
Cc: <akpm@...>, <linux-kernel@...>
Subject: Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
Date: Monday, November 12, 2007 - 7:42 am

Hello.

Eric W. Biederman wrote:
Yes.

Thus I think tmp.nlen == CTL_MAXNAME should be allowed
because tmp.nlen is used as "for (i = 0; i < tmp.nlen; i++)".
I think
	if (tmp.nlen <= 0 || tmp.nlen > CTL_MAXNAME)
		return -ENOTDIR;
is correct.

Thanks.

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] sysctl: Check length at deprecated_sysctl_warning., Tetsuo Handa, (Wed Nov 7, 10:57 pm)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Andrew Morton, (Wed Nov 7, 11:22 pm)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Tetsuo Handa, (Thu Nov 8, 4:19 am)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Eric W. Biederman, (Mon Nov 12, 5:44 am)
[PATCH] sysctl: Check length at deprecated_sysctl_warning., Tetsuo Handa, (Mon Nov 12, 11:07 pm)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Andrew Morton, (Mon Nov 12, 11:13 pm)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Tetsuo Handa, (Mon Nov 12, 11:50 pm)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Eric W. Biederman, (Tue Nov 13, 9:24 am)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Tetsuo Handa, (Mon Nov 12, 7:42 am)