On Sun, 11 Nov 2007, Benjamin Herrenschmidt wrote:

quoted text
>
> > Removed this as well, also seemed to work.  Please note, however, that
> > this is just running kernbench.  But this did seem to get rid of some
> > of the warnings as well.  ;-)  Now only have the xics_startup() warning.
> >
> > > Overall, looks fine !
> >
> > I bet that there are more gotchas lurking in there somewhere, but in
> > the meantime here is the updated patch.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > ---
>
> Well, I suppose the patch could go in, maybe with some ifdef's around
> the bits in _switch_to, there's little point in doing that on non-rt
> kernels.

As Nick Piggin already stated, and I'll even state it for the RT kernel,
we do not allow preemption in switch_to. So it is safe to remove those
"preempt_disable" bits from the patch.

-- Steve
-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/