Re: cd/dvd inaccessible in 2.6.24-rc2

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Alan Cox <alan@...>, Tejun Heo <htejun@...>
Cc: Andrew Morton <akpm@...>, Will Trives <will@...>, <linux-kernel@...>, <linux-ide@...>, Rafael J. Wysocki <rjw@...>
Date: Saturday, November 10, 2007 - 7:28 pm

Alan Cox wrote:


Agreed, though the output is indeed signalling an error...  IMO the EH 
should handle the error if the device is signalling an error, upon 
timeout, rather than just going ahead and resetting the device.

Its similar to where ATA devices on PCI SFF controllers signal DMA error 
via timeout, where EH must inspect BMDMA Status register to determine if 
it's a DMA error signalled by hardware, or something that requires 
additional autopsy.

EH for ATAPI is quite different from EH for ATA, so there may be some 
areas where we don't handle things the right way for ATAPI.

Decoding the error message we have:

cdb 0x5a ==
	MODE SENSE(10)
status 0x51 ==
	DRDY
	command-specific flag (aka SERV, in !overlap case)
	CHK (check condition, aka error)
error 0x54 ==
	ABRT (command aborted or command parameter invalid)
	sense key 0x5 (illegal request)
ireason 0x3 ==
	the hardcoded values (bits 0 and 1) remain hardcoded, all good

Since BSY is not set in the Status register, and given the other 
information derived from the decoded values, it looks like the device is 
otherwise happy and ready to accept additional commands.

It appears to have chewed on an ATAPI command, spit it out, but failed 
to send a completion interrupt.

So its an open question whether it's a device not completing this 
errored-out command, or whether its IRQ/ACPI stuff infecting libata.

	Jeff


-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
cd/dvd inaccessible in 2.6.24-rc2, Will Trives, (Sat Nov 10, 12:27 am)
Re: cd/dvd inaccessible in 2.6.24-rc2, Jeff Garzik, (Sat Nov 10, 7:35 pm)
Re: cd/dvd inaccessible in 2.6.24-rc2, Will Trives, (Sun Nov 11, 12:40 am)
Re: cd/dvd inaccessible in 2.6.24-rc2, Will Trives, (Mon Nov 12, 2:00 am)
Re: cd/dvd inaccessible in 2.6.24-rc2, Tejun Heo, (Mon Nov 12, 11:23 am)
Re: cd/dvd inaccessible in 2.6.24-rc2, Andrew Morton, (Sat Nov 10, 6:49 pm)
Re: cd/dvd inaccessible in 2.6.24-rc2, Alan Cox, (Sat Nov 10, 7:05 pm)
Re: cd/dvd inaccessible in 2.6.24-rc2, Andrew Morton, (Sat Nov 10, 8:13 pm)
Re: cd/dvd inaccessible in 2.6.24-rc2, Jeff Garzik, (Sat Nov 10, 7:28 pm)