[PATCH] drivers/video/s1d13xxxfb.c as module with dbg

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-kernel@...>
Cc: Thibaut VARENE <varenet@...>
Date: Saturday, November 10, 2007 - 11:51 am

Attached patch fixes two compilation problems of s1d13xxxfb.c:
- Fixes outdated dbg() message to fix compilation error with debugging enabled.
- Do not read kernel command line options when compiled as module.

Signed-off-by: Stanislav Brabec <utx@penguin.cz>

--- linux-2.6.23/drivers/video/s1d13xxxfb.c	2007-10-09 22:31:38.000000000 +0200
+++ linux-2.6.23/drivers/video/s1d13xxxfb.c	2007-11-02 16:48:34.000000000 +0100
@@ -540,7 +540,7 @@
 	int ret = 0;
 	u8 revision;
 
-	dbg("probe called: device is %p\n", dev);
+	dbg("probe called: device is %p\n", pdev);
 
 	printk(KERN_INFO "Epson S1D13XXX FB Driver\n");
 
@@ -753,8 +753,11 @@
 static int __init
 s1d13xxxfb_init(void)
 {
+
+#ifndef MODULE
 	if (fb_get_options("s1d13xxxfb", NULL))
 		return -ENODEV;
+#endif
 
 	return platform_driver_register(&s1d13xxxfb_driver);
 }


________________________________________________________________________
Stanislav Brabec
http://www.penguin.cz/~utx

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] drivers/video/s1d13xxxfb.c as module with dbg, Stanislav Brabec, (Sat Nov 10, 11:51 am)
Re: [PATCH] drivers/video/s1d13xxxfb.c as module with dbg, Kristoffer Ericson, (Tue Nov 13, 7:21 pm)
Re: [PATCH] drivers/video/s1d13xxxfb.c as module with dbg, Thibaut VARENE, (Sun Nov 11, 11:17 am)