Re: [BUILD-FAILURE] 2.6.24-rc1-git8 build fails drivers/pci/probe.c

Previous thread: termios bug fix proposal by David Miller on Wednesday, October 31, 2007 - 4:03 am. (1 message)

Next thread: [PATCH] "killing" sg_last(), and discussion by Jeff Garzik on Wednesday, October 31, 2007 - 4:49 am. (4 messages)
To: LKML <linux-kernel@...>
Cc: Greg Kroah-Hartman <gregkh@...>, Linus Torvalds <torvalds@...>, Andrew Morton <akpm@...>, Andy Whitcroft <apw@...>
Date: Wednesday, October 31, 2007 - 4:18 am

Hi,

The 2.6.24-rc-git8 build fails with build error

CC drivers/pci/probe.o
drivers/pci/probe.c: In function 'pci_create_legacy_files':
drivers/pci/probe.c:56: error: implicit declaration of function 'class_device_create_bin_file'
drivers/pci/probe.c: In function 'pci_remove_legacy_files':
drivers/pci/probe.c:71: error: implicit declaration of function 'class_device_remove_bin_file'
make[2]: *** [drivers/pci/probe.o] Error 1
make[1]: *** [drivers/pci] Error 2
make: *** [drivers] Error 2

This is caused by the commit fcd239d3d5575e5cc63aab5c33cf6dc66904f6d6 (Driver core: remove class_device_*_bin_file).
These functions are still being used by drivers/pci/probe.c.

--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-

To: Kamalesh Babulal <kamalesh@...>
Cc: LKML <linux-kernel@...>, Linus Torvalds <torvalds@...>, Andrew Morton <akpm@...>, Andy Whitcroft <apw@...>
Date: Thursday, November 1, 2007 - 11:40 am

Thanks for the report, Linus's tree now has a fix for this oversight on
my behalf.

greg k-h
-

Previous thread: termios bug fix proposal by David Miller on Wednesday, October 31, 2007 - 4:03 am. (1 message)

Next thread: [PATCH] "killing" sg_last(), and discussion by Jeff Garzik on Wednesday, October 31, 2007 - 4:49 am. (4 messages)