Home » Mailing list archives » linux-kernel » 2007 » October » 9

[PATCH] natsemi: Use round_jiffies() for slow timers

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Mark Brown <broonie@...>
To: <jgarzik@...>, <thockin@...>
Cc: <netdev@...>, <linux-kernel@...>, Mark Brown <broonie@...>
Subject: [PATCH] natsemi: Use round_jiffies() for slow timers
Date: Tuesday, October 9, 2007 - 5:57 pm

Unless we have failed to fill the RX ring the timer used by the natsemi
driver is not particularly urgent and can use round_jiffies() to allow
grouping with other timers.

Signed-off-by: Mark Brown <broonie@sirena.org.uk>
---
 drivers/net/natsemi.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
index b47a12d..0b33a58 100644
--- a/drivers/net/natsemi.c
+++ b/drivers/net/natsemi.c
@@ -1575,7 +1575,7 @@ static int netdev_open(struct net_device *dev)
 
 	/* Set the timer to check for link beat. */
 	init_timer(&np->timer);
-	np->timer.expires = jiffies + NATSEMI_TIMER_FREQ;
+	np->timer.expires = round_jiffies(jiffies + NATSEMI_TIMER_FREQ);
 	np->timer.data = (unsigned long)dev;
 	np->timer.function = &netdev_timer; /* timer handler */
 	add_timer(&np->timer);
@@ -1855,7 +1855,11 @@ static void netdev_timer(unsigned long data)
 			next_tick = 1;
 		}
 	}
-	mod_timer(&np->timer, jiffies + next_tick);
+
+	if (next_tick > 1)
+		mod_timer(&np->timer, round_jiffies(jiffies + next_tick));
+	else
+		mod_timer(&np->timer, jiffies + next_tick);
 }
 
 static void dump_ring(struct net_device *dev)
@@ -3330,7 +3334,7 @@ static int natsemi_resume (struct pci_dev *pdev)
 		spin_unlock_irq(&np->lock);
 		enable_irq(dev->irq);
 
-		mod_timer(&np->timer, jiffies + 1*HZ);
+		mod_timer(&np->timer, round_jiffies(jiffies + 1*HZ));
 	}
 	netif_device_attach(dev);
 	netif_poll_enable(dev);
-- 
1.5.3.4

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] natsemi: Use round_jiffies() for slow timers, Mark Brown, (Tue Oct 9, 5:57 pm)
Re: [PATCH] natsemi: Use round_jiffies() for slow timers, Jeff Garzik, (Tue Oct 9, 8:47 pm)
[PATCH] natsemi: Use round_jiffies() for slow timers, Mark Brown, (Wed Oct 10, 6:05 am)
Re: [PATCH] natsemi: Use round_jiffies() for slow timers, Jeff Garzik, (Mon Oct 15, 2:21 pm)
[PATCH] natsemi: Check return value for pci_enable_device(), Mark Brown, (Wed Oct 10, 12:11 pm)
[PATCH] natsemi: Use NATSEMI_TIMER_FREQ consistently, Mark Brown, (Tue Oct 9, 5:57 pm)
Re: [PATCH] natsemi: Use NATSEMI_TIMER_FREQ consistently, Jeff Garzik, (Tue Oct 9, 8:47 pm)