Home » Mailing list archives » linux-kernel » 2007 » October » 9

[PATCH] natsemi: Use NATSEMI_TIMER_FREQ consistently

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Mark Brown <broonie@...>
To: <jgarzik@...>, <thockin@...>
Cc: <netdev@...>, <linux-kernel@...>, Mark Brown <broonie@...>
Subject: [PATCH] natsemi: Use NATSEMI_TIMER_FREQ consistently
Date: Tuesday, October 9, 2007 - 5:57 pm

The natsemi driver has a define NATSEMI_TIMER_FREQ which looks like it
controls the normal frequency of the chip poll timer but in fact only
takes effect for the first run of the timer.  Adjust the value of the
define to match that used by the timer and use the define consistently.

Signed-off-by: Mark Brown <broonie@sirena.org.uk>
---
 drivers/net/natsemi.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
index 0b33a58..1f88604 100644
--- a/drivers/net/natsemi.c
+++ b/drivers/net/natsemi.c
@@ -108,7 +108,7 @@ static int full_duplex[MAX_UNITS];
 #define TX_TIMEOUT  (2*HZ)
 
 #define NATSEMI_HW_TIMEOUT	400
-#define NATSEMI_TIMER_FREQ	3*HZ
+#define NATSEMI_TIMER_FREQ	5*HZ
 #define NATSEMI_PG0_NREGS	64
 #define NATSEMI_RFDR_NREGS	8
 #define NATSEMI_PG1_NREGS	4
@@ -1797,7 +1797,7 @@ static void netdev_timer(unsigned long data)
 	struct net_device *dev = (struct net_device *)data;
 	struct netdev_private *np = netdev_priv(dev);
 	void __iomem * ioaddr = ns_ioaddr(dev);
-	int next_tick = 5*HZ;
+	int next_tick = NATSEMI_TIMER_FREQ;
 
 	if (netif_msg_timer(np)) {
 		/* DO NOT read the IntrStatus register,
-- 
1.5.3.4

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] natsemi: Use round_jiffies() for slow timers, Mark Brown, (Tue Oct 9, 5:57 pm)
Re: [PATCH] natsemi: Use round_jiffies() for slow timers, Jeff Garzik, (Tue Oct 9, 8:47 pm)
[PATCH] natsemi: Use round_jiffies() for slow timers, Mark Brown, (Wed Oct 10, 6:05 am)
Re: [PATCH] natsemi: Use round_jiffies() for slow timers, Jeff Garzik, (Mon Oct 15, 2:21 pm)
[PATCH] natsemi: Check return value for pci_enable_device(), Mark Brown, (Wed Oct 10, 12:11 pm)
[PATCH] natsemi: Use NATSEMI_TIMER_FREQ consistently, Mark Brown, (Tue Oct 9, 5:57 pm)
Re: [PATCH] natsemi: Use NATSEMI_TIMER_FREQ consistently, Jeff Garzik, (Tue Oct 9, 8:47 pm)