Re: [Linux-usb-users] OHCI root_port_reset() deadly loop...

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Brownell
Date: Tuesday, October 9, 2007 - 11:59 am

> Here is a proposed patch.  I haven't tried running it, but it compiles 

Looks about right, too; thanks.  Minor comments:


You have two copies of that comment; I'd drop this one, and add a
better one around CF initialization.

What I'd have here is a comment that this symbol is exported ONLY
for use by the EHCI driver, trespassers will be violated, etc.



That deserves a comment about how CF and companion port resets
don't mix well.

... assuming this does check out as the problem, which I expect
it will.

- Dave

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
OHCI root_port_reset() deadly loop..., David Miller, (Sat Oct 6, 11:53 pm)
Re: OHCI root_port_reset() deadly loop..., David Brownell, (Sun Oct 7, 12:31 am)
Re: OHCI root_port_reset() deadly loop..., David Miller, (Sun Oct 7, 12:51 am)
Re: OHCI root_port_reset() deadly loop..., David Miller, (Mon Oct 8, 4:54 pm)
Re: OHCI root_port_reset() deadly loop..., Greg KH, (Mon Oct 8, 8:10 pm)
Re: OHCI root_port_reset() deadly loop..., David Miller, (Mon Oct 8, 8:16 pm)
Re: OHCI root_port_reset() deadly loop..., David Brownell, (Mon Oct 8, 8:34 pm)
Re: OHCI root_port_reset() deadly loop..., David Miller, (Mon Oct 8, 8:42 pm)
Re: OHCI root_port_reset() deadly loop..., David Brownell, (Mon Oct 8, 9:09 pm)
Re: OHCI root_port_reset() deadly loop..., David Brownell, (Mon Oct 8, 9:36 pm)
Re: OHCI root_port_reset() deadly loop..., Greg KH, (Mon Oct 8, 9:39 pm)
Re: OHCI root_port_reset() deadly loop..., David Miller, (Mon Oct 8, 9:44 pm)
Re: OHCI root_port_reset() deadly loop..., David Miller, (Mon Oct 8, 9:47 pm)
Re: OHCI root_port_reset() deadly loop..., David Brownell, (Mon Oct 8, 10:00 pm)
Re: OHCI root_port_reset() deadly loop..., Benjamin Herrenschmidt, (Mon Oct 8, 10:11 pm)
Re: OHCI root_port_reset() deadly loop..., Benjamin Herrenschmidt, (Mon Oct 8, 10:13 pm)
Re: OHCI root_port_reset() deadly loop..., David Miller, (Mon Oct 8, 10:23 pm)
Re: OHCI root_port_reset() deadly loop..., David Miller, (Mon Oct 8, 10:26 pm)
Re: OHCI root_port_reset() deadly loop..., Greg KH, (Mon Oct 8, 11:06 pm)
Re: OHCI root_port_reset() deadly loop..., Benjamin Herrenschmidt, (Mon Oct 8, 11:37 pm)
Re: OHCI root_port_reset() deadly loop..., Benjamin Herrenschmidt, (Mon Oct 8, 11:43 pm)
Re: OHCI root_port_reset() deadly loop..., David Brownell, (Tue Oct 9, 9:38 am)
Re: OHCI root_port_reset() deadly loop..., David Brownell, (Tue Oct 9, 11:48 am)
Re: [Linux-usb-users] OHCI root_port_reset() deadly loop..., David Brownell, (Tue Oct 9, 11:59 am)
Re: OHCI root_port_reset() deadly loop..., David Miller, (Tue Oct 9, 1:41 pm)
Re: OHCI root_port_reset() deadly loop..., Greg KH, (Tue Oct 9, 1:46 pm)
Re: OHCI root_port_reset() deadly loop..., David Brownell, (Tue Oct 9, 2:05 pm)
Re: OHCI root_port_reset() deadly loop..., David Brownell, (Tue Oct 9, 2:09 pm)
Re: [Linux-usb-users] OHCI root_port_reset() deadly loop..., David Brownell, (Tue Oct 16, 11:26 am)