On Tue, 2007-10-09 at 11:37 +0200, Xavier Bestel wrote:

quoted text
> FWIW, the patch in question is a one-liner:

That's not a valid argument. This may work with a WM5 device, but looks
very dubious, wrt. other RNDIS devices. Why are these constants
hardcoded and not taken in some way from the descriptors?

There must be some justification why these values need to be hardcoded,
and if so, this must be dependent on the rndis device really being a WM5
device.

Nacked-By: Thomas Sailer <t.sailer@alumni.ethz.ch>


-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/