| From | Subject | Date |
|---|---|---|
| Nick Piggin | Re: [PATCH -mm -v4 1/3] i386/x86_64 boot: setup data
I suppose that's not unreasonable to put in mm/memory.c, although
it's not really considered a problem to do this kind of stuff in
a low level arch file...
You have no kernel virtual mapping for the source data?
Should it be __init?
Care to add a line of documentation if you keep it in mm/memory.c?
Thanks,
Nick
-
| Oct 8, 11:25 am 2007 |
| Nick Piggin | Re: [PATCH -mm -v4 1/3] i386/x86_64 boot: setup data
I'm just wondering whether you really need to access highmem in
Definitely on most architectures it would just amount to
memcpy(dst, __va(phys), n);, right? However I don't know if
it's worth the trouble of overriding it unless there is some
non-__init user of it.
-
| Oct 8, 12:06 pm 2007 |
| Nick Piggin | Re: [PATCH -mm -v4 1/3] i386/x86_64 boot: setup data
Ah, I see. I missed that.
OK, well rather than make it weak, and have everyone except
i386 override it, can you just ifdef CONFIG_HIGHMEM?
After that, I guess most other architectures wouldn't even
use the function. Maybe it can go into lib/ instead so that
it can be discarded by the linker if it isn't used?
-
| Oct 8, 12:28 pm 2007 |
| Dave Young | Re: [PATCH] param_sysfs_builtin memchr argument fix
Yes, it will casuse duplicate filenames in sysfs. For me, the "nousb"
Regards
dave
====================================================
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
kernel/params.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff -upr linux/kernel/params.c linux.new/kernel/params.c
--- linux/kernel/params.c 2007-10-08 14:30:06.000000000 +0800
+++ linux.new/kernel/params.c 2007-10-09 09:16:55.000000000 +0800
@@ -592,11 +592,17 @@ sta...
| Oct 8, 9:21 pm 2007 |
| Tim Pepper | [PATCH] lockdep: Avoid /proc/lockdep & lock_stat infinit...
When a read() requests an amount of data smaller than the amount of data
that the seq_file's foo_show() outputs, the output starts looping and
outputs the "stuck" element's data infinitely. There may be multiple
sequential calls to foo_start(), foo_next()/foo_show(), and foo_stop()
for a single open with sequential read of the file. The _start() does not
have to start with the 0th element and _show() might be called multiple
times in a row for the same element for a given open/read of the seq_file...
| Oct 8, 9:15 pm 2007 |
| Al Viro | Re: [PATCH] lockdep: Avoid /proc/lockdep & lock_stat inf...
Do not generate output outside of ->show() and you won't have these
problems. That's where your infinite output crap comes from.
IOW, NAK - fix the underlying problem.
-
| Oct 8, 9:30 pm 2007 |
| Darrick J. Wong | [PATCH 2/2] aic94xx: Use sas_request_addr() to provide SAS a...
If the aic94xx chip doesn't have a SAS address in the chip's flash memory,
make libsas get one for us. Also clean out some old code that had been
used to do this in the past.
Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
---
drivers/scsi/aic94xx/aic94xx.h | 16 ----------------
drivers/scsi/aic94xx/aic94xx_hwi.c | 21 ++++++++++-----------
drivers/scsi/aic94xx/aic94xx_init.c | 2 --
3 files changed, 10 insertions(+), 29 deletions(-)
diff --git a/drivers/scsi/aic94xx/...
| Oct 8, 8:43 pm 2007 |
| Darrick J. Wong | [PATCH 1/2] libsas: Provide a transport-level facility to re...
Use the request_firmware() interface to get a SAS address from userspace.
This way, there's no debate as to who or how an address gets generated;
it's up to the administrator to provide one if the driver can't find one
on its own.
Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
---
drivers/scsi/libsas/sas_scsi_host.c | 41 +++++++++++++++++++++++++++++++++++
include/scsi/libsas.h | 3 +++
2 files changed, 44 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/...
| Oct 8, 8:39 pm 2007 |
| Neil Brown | Re: RFC: reviewer's statement of oversight
On Monday October 8, corbet@lwn.net wrote:
I find it is always good to know *why* we have the tags. That
information is a useful complement to what they mean, and can guide
people in adding them.
So below I present some "Purposes", YetAnotherTag, and a comment on
the RSO.
(And I'd like to add a vote for "Blame-Shared-By:" rather than
From: The Author, Primary Author, or Authors of the patch.
Authors should also provide a Signed-off-by: tag.
Pur...
| Oct 8, 8:05 pm 2007 |
| Jun'ichi Nomura | [PATCH] device-mapper: fix bd_mount_sem corruption
Hi,
This patch fixes a bd_mount_sem counter corruption bug in device-mapper.
thaw_bdev() should be called only when freeze_bdev() was called for the
device.
Otherwise, thaw_bdev() will up bd_mount_sem and corrupt the semaphore counter.
struct block_device with the corrupted semaphore may remain in slab cache
and be reused later.
Attached patch will fix it by calling unlock_fs() instead.
unlock_fs() will determine whether it should call thaw_bdev()
by checking the device is frozen or not.
E...
| Oct 8, 7:31 pm 2007 |
| Casey Schaufler | [PATCH] [NetLabel] Introduce a new kernel configuration API ...
From: Paul Moore <paul.moore@hp.com>
Add a new set of configuration functions to the NetLabel/LSM API so that
LSMs can perform their own configuration of the NetLabel subsystem without
relying on assistance from userspace.
Signed-off-by: Paul Moore <paul.moore@hp.com>
---
This update fixes a memory leak on error conditions.
include/net/netlabel.h | 47 ++++++++--
net/ipv4/cipso_ipv4.c | 4 -
net/netlabel/netlabel_cipso_v4.c | 2
net/netlabel...
| Oct 8, 7:04 pm 2007 |
| Stefan Richter | possible recursive locking detected... in __wake_up
Hi list,
(from https://bugzilla.redhat.com/show_bug.cgi?id=323411)
We wake up the queue from a workqueue context (rarely) and from tasklet
context (frequently). However, since __wake_up disables local IRQs, it
should be entirely impossible for __wake_up to take q->lock twice before
releasing it. What's the deal?
--
Stefan Richter
-=====-=-=== =-=- -=--=
http://arcgraph.de/sr/
-
| Oct 8, 7:03 pm 2007 |
| Maarten Bressers | [PATCH] Correct Makefile rule for generating custom keymap.
When building a custom keymap, after setting GENERATE_KEYMAP := 1 in
drivers/char/Makefile, the kernel build fails like this:
CC drivers/char/vt.o
make[2]: *** No rule to make target `drivers/char/%.map', needed by
`drivers/char/defkeymap.c'. Stop.
make[1]: *** [drivers/char] Error 2
make: *** [drivers] Error 2
This was caused by commit af8b128719f5248e542036ea994610a29d0642a6,
which deleted a necessary colon from the Makefile rule that generates
the keymap, since that rule contains bot...
| Oct 8, 6:41 pm 2007 |
| Pavel Machek | gigabit ethernet power consumption
Hi!
I've found that gbit vs. 100mbit power consumption difference is about
1W -- pretty significant. (Maybe powertop should include it in the
tips section? :).
Energy Star people insist that machines should switch down to 100mbit
when network is idle, and I guess that makes a lot of sense -- you
save 1W locally and 1W on the router.
Question is, how to implement it correctly? Daemon that would watch
data rates and switch speeds using mii-tool would be simple, but is
that enough?
Pav...
| Oct 8, 6:07 pm 2007 |
| Kok, Auke | Re: gigabit ethernet power consumption
you most certainly want to do this in userspace I think.
One of the biggest problems is that link negotiation can take a significant amount
of time, well over several seconds (1 to 3 seconds typical) with gigabit, and
having your ethernet connection go offline for 3 seconds may not be the desired
effect for when you want to get more bandwidth in the first place.
However, when a laptop is in battery mode, switching down from gigabit to 100mbit
makes a lot more sense, so this is something I would ...
| Oct 8, 6:31 pm 2007 |
| Pavel Machek | sleepy linux 2.6.23-rc9
Hi!
I played with powertop a bit, and found a fairly interesting failure
mode. If I boot init=/bin/bash vga=1, I get ~2 wakeups a second, nice.
When I boot init=/bin/bash vga=791 (vesa framebuffer), most wakeups
are caused by cursor painting (I should fix that some day, I
guess). But... the cursor blinking does not even work properly!
It blinks at normal speed, then (randomly) it blinks slowly, then gets
back to normal speed, then inserts longer delay.
The effect is so nice that I thought ab...
| Oct 8, 6:05 pm 2007 |
| Clemens Koller | Re: sleepy linux 2.6.23-rc9
Is the effect a beat that it has roughly the frequency of your Notebooks
No idea... check where the register of the HW cursor blink rate
gets written? But as it seems to be so nice, please submit a patch
which enables this for all platforms. ;-)
Regards,
--
Clemens Koller
_______________________________
R&D Imaging Devices
Anagramm GmbH
Rupert-Mayer-Str. 45/1
81379 Muenchen
Germany
http://www.anagramm-technology.com
Phone: +49-89-741518-50
Fax: +49-89-741518-19
-
| Oct 8, 7:46 pm 2007 |
| H. Peter Anvin | Re: sleepy linux 2.6.23-rc9
For the VESA framebuffer I would assume the cursor blinking is done in
software (if done at all.)
-hpa
-
| Oct 8, 8:52 pm 2007 |
| Helge Hafting | 2.6.23-rc9 compile error drivers/video/fbmon.c
CC drivers/video/fbmon.o
drivers/video/fbmon.c: In function ‘fb_parse_edid’:
drivers/video/fbmon.c:867: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attrib
_’ before ‘*’ token
drivers/video/fbmon.c:867: error: ‘block’ undeclared (first use in this func
)
This line reads:
unsigned char$*block;
Source error, or is my tree simply corrupt?
Helge Hafting
-
| Oct 8, 6:00 pm 2007 |
| Adrian Bunk | Re: 2.6.23-rc9 compile error drivers/video/fbmon.c
The $ is a space character in my copy of the tree, so it seems to be a
corrupted tree with a bit error on your side ($ and the space character
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
| Oct 8, 6:12 pm 2007 |
| Helge Hafting | Re: 2.6.23-rc9 compile error drivers/video/fbmon.c
I downloaded a new tree.
That file has quite a few single-bit errors in my old tree.
Mostly of the +16 variety.
Seems I have to look for bad memory :-( :-( :-(
Helge Hafting
-
| Oct 8, 6:16 pm 2007 |
| Randy Dunlap | Re: 2.6.23-rc9 compile error drivers/video/fbmon.c
Hi,
It's a space in my kernel source file.
---
~Randy
-
| Oct 8, 6:07 pm 2007 |
| Dmitri Vorobiev | [PATCH] NTFS error messages: replace static char pointers by...
Hi,
The patch below contains a small code clean-up for the NTFS driver: all
static char pointers to error message strings have been replaced by
static char arrays.
Please apply if you like it.
Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
---
diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c
index 1c08fef..b883537 100644
--- a/fs/ntfs/attrib.c
+++ b/fs/ntfs/attrib.c
@@ -869,7 +869,7 @@ static int ntfs_external_attr_find(const ATTR_TYPE type,
ntfschar *al_name;
u32...
| Oct 8, 5:55 pm 2007 |
| Eric Paris | [PATCH 3/3] Audit: remove the limit on execve arguments when...
Remove the limitation on argv size. The audit system now logs arguments in
smaller chunks (currently about 8k due to userspace audit system buffer sizes)
so this is no longer a requirement.
Signed-off-by: Eric Paris <eparis@redhat.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
This patch hasn't changed since the last series, just reposted as 3/3 and rediffed.
kernel/auditsc.c | 10 ----------
kernel/sysctl.c | 11 -----------
2 files changed, 0 ins...
| Oct 8, 5:34 pm 2007 |
| Eric Paris | [PATCH 1/3] Audit: break up execve argument lists into multi...
Break the auditing of a list of execve arguments into smaller records if there
are a too many. The limit is currently around 7.5k of arguments as userspace
has an 8k buffer limit and will drop messages which are longer.
Signed-off-by: Eric Paris <eparis@redhat.com>
---
Basically the same patch as last time, used a #define, cleaned up a
memory leak on a malloc failure code path. Other than that it's the
same.
7500 also is a good size because it means we never need more...
| Oct 8, 5:34 pm 2007 |
| Eric Paris | [PATCH 2/3] Audit: break a large single execve argument into...
support single arguments that are large, not just large lists of execve args.
This also means we never have to get a kernel buffer larger than
MAX_EXECVE_AUDIT_LEN no matter how large the argument is. Before this patch
we could need to allocate 32 consecutive pages to hold one argument which could
pretty easily oom.
a single argument larger than MAX_EXECVE_AUDIT_LEN is broken into multiple
records and have a format like a10[0] a10[1] a10[2] etc.
Signed-o...
| Oct 8, 5:34 pm 2007 |
| Darrick J. Wong | [PATCH] aic94xx: Use request_firmware() to provide SAS addre...
If the aic94xx chip doesn't have a SAS address in the chip's flash memory,
use the request_firmware() interface to get one from userspace. This
way, there's no debate as to who or how an address gets generated--it's
totally up to the administrator to provide it if the card doesn't have one.
Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
---
drivers/scsi/aic94xx/aic94xx.h | 1 -
drivers/scsi/aic94xx/aic94xx_hwi.c | 40 +++++++++++++++++++++++++----------
drivers/scsi/aic94x...
| Oct 8, 5:25 pm 2007 |
| Andrew Vasquez | Re: [PATCH] aic94xx: Use request_firmware() to provide SAS a...
So how about factoring that out to a transport-level interface. How
about something along the lines of the following patch, whereby the
software driver upon detecting no valid WWPN, makes an upcall to each
interface's 'request_wwn()'. The data passed in from shost_gendev
should be enough for some helper script to cull relevent device bits
and perhaps offer some level of persistence... Off base?
Darrick, forgive the FC example, I don't do SAS...
--
av
--
diff --git a/drivers/scsi/scsi_...
| Oct 8, 6:48 pm 2007 |
| Darrick J. Wong | Re: [PATCH] aic94xx: Use request_firmware() to provide SAS a...
Hrm... jejb made a remark that it might be better to pass the
scsi_host's device into request_firmware() as your example does, so I'll
pitch in a patch to do likewise with libsas--the scsi_host knows the
actual device it's coming from, and userland can sort that all out later
anyway via DEVPATH.
I suppose one could also have multiple scsi_hosts per PCI device, which
means that my first patch would stumble horribly in more than a few
That's ok, I don't do FC. :) Looks mostly good to me...
--...
| Oct 8, 7:50 pm 2007 |
| Andrew Vasquez | Re: [PATCH] aic94xx: Use request_firmware() to provide SAS a...
This is done already in the FC case -- NPIV. Though with that
interface, the administrator is already responsible for assigning
--
av
-
| Oct 8, 8:12 pm 2007 |
| Hugh Dickins | SCHED_NO_NO_OMIT_FRAME_POINTER
I nearly had to visit a psychiatrist when I selected "n" to
SCHED_NO_NO_OMIT_FRAME_POINTER in 2.6.23-rc8-mm2: sorry if
I'm spoiling an in-joke, but is there any chance that could
be changed (with reversed sense) to SCHED_FRAME_POINTER?
Hugh
-
| Oct 8, 8:43 am 2007 |
| Sam Ravnborg | [RFC/RFT] kbuild: save ARCH & CROSS_COMPILE
One of the complaints that I continue to hear is that kbuild
is lacking a way to 'remember' the ARCH and CROSS_COMPILE
values originally used.
Likewise we have people that change ARCH settings and get
a lot of build errors due to asm symlink pointing at the
wrong directory.
This patch tries to address this by saving ARCH and
CROSS_COMPILE settings and error out if user specify
anohter ARCH or CROSS_COMPILE setting.
If there is inconsistency then error out and suggest
to run make mrproper.
Thi...
| Oct 8, 4:02 pm 2007 |
| Adrian Bunk | Re: [RFC/RFT] kbuild: save ARCH & CROSS_COMPILE
A .dot file sounds better.
And even if not, generated files should IMHO not share the Kbuild*
namespace with non-generated files.
cu
Adrian
BTW: I'm currently trying without success to understand why the
drivers/infiniband/{hw/amso1100,ulp/srp}/Kbuild files are not
named "Makefile".
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
...
| Oct 8, 5:12 pm 2007 |
| Giacomo Catenazzi | Re: [RFC/RFT] kbuild: save ARCH & CROSS_COMPILE
or the inverse ;-) Why all Makefiles (but the top level one ) are not
named Kbuild, considering that they are not valid (standalone) Makefile.
ciao
cate
-
| Oct 8, 5:20 pm 2007 |
| Oleg Verych | Re: [RFC/RFT] kbuild: save ARCH & CROSS_COMPILE
Yea, finally.
What about, that this is the first ever prompt, that must be shown and
written to the .config?
The zeroth one is an config entry of kernel version(s), .config can
configure and thus build successfully.
This are among other ideas about kconfig/kbuild, you know nothing
about yet.
So, what do you think?
Also, i'd like to propose sequencing of config-enable-build-this-unit
in config file(s), thus Makefile(s) (sometimes very small and stupid)
will be not necessary. Additiona...
| Oct 8, 4:50 pm 2007 |
| Michael Kerrisk | man-pages-2.66 is released
Gidday,
Some news: the list linux-man@vger.kernel.org has been created for the
purpose of discussing Linux man page bugs, patches, and maintenance. To
subscribe, send a message to majordomo@vger.kernel.org, with the body:
subscribe linux-man
Back to the news as usual...
I recently released man-pages-2.66.
This release is now available for download at:
http://www.kernel.org/pub/linux/docs/manpages
or ftp://ftp.kernel.org/pub/linux/docs/manpages
Changes in this release tha...
| Oct 8, 3:51 pm 2007 |
| Rafael J. Wysocki | Re: 2.6.23-rc9-git5: Known regressions from 2.6.22
Added: http://bugzilla.kernel.org/show_bug.cgi?id=9135
Thanks,
Rafael
-
| Oct 8, 4:06 pm 2007 |
| Vegard Nossum | [RFC][PATCH] Escaping the arguments of kernel messages for s...
Alan,
I send here the simplified patch to emit log messages with markers for
the message arguments, as per your suggestion. Do you still think this
is over-kill?
The rigour exists in order to preserve the generality of snprintf(),
instead of changing it to include printk-specific code, which in my
opinion does not belong there.
If these changes to make snprintf() more customizable will never be used
in any other place in the kernel, then they are clearly also over-kill.
These functions make...
| Oct 8, 3:45 pm 2007 |
| James Bowes | [PATCH] Documentation: Fix typo in SubmitChecklist.
Signed-off-by: James Bowes <jbowes@dangerouslyinc.com>
---
Documentation/SubmitChecklist | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Documentation/SubmitChecklist b/Documentation/SubmitChecklist
index 19e7f65..34e06d2 100644
--- a/Documentation/SubmitChecklist
+++ b/Documentation/SubmitChecklist
@@ -67,7 +67,7 @@ kernel patches.
20: Check that it all passes `make headers_check'.
21: Has been checked with injection of at least slab and page-allocation
- ...
| Oct 8, 2:55 pm 2007 |
| Alexey Dobriyan | Re: + fix-vm_can_nonlinear-check-in-sys_remap_file_pages.pat...
Ick.
[PATCH] typo time?
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
drivers/block/paride/pt.c | 2 -
drivers/block/pktcdvd.c | 4 +--
drivers/isdn/act2000/module.c | 22 ++++++++---------
drivers/isdn/i4l/isdn_ttyfax.c | 2 -
drivers/isdn/icn/icn.c | 22 ++++++++---------
drivers/isdn/isdnloop/isdnloop.c | 16 ++++++------
drivers/media/video/pvrusb2/pvr...
| Oct 8, 2:40 pm 2007 |
| Ray Lee | Re: + fix-vm_can_nonlinear-check-in-sys_remap_file_pages.pat...
Perhaps a good candidate for checkpatch.pl? (Andy cc:d.)
Ray
-
| Oct 8, 7:09 pm 2007 |
| Greg KH | [patch 00/12] 2.6.22.10 -stable review
This is the start of the stable review cycle for the 2.6.22.10 release.
There are 12 patches in this series, all will be posted as a response to
this one. If anyone has any issues with these being applied, please let
us know. If anyone is a maintainer of the proper subsystem, and wants
to add a Signed-off-by: line to the patch, please respond with it.
These patches are sent out with a number of different people on the Cc:
line. If you wish to be a reviewer, please email stable@kernel.org to
add ...
| Oct 8, 2:05 pm 2007 |
| Greg KH | Re: [patch 00/12] 2.6.22.10 -stable review
The "rolled-up" patch can be found at:
kernel.org/pub/linux/kernel/v2.6/stable-review/patch-2.6.22.10-rc1.gz
thanks,
greg k-h
-
| Oct 8, 2:09 pm 2007 |
| Greg KH | [patch 12/12] i386: Use global flag to disable broken local ...
From: Andi Kleen <ak@suse.de>
commit d3f7eae182b04997be19343a23f7009170f4f7a5 upstream
The Averatec 2370 and some other Turion laptop BIOS seems to program the
ENABLE_C1E MSR inconsistently between cores. This confuses the lapic
use heuristics because when C1E is enabled anywhere it seems to affect
the complete chip.
Use a global flag instead of a per cpu flag to handle this.
If any CPU has C1E enabled disabled lapic use.
Thanks to Cal Peake for debugging.
Cc: tglx@linutronix.de
Cc...
| Oct 8, 2:06 pm 2007 |
| Greg KH | [patch 11/12] SELinux: clear parent death signal on SID tran...
From: Stephen Smalley <sds@tycho.nsa.gov>
commit 4ac212ad4e8fafc22fa147fc255ff5fa5435cf33 upstream.
Clear parent death signal on SID transitions to prevent unauthorized
signaling between SIDs.
Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
Acked-by: Eric Paris <eparis@parisplace.org>
Signed-off-by: James Morris <jmorris@localhost.localdomain>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
security/selinux/hooks.c | 3 +++
1 file changed, 3 ins...
| Oct 8, 2:06 pm 2007 |
| Greg KH | [patch 10/12] Fix timer_stats printout of events/sec
From: Anton Blanchard <anton@samba.org>
commit 74922be1485818ed368c4cf4f0b100f70bf01e08 upstream.
When using /proc/timer_stats on ppc64 I noticed the events/sec field wasnt
accurate. Sometimes the integer part was incorrect due to rounding (we
werent taking the fractional seconds into consideration).
The fraction part is also wrong, we need to pad the printf statement and
take the bottom three digits of 1000 times the value.
Signed-off-by: Anton Blanchard <anton@samba.org>
Acked...
| Oct 8, 2:06 pm 2007 |
| Greg KH | [patch 09/12] Fix SMP poweroff hangs
From: Mark Lord <lkml@rtr.ca>
commit 4047727e5ae33f9b8d2b7766d1994ea6e5ec2991 from upstream
We need to disable all CPUs other than the boot CPU (usually 0) before
attempting to power-off modern SMP machines. This fixes the
hang-on-poweroff issue on my MythTV SMP box, and also on Thomas Gleixner's
new toybox.
Signed-off-by: Mark Lord <mlord@pobox.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Signed-off-by: Andrew Morton <a...
| Oct 8, 2:06 pm 2007 |
| Greg KH | [patch 08/12] NLM: Fix a circular lock dependency in lockd
From: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 255129d1e9ca0ed3d69d5517fae3e03d7ab4b806 in upstream.
The problem is that the garbage collector for the 'host' structures
nlm_gc_hosts(), holds nlm_host_mutex while calling down to
nlmsvc_mark_resources, which, eventually takes the file->f_mutex.
We cannot therefore call nlmsvc_lookup_host() from within
nlmsvc_create_block, since the caller will already hold file->f_mutex, so
the attempt to grab nlm_host_mutex may deadlock.
...
| Oct 8, 2:06 pm 2007 |
| Roel Kluin | Re: [patch 08/12] NLM: Fix a circular lock dependency in lockd
Greg KH wrote:
@@ -477,10 +479,15 @@ nlmsvc_testlock(struct svc_rqst *rqstp,
if (block == NULL) {
struct file_lock *conf = kzalloc(sizeof(*conf), GFP_KERNEL);
+ struct nlm_host *host;
if (conf == NULL)
return nlm_granted;
- block = nlmsvc_create_block(rqstp, file, lock, cookie);
+ /* Create host handle for callback */
+ host = nlmsvc_lookup_host(rqstp, lock->caller, lock->len);
+ if (host == NULL)
+ return nlm_lck_denied_nolocks;
+ block = nlmsvc_create_block(r...
| Oct 8, 4:01 pm 2007 |
| Greg KH | [patch 07/12] i2c-algo-bit: Read block data bugfix
From: David Brownell <david-b@pacbell.net>
In Linus tree already:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=939bc4943d...
This fixes a bug in the way i2c-algo-bit handles I2C_M_RECV_LEN,
used to implement i2c_smbus_read_block_data(). Previously, in the
absence of PEC (rarely used!) it would NAK the "length" byte:
S addr Rd [A] [length] NA
That prevents the subsequent data bytes from being read:
S addr Rd [A] [length] {...
| Oct 8, 2:06 pm 2007 |
| previous day | today | next day |
|---|---|---|
| October 7, 2007 | October 8, 2007 | October 9, 2007 |
| Amit K. Arora | [RFC] Heads up on sys_fallocate() |
| Tarkan Erimer | Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3 |
| Greg Kroah-Hartman | [PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO |
git: | |
| Gerrit Renker | [PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side) |
| Jarek Poplawski | Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| David Miller | [GIT]: Networking |
| Matheos Worku | 2.6.24 BUG: soft lockup - CPU#X |
