Re: RFC: reviewer's statement of oversight

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Steven Rostedt
Date: Monday, October 8, 2007 - 7:07 pm

On Mon, Oct 08, 2007 at 10:16:26PM +0200, Rafael J. Wysocki wrote:

I see two types of Tested-by.

1) As you stated, a fixed to a problem that the reporter has seen. So
that someone could state a "fixes issue" in the change log and that
would simple mean that the tester has seen a problem, and the attached
patch fixes it.

2) Someone has a testsuite to the area that the change affects. So if
someone has developed a networking test suite and a patch changes some
networking logic, the Tested-by could be that the tester actually ran
specific tests.  This should require a more detail explaination of what
was done. Or the very least, a pointer to a web page of the tests that
were run.

So for the user that sees an issue, then gets a patch, perhaps all they
need to do is add a "fixed problem" or "works now" in the change log to
denote that the patch has actually (or seems to) fix the problem that
they previously seen. This shouldn't be too hard.

But for those that run test suites, they should be smart enough to put
in more documentation into the change log to state how it was tested.

Perhaps we need to add yet another signed off.

"Verified-by", which could be for the user that saw an issue and the
patch now fixes it. That user could just add the "Verified-by" to the
patch to acknowledge (and record) that the patch did fix the issue.

The "Tested-by" can be used for patches that are run through a test
suite.

Just a thought.

-- Steve

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
RFC: reviewer's statement of oversight, Jonathan Corbet, (Mon Oct 8, 10:24 am)
Re: RFC: reviewer's statement of oversight, Pekka Enberg, (Mon Oct 8, 10:31 am)
Re: RFC: reviewer's statement of oversight, Sam Ravnborg, (Mon Oct 8, 10:37 am)
Re: RFC: reviewer's statement of oversight, Jan Engelhardt, (Mon Oct 8, 10:45 am)
Re: RFC: reviewer's statement of oversight, Jeremy Fitzhardinge, (Mon Oct 8, 11:01 am)
Re: RFC: reviewer's statement of oversight, Randy Dunlap, (Mon Oct 8, 11:06 am)
Re: RFC: reviewer's statement of oversight, Jeremy Fitzhardinge, (Mon Oct 8, 11:16 am)
Re: RFC: reviewer's statement of oversight, Stefan Richter, (Mon Oct 8, 11:26 am)
Re: RFC: reviewer's statement of oversight, Stefan Richter, (Mon Oct 8, 11:34 am)
Re: RFC: reviewer's statement of oversight, Mark Gross, (Mon Oct 8, 11:40 am)
Re: RFC: reviewer's statement of oversight, Roland Dreier, (Mon Oct 8, 11:40 am)
Re: RFC: reviewer's statement of oversight, J. Bruce Fields, (Mon Oct 8, 11:52 am)
Re: RFC: reviewer's statement of oversight, Stefan Richter, (Mon Oct 8, 11:53 am)
Re: RFC: reviewer's statement of oversight, Stefan Richter, (Mon Oct 8, 12:04 pm)
Re: RFC: reviewer's statement of oversight, Al Viro, (Mon Oct 8, 12:05 pm)
Re: RFC: reviewer's statement of oversight , Jonathan Corbet, (Mon Oct 8, 12:08 pm)
Re: RFC: reviewer's statement of oversight, Scott Preece, (Mon Oct 8, 12:26 pm)
Re: RFC: reviewer's statement of oversight, Scott Preece, (Mon Oct 8, 12:35 pm)
Re: RFC: reviewer's statement of oversight, Rafael J. Wysocki, (Mon Oct 8, 1:16 pm)
Re: RFC: reviewer's statement of oversight, H. Peter Anvin, (Mon Oct 8, 1:33 pm)
Re: RFC: reviewer's statement of oversight, Theodore Tso, (Mon Oct 8, 2:38 pm)
Re: RFC: reviewer's statement of oversight, Rafael J. Wysocki, (Mon Oct 8, 3:18 pm)
Re: RFC: reviewer's statement of oversight , Jonathan Corbet, (Mon Oct 8, 3:43 pm)
Re: RFC: reviewer's statement of oversight, Randy Dunlap, (Mon Oct 8, 4:06 pm)
Re: RFC: reviewer's statement of oversight, Oleg Verych, (Mon Oct 8, 4:20 pm)
Re: RFC: reviewer's statement of oversight, J. Bruce Fields, (Mon Oct 8, 4:30 pm)
Re: RFC: reviewer's statement of oversight, Stefan Richter, (Mon Oct 8, 4:42 pm)
Re: RFC: reviewer's statement of oversight, Steven Rostedt, (Mon Oct 8, 7:07 pm)
Re: RFC: reviewer's statement of oversight, Stephen Hemminger, (Mon Oct 8, 8:34 pm)
Re: RFC: reviewer's statement of oversight, Stefan Richter, (Mon Oct 8, 11:11 pm)
Re: RFC: reviewer's statement of oversight, Sam Ravnborg, (Mon Oct 8, 11:27 pm)
Re: RFC: reviewer's statement of oversight, Stefan Richter, (Mon Oct 8, 11:39 pm)
Re: RFC: reviewer's statement of oversight, Stefan Richter, (Mon Oct 8, 11:47 pm)
Re: RFC: reviewer's statement of oversight, Alan Cox, (Tue Oct 9, 3:28 am)
Re: RFC: reviewer's statement of oversight, Scott Preece, (Wed Oct 10, 6:40 am)