login
Header Space

 
 

Re: RFC: reviewer's statement of oversight

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jan Engelhardt <jengelh@...>
Cc: Sam Ravnborg <sam@...>, Jonathan Corbet <corbet@...>, Linux Kernel Mailing List <linux-kernel@...>, Pekka Enberg <penberg@...>
Date: Monday, October 8, 2007 - 2:01 pm

Jan Engelhardt wrote:

Tested-by is more valuable than acked-by, because its empirical. 
Acked-by generally means "I don't generally object to the idea of the
patch, but may not have read beyond the changelog".  Tested-by implies
"I did something that exercised the patch, and it didn't explode" -
that's on par with an actual review (ideally all patches would be both
tested and reviewed).


Hm.  We have a tension here:

    * there aren't enough reviewers
    * some reviews are more useful than others

While a review by a trustworthy person is invaluable, we don't want to
discourage people from reviewing.  A new reviewer's review may not be
terribly useful, but a meta-review may help improve it.  Or it could be
a great review.

I guess I'm proposing that we also need to expand the reviewer base, and
to do so we need some kind of reviewer-mentoring or metareview process. 
Of course that could just be an extra burden on the existing (small)
trusted reviewer base, but the hope is that over time the reviewer pool
size grows enough to make the effort worthwhile...



Well, any interested parties, really.  I use it for original bug
reporters, people who followed up on the report, people who have patches
in a nearby area, people who are known to be interested in the affected
subsystem, people who have reviewed previous versions of the patch, etc...

    J
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
RFC: reviewer's statement of oversight, Jonathan Corbet, (Mon Oct 8, 1:24 pm)
Re: RFC: reviewer's statement of oversight, Mark Gross, (Mon Oct 8, 2:40 pm)
Re: RFC: reviewer's statement of oversight, Stefan Richter, (Mon Oct 8, 2:53 pm)
Re: RFC: reviewer's statement of oversight, Al Viro, (Mon Oct 8, 3:05 pm)
Re: RFC: reviewer's statement of oversight , Jonathan Corbet, (Mon Oct 8, 3:08 pm)
Re: RFC: reviewer's statement of oversight, Sam Ravnborg, (Mon Oct 8, 1:37 pm)
Re: RFC: reviewer's statement of oversight , Jonathan Corbet, (Mon Oct 8, 6:43 pm)
Re: RFC: reviewer's statement of oversight, Scott Preece, (Wed Oct 10, 9:40 am)
Re: RFC: reviewer's statement of oversight, Stefan Richter, (Mon Oct 8, 7:42 pm)
Re: RFC: reviewer's statement of oversight, J. Bruce Fields, (Mon Oct 8, 7:30 pm)
Re: RFC: reviewer's statement of oversight, Alan Cox, (Tue Oct 9, 6:28 am)
Re: RFC: reviewer's statement of oversight, Randy Dunlap, (Mon Oct 8, 7:06 pm)
Re: RFC: reviewer's statement of oversight, Stephen Hemminger, (Mon Oct 8, 11:34 pm)
Re: RFC: reviewer's statement of oversight, Jan Engelhardt, (Mon Oct 8, 1:45 pm)
Re: RFC: reviewer's statement of oversight, H. Peter Anvin, (Mon Oct 8, 4:33 pm)
Re: RFC: reviewer's statement of oversight, Theodore Tso, (Mon Oct 8, 5:38 pm)
Re: RFC: reviewer's statement of oversight, Oleg Verych, (Mon Oct 8, 7:20 pm)
Re: RFC: reviewer's statement of oversight, Rafael J. Wysocki, (Mon Oct 8, 6:18 pm)
Re: RFC: reviewer's statement of oversight, Scott Preece, (Mon Oct 8, 3:35 pm)
Re: RFC: reviewer's statement of oversight, Roland Dreier, (Mon Oct 8, 2:40 pm)
Re: RFC: reviewer's statement of oversight, Stefan Richter, (Mon Oct 8, 2:26 pm)
Re: RFC: reviewer's statement of oversight, Jeremy Fitzhardinge, (Mon Oct 8, 2:01 pm)
Re: RFC: reviewer's statement of oversight, Randy Dunlap, (Mon Oct 8, 2:06 pm)
Re: RFC: reviewer's statement of oversight, Stefan Richter, (Mon Oct 8, 2:34 pm)
Re: RFC: reviewer's statement of oversight, J. Bruce Fields, (Mon Oct 8, 2:52 pm)
Re: RFC: reviewer's statement of oversight, Scott Preece, (Mon Oct 8, 3:26 pm)
Re: RFC: reviewer's statement of oversight, Rafael J. Wysocki, (Mon Oct 8, 4:16 pm)
Re: RFC: reviewer's statement of oversight, Steven Rostedt, (Mon Oct 8, 10:07 pm)
Re: RFC: reviewer's statement of oversight, Stefan Richter, (Tue Oct 9, 2:11 am)
Re: RFC: reviewer's statement of oversight, Sam Ravnborg, (Tue Oct 9, 2:27 am)
Re: RFC: reviewer's statement of oversight, Stefan Richter, (Tue Oct 9, 2:39 am)
Re: RFC: reviewer's statement of oversight, Stefan Richter, (Tue Oct 9, 2:47 am)
Re: RFC: reviewer's statement of oversight, Stefan Richter, (Mon Oct 8, 3:04 pm)
Re: RFC: reviewer's statement of oversight, Jeremy Fitzhardinge, (Mon Oct 8, 2:16 pm)
Re: RFC: reviewer's statement of oversight, Pekka Enberg, (Mon Oct 8, 1:31 pm)
speck-geostationary