Re: [PATCH] jbd: JBD replace jbd_kmalloc with kmalloc

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Mingming Cao <cmm@...>

Cc: Christoph Hellwig <hch@...>, Theodore Ts'o <tytso@...>, <linux-kernel@...>, <linux-ext4@...>

Subject: Re: [PATCH] jbd: JBD replace jbd_kmalloc with kmalloc

Date: Monday, October 8, 2007 - 1:46 pm

On Fri, 5 Oct 2007, Mingming Cao wrote:

quoted text> Index: linux-2.6.23-rc9/fs/jbd/transaction.c
> ===================================================================
> --- linux-2.6.23-rc9.orig/fs/jbd/transaction.c	2007-10-05 12:08:08.000000000 -0700
> +++ linux-2.6.23-rc9/fs/jbd/transaction.c	2007-10-05 12:08:29.000000000 -0700
> @@ -96,8 +96,8 @@ static int start_this_handle(journal_t *
>  
>  alloc_transaction:
>  	if (!journal->j_running_transaction) {
> -		new_transaction = jbd_kmalloc(sizeof(*new_transaction),
> -						GFP_NOFS);
> +		new_transaction = kmalloc(sizeof(*new_transaction),
> +						GFP_NOFS|__GFP_NOFAIL);

Why was a __GFP_NOFAIL added here? I do not see a use of jbd_rep_kmalloc?

quoted text> -#define jbd_kmalloc(size, flags) \
> -	__jbd_kmalloc(__FUNCTION__, (size), (flags), journal_oom_retry)

journal_oom_retry is no longer used?
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH, RFC] Ext4 patches planned for submission upstream, Theodore Ts'o, (Thu Oct 4, 1:50 am)

[PATCH] jbd/jbd2: JBD memory allocation cleanups, Theodore Ts'o, (Thu Oct 4, 1:50 am)

Re: [PATCH] jbd/jbd2: JBD memory allocation cleanups, Christoph Hellwig, (Thu Oct 4, 2:52 am)

[PATCH] jbd2: JBD replace jbd2_kmalloc with kmalloc, Mingming Cao, (Fri Oct 5, 6:39 pm)

Re: [PATCH] jbd2: JBD replace jbd2_kmalloc with kmalloc, Christoph Lameter, (Mon Oct 8, 2:37 pm)

[PATCH] jbd: JBD replace jbd_kmalloc with kmalloc, Mingming Cao, (Fri Oct 5, 6:38 pm)

Re: [PATCH] jbd: JBD replace jbd_kmalloc with kmalloc, Christoph Lameter, (Mon Oct 8, 1:46 pm)

Re: [PATCH] jbd: JBD replace jbd_kmalloc with kmalloc, Mingming Cao, (Mon Oct 8, 2:26 pm)

Re: [PATCH] jbd: JBD replace jbd_kmalloc with kmalloc, Christoph Lameter, (Mon Oct 8, 2:34 pm)

[PATCH] jbd2: JBD2 slab allocation cleanups, Mingming Cao, (Fri Oct 5, 6:36 pm)

[PATCH] jbd: JBD slab allocation cleanups, Mingming Cao, (Fri Oct 5, 6:35 pm)

Re: [PATCH] jbd/jbd2: JBD memory allocation cleanups, Mingming Cao, (Fri Oct 5, 6:33 pm)

[PATCH] jbd/jbd2: Journal initialization doesn't need __GFP_..., Theodore Ts'o, (Thu Oct 4, 1:50 am)

[PATCH] JBD2/Ext4: Convert kmalloc to kzalloc in jbd2/ext4, Theodore Ts'o, (Thu Oct 4, 1:50 am)


linux-kernel:
Mike Galbraith	Re: regression: CD burning (k3b) went broke
Andi Kleen	[PATCH] [3/22] x86_64: Kill temp boot pmds
Alan Cox	Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?
Greg Kroah-Hartman	[PATCH 004/196] Chinese: add translation of SubmittingPatches
git:

openbsd-misc:

linux-netdev:
David Miller	[GIT]: Networking
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 05/37] dccp: Cleanup routines for feature negotiation
Brandeburg, Jesse	RE: [PATCH] e1000e: test MSI interrupts

Re: [PATCH] jbd: JBD replace jbd_kmalloc with kmalloc

Online users