Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block size

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Jan Kara <jack@...>

To: Andrew Morton <akpm@...>

Cc: <cmm@...>, <linux-ext4@...>, <linux-kernel@...>, <sho@...>, <jack@...>, <clameter@...>

Subject: Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block size

Date: Monday, October 8, 2007 - 9:02 am

On Thu 04-10-07 13:12:07, Andrew Morton wrote:
quoted text> On Mon, 01 Oct 2007 17:35:46 -0700
> Mingming Cao <cmm@us.ibm.com> wrote:
> 
> > ext2: Avoid rec_len overflow with 64KB block size
> > 
> > From: Jan Kara <jack@suse.cz>
> > 
> > With 64KB blocksize, a directory entry can have size 64KB which does not fit
> > into 16 bits we have for entry lenght. So we store 0xffff instead and convert
> > value when read from / written to disk.
> 
> This patch clashes in non-trivial ways with
> ext2-convert-to-new-aops-fix.patch and perhaps other things which are
> already queued for 2.6.24 inclusion, so I'll need to ask for an updated
> patch, please.
> 
> Also, I'm planing on merging the ext2 reservations code into 2.6.24, so if
> we're aiming for complete support of 64k blocksize in 2.6.24's ext2,
> additional testing and checking will be needed.
  OK, I'll fixup those rejects and send a new patch.

									Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[31/36] Large Blocksize: Core piece, , (Tue Aug 28, 3:06 pm)

Re: [31/36] Large Blocksize: Core piece, Mingming Cao, (Wed Aug 29, 8:11 pm)

Re: [31/36] Large Blocksize: Core piece, Christoph Lameter, (Wed Aug 29, 8:12 pm)

[RFC 4/4]ext4: fix rec_len overflow with 64KB block size, Mingming Cao, (Wed Aug 29, 8:48 pm)

[RFC 3/4] ext3: fix rec_len overflow with 64KB block size, Mingming Cao, (Wed Aug 29, 8:48 pm)

[RFC 2/4]ext2: fix rec_len overflow with 64KB block size, Mingming Cao, (Wed Aug 29, 8:47 pm)

[RFC 1/4] Large Blocksize support for Ext2/3/4, Mingming Cao, (Wed Aug 29, 8:47 pm)

[PATCH 2/2] ext3: Avoid rec_len overflow with 64KB block size, Mingming Cao, (Mon Oct 1, 8:36 pm)

[PATCH 1/2] ext3: Support large blocksize up to PAGESIZE, Mingming Cao, (Mon Oct 1, 8:36 pm)

[PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block size, Mingming Cao, (Mon Oct 1, 8:35 pm)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Andrew Morton, (Thu Oct 4, 4:12 pm)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Jan Kara, (Thu Oct 11, 7:18 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Andrew Morton, (Thu Oct 18, 12:09 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Mingming Cao, (Thu Oct 18, 10:05 pm)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Christoph Lameter, (Thu Oct 18, 5:03 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Andrew Morton, (Thu Oct 18, 5:11 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Andrew Morton, (Thu Oct 18, 12:07 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Jan Kara, (Mon Oct 8, 9:02 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Andreas Dilger, (Thu Oct 4, 6:40 pm)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Andrew Morton, (Thu Oct 4, 7:11 pm)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Jan Kara, (Thu Oct 11, 6:30 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block..., Andrew Morton, (Thu Oct 11, 6:14 am)

[PATCH 1/2] ext2: Support large blocksize up to PAGESIZE, Mingming Cao, (Mon Oct 1, 8:35 pm)

[PATCH 2/2] ext4: Avoid rec_len overflow with 64KB block size, Mingming Cao, (Mon Oct 1, 8:35 pm)

[PATCH 1/2] ext4: Support large blocksize up to PAGESIZE, Mingming Cao, (Mon Oct 1, 8:34 pm)

Re: [RFC 1/4] Large Blocksize support for Ext2/3/4, Christoph Lameter, (Wed Aug 29, 8:59 pm)

[RFC 2/2] JBD: blocks reservation fix for large block support, Mingming Cao, (Fri Aug 31, 8:12 pm)

[RFC 1/2] JBD: slab management support for large block(>8k), Mingming Cao, (Fri Aug 31, 8:12 pm)

Re: [RFC 1/2] JBD: slab management support for large block(&..., Christoph Hellwig, (Sat Sep 1, 2:39 pm)

Re: [RFC 1/2] JBD: slab management support for large block(&..., Christoph Lameter, (Sun Sep 2, 7:40 am)

Re: [RFC 1/2] JBD: slab management support for large block(&..., Christoph Hellwig, (Sun Sep 2, 11:28 am)

Re: [RFC 1/2] JBD: slab management support for large block(&..., Christoph Lameter, (Mon Sep 3, 3:55 am)

Re: [RFC 1/2] JBD: slab management support for large block(&..., Christoph Hellwig, (Mon Sep 3, 9:40 am)

Re: [RFC 1/2] JBD: slab management support for large block(&..., Christoph Lameter, (Mon Sep 3, 3:31 pm)

Re: [RFC 1/2] JBD: slab management support for large block(&..., Christoph Hellwig, (Mon Sep 3, 3:33 pm)

[PATCH] JBD slab cleanups, Mingming Cao, (Fri Sep 14, 2:53 pm)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Mon Sep 17, 3:29 pm)

Re: [PATCH] JBD slab cleanups, Badari Pulavarty, (Mon Sep 17, 6:01 pm)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Mon Sep 17, 6:57 pm)

Re: [PATCH] JBD slab cleanups, Christoph Hellwig, (Tue Sep 18, 5:04 am)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Tue Sep 18, 12:35 pm)

Re: [PATCH] JBD slab cleanups, Dave Kleikamp, (Tue Sep 18, 2:04 pm)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Tue Sep 18, 9:00 pm)

Re: [PATCH] JBD slab cleanups, Andrew Morton, (Tue Sep 18, 10:19 pm)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Wed Sep 19, 3:15 pm)

Re: [PATCH] JBD slab cleanups, Andreas Dilger, (Wed Sep 19, 3:48 pm)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Wed Sep 19, 6:03 pm)

[PATCH] JBD/ext34 cleanups: convert to kzalloc, Mingming Cao, (Fri Sep 21, 7:13 pm)

Re: [PATCH] JBD/ext34 cleanups: convert to kzalloc, Andrew Morton, (Wed Sep 26, 3:54 pm)

Re: [PATCH] JBD/ext34 cleanups: convert to kzalloc, Mingming Cao, (Wed Sep 26, 5:05 pm)

[PATCH] JBD2/ext4 naming cleanup, Mingming Cao, (Fri Sep 21, 7:32 pm)

Re: [PATCH] JBD slab cleanups, Dave Kleikamp, (Wed Sep 19, 3:26 pm)

Re: [PATCH] JBD slab cleanups, Dave Kleikamp, (Wed Sep 19, 3:28 pm)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Wed Sep 19, 4:47 pm)

[PATCH] JBD: use GFP_NOFS in kmalloc, Mingming Cao, (Wed Sep 19, 3:22 pm)

Re: [PATCH] JBD: use GFP_NOFS in kmalloc, Andreas Dilger, (Thu Sep 20, 12:25 am)

Re: [PATCH] JBD: use GFP_NOFS in kmalloc, Andrew Morton, (Wed Sep 19, 5:34 pm)

Re: [PATCH] JBD: use GFP_NOFS in kmalloc, Mingming Cao, (Wed Sep 19, 5:55 pm)

Re: [PATCH] JBD slab cleanups, Christoph Hellwig, (Mon Sep 17, 3:34 pm)

Re: [PATCH] JBD slab cleanups, Christoph Lameter, (Fri Sep 14, 2:58 pm)

Re: [RFC 1/4] Large Blocksize support for Ext2/3/4, Mingming Cao, (Fri Aug 31, 8:01 pm)

Navigation

Popular discussions


linux-kernel:
Andrew Morton	-mm merge plans for 2.6.23
jjohansen	[AppArmor 39/45] AppArmor: Profile loading and manipulation, pathname matching
Greg KH	[GIT PATCH] driver core patches against 2.6.24
holzheu	Re: [RFC/PATCH] Documentation of kernel messages
git:

openbsd-misc:

linux-netdev:
David Miller	Re: [BUG] New Kernel Bugs
Gerrit Renker	[PATCH 36/37] dccp: Initialisation and type-checking of feature sysctls
David Miller	[GIT]: Networking
Jarek Poplawski	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().

Colocation donated by: