Home » Mailing list archives » linux-kernel » 2007 » October » 8

[PATCH 2/3] V4L: zc0301, remove bad usage of ERESTARTSYS

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jiri Slaby <jirislaby@...>
To: Andrew Morton <akpm@...>
Cc: <linux-kernel@...>, <luca.risolia@...>, <linux-usb-devel@...>, <mchehab@...>, <video4linux-list@...>
Subject: [PATCH 2/3] V4L: zc0301, remove bad usage of ERESTARTSYS
Date: Monday, October 8, 2007 - 8:34 am

zc0301, remove bad usage of ERESTARTSYS

down_read_trylock can't be interrupted and so ERESTARTSYS would reach
userspace, which is not permitted. Change it to EAGAIN

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>

---
commit 235cf594bc65128250632a642f3e9d7e4df4975e
tree 0557746416827daeb4d829610fec2f0c9111a675
parent db38c559d37219c32b179ae005ca7e489336ec94
author Jiri Slaby <jirislaby@gmail.com> Mon, 08 Oct 2007 14:15:47 +0200
committer Jiri Slaby <jirislaby@gmail.com> Mon, 08 Oct 2007 14:15:47 +0200

 drivers/media/video/zc0301/zc0301_core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/zc0301/zc0301_core.c b/drivers/media/video/zc0301/zc0301_core.c
index 35138c5..08a93c3 100644
--- a/drivers/media/video/zc0301/zc0301_core.c
+++ b/drivers/media/video/zc0301/zc0301_core.c
@@ -655,7 +655,7 @@ static int zc0301_open(struct inode* inode, struct file* filp)
 	int err = 0;
 
 	if (!down_read_trylock(&zc0301_dev_lock))
-		return -ERESTARTSYS;
+		return -EAGAIN;
 
 	cam = video_get_drvdata(video_devdata(filp));
 
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/3] V4L: w9968cf, remove bad usage of ERESTARTSYS, Jiri Slaby, (Mon Oct 8, 8:33 am)
[PATCH 1/1 try 2] V4L: cinergyT2, remove bad usage of ERESTA..., Jiri Slaby, (Sun Oct 14, 10:28 am)
[PATCH 3/3] V4L: cinergyT2, remove bad usage of ERESTARTSYS, Jiri Slaby, (Mon Oct 8, 8:34 am)
Re: [PATCH 3/3] V4L: cinergyT2, remove bad usage of ERESTART..., Mauro Carvalho Chehab, (Tue Oct 9, 9:21 pm)
Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove ..., Michael Krufky, (Wed Oct 10, 12:18 am)
Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove ..., Randy Dunlap, (Fri Oct 12, 12:29 am)
Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove ..., Mauro Carvalho Chehab, (Wed Oct 10, 11:35 am)
Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove ..., Alan Cox, (Wed Oct 10, 11:59 am)
Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove ..., Mauro Carvalho Chehab, (Wed Oct 10, 12:17 pm)
Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove ..., Manu Abraham, (Wed Oct 10, 12:40 pm)
Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove ..., Marcel Siegert, (Wed Oct 10, 12:53 pm)
Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove ..., Manu Abraham, (Wed Oct 10, 1:05 pm)
Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove ..., Marcel Siegert, (Wed Oct 10, 2:04 pm)
Re: [PATCH 1/3] V4L: w9968cf, remove bad usage of ERESTARTSYS, Luca Risolia, (Tue Oct 9, 8:18 pm)
[PATCH 2/3] V4L: zc0301, remove bad usage of ERESTARTSYS, Jiri Slaby, (Mon Oct 8, 8:34 am)
Re: [PATCH 2/3] V4L: zc0301, remove bad usage of ERESTARTSYS, Luca Risolia, (Tue Oct 9, 8:18 pm)