Home » Mailing list archives » linux-kernel » 2007 » October » 8

[PATCH 1/3] V4L: w9968cf, remove bad usage of ERESTARTSYS

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jiri Slaby <jirislaby@...>
To: Andrew Morton <akpm@...>
Cc: <linux-kernel@...>, <luca.risolia@...>, <mchehab@...>, <video4linux-list@...>
Subject: [PATCH 1/3] V4L: w9968cf, remove bad usage of ERESTARTSYS
Date: Monday, October 8, 2007 - 8:33 am

w9968cf, remove bad usage of ERESTARTSYS

down_read_trylock can't be interrupted and so ERESTARTSYS would reach
userspace, which is not permitted. Change it to EAGAIN

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>

---
commit db38c559d37219c32b179ae005ca7e489336ec94
tree f2d606165e6ef2daa6e1a2860f87521222eeecd2
parent 6e42c2183befe136d85e6a8708ee4eabc543774b
author Jiri Slaby <jirislaby@gmail.com> Mon, 08 Oct 2007 14:14:03 +0200
committer Jiri Slaby <jirislaby@gmail.com> Mon, 08 Oct 2007 14:14:03 +0200

 drivers/media/video/w9968cf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/w9968cf.c b/drivers/media/video/w9968cf.c
index 77599f2..5a1b5f5 100644
--- a/drivers/media/video/w9968cf.c
+++ b/drivers/media/video/w9968cf.c
@@ -2679,7 +2679,7 @@ static int w9968cf_open(struct inode* inode, struct file* filp)
 
 	/* This the only safe way to prevent race conditions with disconnect */
 	if (!down_read_trylock(&w9968cf_disconnect))
-		return -ERESTARTSYS;
+		return -EAGAIN;
 
 	cam = (struct w9968cf_device*)video_get_drvdata(video_devdata(filp));
 
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/3] V4L: w9968cf, remove bad usage of ERESTARTSYS, Jiri Slaby, (Mon Oct 8, 8:33 am)
[PATCH 1/1 try 2] V4L: cinergyT2, remove bad usage of ERESTA..., Jiri Slaby, (Sun Oct 14, 10:28 am)
[PATCH 3/3] V4L: cinergyT2, remove bad usage of ERESTARTSYS, Jiri Slaby, (Mon Oct 8, 8:34 am)
Re: [PATCH 3/3] V4L: cinergyT2, remove bad usage of ERESTART..., Mauro Carvalho Chehab, (Tue Oct 9, 9:21 pm)
Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove ..., Michael Krufky, (Wed Oct 10, 12:18 am)
Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove ..., Randy Dunlap, (Fri Oct 12, 12:29 am)
Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove ..., Mauro Carvalho Chehab, (Wed Oct 10, 11:35 am)
Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove ..., Alan Cox, (Wed Oct 10, 11:59 am)
Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove ..., Mauro Carvalho Chehab, (Wed Oct 10, 12:17 pm)
Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove ..., Manu Abraham, (Wed Oct 10, 12:40 pm)
Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove ..., Marcel Siegert, (Wed Oct 10, 12:53 pm)
Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove ..., Manu Abraham, (Wed Oct 10, 1:05 pm)
Re: [v4l-dvb-maintainer] [PATCH 3/3] V4L: cinergyT2, remove ..., Marcel Siegert, (Wed Oct 10, 2:04 pm)
Re: [PATCH 1/3] V4L: w9968cf, remove bad usage of ERESTARTSYS, Luca Risolia, (Tue Oct 9, 8:18 pm)
[PATCH 2/3] V4L: zc0301, remove bad usage of ERESTARTSYS, Jiri Slaby, (Mon Oct 8, 8:34 am)
Re: [PATCH 2/3] V4L: zc0301, remove bad usage of ERESTARTSYS, Luca Risolia, (Tue Oct 9, 8:18 pm)