Re: [RFC][PATCH] New message-logging API (kprint)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Rob Landley
Date: Sunday, October 7, 2007 - 2:50 pm

On Saturday 06 October 2007 1:10:26 am Vegard Nossum wrote:

I made it about halfway through the patch and the only compile time filtering 
I found was:

--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -62,7 +62,10 @@
 #define MdpMinorShift 6
 
 #define DEBUG 0
-#define dprintk(x...) ((void)(DEBUG && printk(x)))
+#define dprintk(x...)          \
+       if(DEBUG) {             \
+                printk(x);     \
+       }

If you say it does, I'll take your word for it, but there's so much churn in 
there I didn't find it before my interest ran out...

Rob
-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC][PATCH] New message-logging API (kprint), Vegard Nossum, (Thu Oct 4, 1:04 pm)
Re: [RFC][PATCH] New message-logging API (kprint), Randy Dunlap, (Thu Oct 4, 1:17 pm)
Re: [RFC][PATCH] New message-logging API (kprint), Rob Landley, (Thu Oct 4, 6:59 pm)
Re: [RFC][PATCH] New message-logging API (kprint), Miguel Ojeda, (Fri Oct 5, 12:01 am)
Re: [RFC][PATCH] New message-logging API (kprint), Vegard Nossum, (Fri Oct 5, 6:13 am)
Re: [RFC][PATCH] New message-logging API (kprint), Rob Landley, (Fri Oct 5, 9:05 am)
Re: [RFC][PATCH] New message-logging API (kprint), Rob Landley, (Fri Oct 5, 9:26 am)
Re: [RFC][PATCH] New message-logging API (kprint), Alan Cox, (Fri Oct 5, 10:01 am)
Re: [RFC][PATCH] New message-logging API (kprint), Miguel Ojeda, (Fri Oct 5, 4:01 pm)
Re: [RFC][PATCH] New message-logging API (kprint), Stephen Hemminger, (Fri Oct 5, 5:34 pm)
Re: [RFC][PATCH] New message-logging API (kprint), Vegard Nossum, (Fri Oct 5, 11:10 pm)
Re: [RFC][PATCH] New message-logging API (kprint), Miguel Ojeda, (Sun Oct 7, 3:20 am)
Re: [RFC][PATCH] New message-logging API (kprint), Rob Landley, (Sun Oct 7, 2:50 pm)
Re: [RFC][PATCH] New message-logging API (kprint), Rob Landley, (Sun Oct 7, 2:56 pm)
Re: [RFC][PATCH] New message-logging API (kprint), Randy Dunlap, (Sun Oct 7, 3:32 pm)
Re: [RFC][PATCH] New message-logging API (kprint), Stephen Hemminger, (Mon Oct 8, 8:25 am)
Re: [RFC][PATCH] New message-logging API (kprint), Vegard Nossum, (Mon Oct 8, 8:33 am)
Re: [RFC][PATCH] New message-logging API (kprint), Stephen Hemminger, (Mon Oct 8, 8:42 am)