Home » Mailing list archives » linux-kernel » 2007 » October » 7

[PATCH] [6/6] scheduler: Remove bogus comment in sched_group_set_shares

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andi Kleen
Subject: [PATCH] [6/6] scheduler: Remove bogus comment in sched_group_set_shares
Date: Sunday, October 7, 2007 - 1:59 pm

Function never returns -EINVAL.

Signed-off-by: Andi Kleen <ak@suse.de>

Index: linux-2.6-sched-devel/kernel/sched.c
===================================================================
--- linux-2.6-sched-devel.orig/kernel/sched.c
+++ linux-2.6-sched-devel/kernel/sched.c
@@ -6814,8 +6814,6 @@ int sched_group_set_shares(struct task_g
 	if (tg->shares == shares)
 		return 0;
 
-	/* return -EINVAL if the new value is not sane */
-
 	tg->shares = shares;
 	for_each_possible_cpu(i)
 		set_se_shares(tg->se[i], shares);
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] [0/6] Some scheduler changes for sched-devel, Andi Kleen, (Sun Oct 7, 1:59 pm)
[PATCH] [1/6] scheduler: Remove some unnecessary gotos in ..., Andi Kleen, (Sun Oct 7, 1:59 pm)
[PATCH] [2/6] scheduler: Refactor common code of sleep_on ..., Andi Kleen, (Sun Oct 7, 1:59 pm)
[PATCH] [3/6] scheduler: Do devirtualization for sched_fair, Andi Kleen, (Sun Oct 7, 1:59 pm)
[PATCH] [4/6] scheduler: Refactor normalize_rt_tasks, Andi Kleen, (Sun Oct 7, 1:59 pm)
[PATCH] [5/6] scheduler: Protect important kernel threads ..., Andi Kleen, (Sun Oct 7, 1:59 pm)
[PATCH] [6/6] scheduler: Remove bogus comment in sched_gro ..., Andi Kleen, (Sun Oct 7, 1:59 pm)
Re: [PATCH] [2/6] scheduler: Refactor common code of sleep ..., Andi Kleen, (Sun Oct 7, 3:22 pm)
Re: [PATCH] [1/6] scheduler: Remove some unnecessary gotos ..., Ingo Molnar, (Mon Oct 8, 4:36 am)
Re: [PATCH] [2/6] scheduler: Refactor common code of sleep ..., Ingo Molnar, (Mon Oct 8, 4:39 am)
Re: [PATCH] [3/6] scheduler: Do devirtualization for sched ..., Ingo Molnar, (Mon Oct 8, 4:42 am)
Re: [PATCH] [4/6] scheduler: Refactor normalize_rt_tasks, Ingo Molnar, (Mon Oct 8, 4:44 am)
Re: [PATCH] [5/6] scheduler: Protect important kernel thre ..., Ingo Molnar, (Mon Oct 8, 4:51 am)
Re: [PATCH] [6/6] scheduler: Remove bogus comment in sched ..., Ingo Molnar, (Mon Oct 8, 4:52 am)
Re: [PATCH] [2/6] scheduler: Refactor common code of sleep ..., Ingo Molnar, (Mon Oct 8, 5:03 am)
Re: [PATCH] [3/6] scheduler: Do devirtualization for sched ..., Andi Kleen, (Mon Oct 8, 5:32 am)
Re: [PATCH] [5/6] scheduler: Protect important kernel thre ..., Andi Kleen, (Mon Oct 8, 5:33 am)
Re: [PATCH] [3/6] scheduler: Do devirtualization for sched ..., Ingo Molnar, (Mon Oct 8, 5:39 am)
Re: [PATCH] [5/6] scheduler: Protect important kernel thre ..., Ingo Molnar, (Mon Oct 8, 5:43 am)
Re: [PATCH] [5/6] scheduler: Protect important kernel thre ..., Andi Kleen, (Mon Oct 8, 6:08 am)
Re: [PATCH] [3/6] scheduler: Do devirtualization for sched ..., Andi Kleen, (Mon Oct 8, 7:33 am)
Re: [PATCH] [1/6] scheduler: Remove some unnecessary gotos ..., Ingo Molnar, (Tue Oct 9, 12:17 pm)
Re: [PATCH] [1/6] scheduler: Remove some unnecessary gotos ..., Andi Kleen, (Tue Oct 9, 5:55 pm)
Re: [PATCH] [1/6] scheduler: Remove some unnecessary gotos ..., Ingo Molnar, (Wed Oct 10, 4:25 am)
Re: [PATCH] [1/6] scheduler: Remove some unnecessary gotos ..., Ingo Molnar, (Wed Oct 10, 4:26 am)