login
Header Space

 
 

Re: [PATCH] Cute feature: colored printk output

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jan Engelhardt <jengelh@...>
Cc: Linux Kernel Mailing List <linux-kernel@...>, Andrew Morton <akpm@...>
Date: Saturday, October 6, 2007 - 7:08 am

* Jan Engelhardt <jengelh@computergmbh.de> wrote:


looks really good to me!

Reviewed-by: Ingo Molnar <mingo@elte.hu>

small nit:

+       vc->vc_color = printk_color;
+       update_attr(vc);

that should be in a set_vc_color() function and the new code should do:

+	set_vc_color(vc, vc->vc_color);

(and same at the other places that call update_attr() as well)

feature request: would be interesting to have a color table (defined in 
the .config) dependent on message loglevel. That way KERN_CRIT messages 
could be red, KERN_INFO ones white, etc.

	Ingo
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Cute feature: colored printk output, Jan Engelhardt, (Fri Oct 5, 3:13 pm)
Re: [PATCH] Cute feature: colored printk output, Miguel Botón, (Sat Oct 6, 5:19 pm)
Re: [PATCH] Cute feature: colored printk output, Bill Davidsen, (Sat Oct 6, 3:53 pm)
Re: [PATCH] Cute feature: colored printk output, Jan Engelhardt, (Sat Oct 6, 4:01 pm)
Re: [PATCH] Cute feature: colored printk output, Bill Davidsen, (Sat Oct 6, 8:50 pm)
Re: [PATCH] Cute feature: colored printk output, Jan Engelhardt, (Sun Oct 7, 4:42 am)
Re: [PATCH] Cute feature: colored printk output, Ingo Molnar, (Sat Oct 6, 7:08 am)
Re: [PATCH] Cute feature: colored printk output, Oleg Verych, (Sat Oct 6, 2:09 pm)
Re: [PATCH] Cute feature: colored printk output, Dave Jones, (Sat Oct 6, 1:16 pm)
Re: [PATCH] Cute feature: colored printk output, Krzysztof Halasa, (Fri Oct 5, 7:22 pm)
Re: [PATCH] Cute feature: colored printk output, Jan Engelhardt, (Fri Oct 5, 7:47 pm)
Re: [PATCH] Cute feature: colored printk output, Krzysztof Halasa, (Fri Oct 5, 8:10 pm)
Re: [PATCH] Cute feature: colored printk output, Jan Engelhardt, (Fri Oct 5, 8:23 pm)
Re: [PATCH] Cute feature: colored printk output, Jan Engelhardt, (Fri Oct 5, 8:26 pm)
Re: [PATCH] Cute feature: colored printk output, Krzysztof Halasa, (Sat Oct 6, 7:58 am)
RE: [PATCH] Cute feature: colored printk output, Medve Emilian-EMMEDVE1, (Fri Oct 5, 4:23 pm)
Re: [PATCH] Cute feature: colored printk output, Lennart Sorensen, (Fri Oct 5, 3:19 pm)
Re: [PATCH] Cute feature: colored printk output, Jan Engelhardt, (Fri Oct 5, 3:21 pm)
Re: [PATCH] Cute feature: colored printk output, Lennart Sorensen, (Fri Oct 5, 3:24 pm)
Re: [PATCH] Cute feature: colored printk output, Jan Engelhardt, (Fri Oct 5, 3:32 pm)
Re: [PATCH] Cute feature: colored printk output, Lennart Sorensen, (Fri Oct 5, 3:43 pm)
Re: [PATCH] Cute feature: colored printk output, Jan Engelhardt, (Fri Oct 5, 3:55 pm)
speck-geostationary