login
Header Space

 
 

Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>
Cc: Jeremy Fitzhardinge <jeremy@...>, <linux-kernel@...>, <muli@...>, <satyam@...>, <amitkale@...>, <achim_leubner@...>
Date: Saturday, October 6, 2007 - 4:37 am

On Fri, Oct 05, 2007 at 02:00:50PM -0700, Andrew Morton wrote:

Hi and sorry for the late reply. IMHO, this solution is the most concise and still
clear enough a macro to understand what it does after a quick scan (unlike
uglies like IO_COND() in lib/iomap.c¹, :)) And, as a next step, we probably
should do

perl -pi -e 's/DMA_(..)BIT_MASK/DMA_BIT_MASK($1)/g' *

after removing the #define DMA_..BIT_MASK defines in /include/linux/dma-mapping.h
and the other two headers in the original patch after the x86 merge.
Current git (9f34073b4e54ad58541e0e2b4a87f4f6c1460e21) contains about 394
instances of usage of those macros, including the #definitions.


¹ this is not a flame!
-- 
Regards/Gruß,
    Boris.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Borislav Petkov, (Tue Sep 18, 3:46 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Andrew Morton, (Fri Oct 5, 3:47 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Jeremy Fitzhardinge, (Fri Oct 5, 4:43 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Andrew Morton, (Fri Oct 5, 5:00 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Borislav Petkov, (Sat Oct 6, 4:37 am)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Robert P. J. Day, (Fri Oct 5, 5:03 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Andreas Schwab, (Fri Oct 5, 5:24 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Jeremy Fitzhardinge, (Fri Oct 5, 5:28 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Andrew Morton, (Fri Oct 5, 6:24 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Jeremy Fitzhardinge, (Fri Oct 5, 6:32 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Jeremy Fitzhardinge, (Fri Oct 5, 5:23 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Borislav Petkov, (Sat Oct 6, 3:54 am)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Satyam Sharma, (Wed Sep 19, 11:03 am)
speck-geostationary