login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
October
»
5
Re: [PATCH] cpuset and sched domains: sched_load_balance flag fixes
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Andrew Morton <akpm@...>
To: Paul Jackson <pj@...>
Cc: <nickpiggin@...>, <randy.dunlap@...>, <menage@...>, <linux-kernel@...>, <dino@...>, <pj@...>, <cpw@...>, <mingo@...>
Subject:
Re: [PATCH] cpuset and sched domains: sched_load_balance flag fixes
Date: Friday, October 5, 2007 - 7:13 pm
On Wed, 03 Oct 2007 04:44:01 -0700 Paul Jackson <pj@sgi.com> wrote:
quoted text
> From: Paul Jackson <pj@sgi.com> > > Thanks to Randy Dunlap for the review that caught > some of the following. > > Some bug fixes and coding style fixes: > 1) only one statement per line, please. > 2) don't need to guard kfree() calls with a NULL check > 3) use kfifo_free, not kfree, if it came from kfifo_alloc > 4) a pair of curly brackets got lost along the way > 5) missing .read, .write callbacks for sched_load_balance > > Without (3), one kfifo buffer memory was leaked each time > one rebuilt scheduler domains > > Without (4), the current task was summarily killed each > time one tried to rebuild scheduler domains > > Without (5), every read or write system call on a per-cpuset > special file 'sched_load_balance' failed, EINVAL. > > Signed-off-by: Paul Jackson <pj@sgi.com> > > --- > > Andrew, > > These fixes go right after the patch they fix: > [PATCH] cpuset and sched domains: sched_load_balance flag
I'm getting 100% rejects from this - probably whatever patch it is patching got lost or unrecognisably mangled. -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] cpuset and sched domains: sched_load_balance flag fi...
, Paul Jackson
, (Wed Oct 3, 7:44 am)
Re: [PATCH] cpuset and sched domains: sched_load_balance fla...
, Andrew Morton
, (Fri Oct 5, 7:13 pm)
Re: [PATCH] cpuset and sched domains: sched_load_balance fla...
, Paul Jackson
, (Fri Oct 5, 7:39 pm)
Re: [PATCH] cpuset and sched domains: sched_load_balance fla...
, Ingo Molnar
, (Sat Oct 6, 1:53 am)
Re: [PATCH] cpuset and sched domains: sched_load_balance fla...
, Paul Jackson
, (Sat Oct 6, 2:01 am)
Re: [PATCH] cpuset and sched domains: sched_load_balance fla...
, Ingo Molnar
, (Sat Oct 6, 2:21 am)
Re: [PATCH] cpuset and sched domains: sched_load_balance fla...
, Paul Jackson
, (Sat Oct 6, 2:28 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
David Miller
Re: Slow DOWN, please!!!
Greg Kroah-Hartman
[PATCH 013/196] Documentation: Replace obsolete "driverfs" with "sysfs".
James Bottomley
Re: Integration of SCST in the mainstream Linux kernel
Jeff Garzik
Re: [RFC] Heads up on sys_fallocate()
git
:
linux-netdev
:
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Linus Torvalds
Re: [GIT]: Networking
Andrew Morton
Re: [BUG] New Kernel Bugs
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
0 users
and
446 guests
online.
Syndicate