Home » Mailing list archives » linux-kernel » 2007 » October » 5

Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andrew Morton <akpm@...>
To: Jeremy Fitzhardinge <jeremy@...>
Cc: <schwab@...>, <rpjday@...>, <bbpetkov@...>, <linux-kernel@...>, <muli@...>, <satyam@...>, <amitkale@...>, <achim_leubner@...>
Subject: Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1
Date: Friday, October 5, 2007 - 6:24 pm

On Fri, 05 Oct 2007 14:28:45 -0700
Jeremy Fitzhardinge <jeremy@goop.org> wrote:


Well yes, but DMA_BIT_MASK(0) invokes undefined behaviour, generates a
compiler warning and evaluates to 0xffffffffffffffff (with my setup).

That won't be a problem in practice, but it is strictly wrong and doesn't set
a good exmaple for the children ;)

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Borislav Petkov, (Tue Sep 18, 3:46 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Andrew Morton, (Fri Oct 5, 3:47 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Jeremy Fitzhardinge, (Fri Oct 5, 4:43 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Andrew Morton, (Fri Oct 5, 5:00 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Borislav Petkov, (Sat Oct 6, 4:37 am)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Robert P. J. Day, (Fri Oct 5, 5:03 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Andreas Schwab, (Fri Oct 5, 5:24 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Jeremy Fitzhardinge, (Fri Oct 5, 5:28 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Andrew Morton, (Fri Oct 5, 6:24 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Jeremy Fitzhardinge, (Fri Oct 5, 6:32 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Jeremy Fitzhardinge, (Fri Oct 5, 5:23 pm)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Borislav Petkov, (Sat Oct 6, 3:54 am)
Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1, Satyam Sharma, (Wed Sep 19, 11:03 am)