[PATCH] pci: implement "pci=noaer"

Previous thread: [PATCH] Cute feature: colored printk output by Jan Engelhardt on Friday, October 5, 2007 - 3:13 pm. (22 messages)

Next thread: libata-dev.git rebased; ACPI turned on by Jeff Garzik on Friday, October 5, 2007 - 4:46 pm. (1 message)
To: lkml <linux-kernel@...>, <linas@...>
Cc: gregkh <greg@...>, akpm <akpm@...>, <linux-pci@...>
Date: Friday, October 5, 2007 - 4:17 pm

From: Randy Dunlap <randy.dunlap@oracle.com>

For cases in which CONFIG_PCIEAER=y (such as distro kernels), allow users
to disable PCIE Advanced Error Reporting by using "pci=noaer" on the
kernel command line.

This can be used to work around hardware or (kernel) software problems.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
Documentation/kernel-parameters.txt | 4 ++++
drivers/pci/pci.c | 2 ++
drivers/pci/pci.h | 6 ++++++
drivers/pci/pcie/aer/aerdrv.c | 9 +++++++++
4 files changed, 21 insertions(+)

--- linux-2.6.23-rc9.orig/Documentation/kernel-parameters.txt
+++ linux-2.6.23-rc9/Documentation/kernel-parameters.txt
@@ -67,6 +67,7 @@ parameter is applicable:
PARIDE The ParIDE (parallel port IDE) subsystem is enabled.
PARISC The PA-RISC architecture is enabled.
PCI PCI bus support is enabled.
+ PCIE PCI Express support is enabled.
PCMCIA The PCMCIA subsystem is enabled.
PNP Plug & Play support is enabled.
PPC PowerPC architecture is enabled.
@@ -1269,6 +1270,9 @@ and is between 256 and 4096 characters.
Mechanism 1.
conf2 [X86-32] Force use of PCI Configuration
Mechanism 2.
+ noaer [PCIE] If the PCIEAER kernel config parameter is
+ enabled, this kernel boot option can be used to
+ disable the use of PCIE advanced error reporting.
nommconf [X86-32,X86_64] Disable use of MMCONFIG for PCI
Configuration
nomsi [MSI] If the PCI_MSI kernel config parameter is
--- linux-2.6.23-rc9.orig/drivers/pci/pci.c
+++ linux-2.6.23-rc9/drivers/pci/pci.c
@@ -1585,6 +1585,8 @@ static int __devinit pci_setup(char *str
if (*str && (str = pcibios_setup(str)) && *str) {
if (!strcmp(str, "nomsi")) {
pci_no_msi();
+ } else if (!strcmp(str, "noaer")) {
+ pci_no_aer();
} else if (!strncmp(str, "cbiosize=", 9)) {
pci_cardbus_io_size = memparse(str + 9, &str);
} else if (!strncmp(str, "cbmemsize=", 10)) {
--- linux-2...

To: Randy Dunlap <randy.dunlap@...>
Cc: lkml <linux-kernel@...>, gregkh <greg@...>, akpm <akpm@...>, <linux-pci@...>
Date: Monday, October 15, 2007 - 1:12 pm

Looks reasonable to me.

(sorry for the belated reply... I also saw this in gregkh's patch
series. Since the email was addressed to me, I figure I should
at least say "yes I read it". Dunno if "Yes-I-read-it-by:" is
the same as "Acked by:", if it is, then acked-by me.. )

--linas

-

Previous thread: [PATCH] Cute feature: colored printk output by Jan Engelhardt on Friday, October 5, 2007 - 3:13 pm. (22 messages)

Next thread: libata-dev.git rebased; ACPI turned on by Jeff Garzik on Friday, October 5, 2007 - 4:46 pm. (1 message)