Re: [PATCH 13/32] IGET: Stop EXT2 from using iget() and read_inode() [try #2] | KernelTrap

Re: [PATCH 13/32] IGET: Stop EXT2 from using iget() and read_inode() [try #2]

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Theodore Tso <tytso@...>

To: David Howells <dhowells@...>

Cc: <hch@...>, <viro@...>, <torvalds@...>, <akpm@...>, <linux-kernel@...>, <linux-fsdevel@...>

Subject: Re: [PATCH 13/32] IGET: Stop EXT2 from using iget() and read_inode() [try #2]

Date: Friday, October 5, 2007 - 8:05 am

On Thu, Oct 04, 2007 at 04:57:08PM +0100, David Howells wrote:
quoted text> Stop the EXT2 filesystem from using iget() and read_inode().  Replace
> ext2_read_inode() with ext2_iget(), and call that instead of iget().
> ext2_iget() then uses iget_locked() directly and returns a proper error code
> instead of an inode in the event of an error.
> 
> ext2_fill_super() returns any error incurred when getting the root inode
> instead of EINVAL.
> 
> Signed-off-by: David Howells <dhowells@redhat.com>

Acked-by: "Theodore Ts'o" <tytso@mit.edu>

							- Ted
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 00/32] Remove iget() and read_inode() [try #2], David Howells, (Thu Oct 4, 11:56 am)

Re: [PATCH 00/32] Remove iget() and read_inode() [try #2], David Howells, (Fri Oct 5, 10:44 am)

[PATCH 30/32] IGET: Stop HOSTFS from using iget() and read_i..., David Howells, (Thu Oct 4, 11:58 am)

[PATCH 31/32] IGET: Stop HPPFS from using iget() and read_in..., David Howells, (Thu Oct 4, 11:58 am)

[PATCH 29/32] IGET: Stop OPENPROMFS from using iget() and re..., David Howells, (Thu Oct 4, 11:58 am)

[PATCH 27/32] IGET: Stop the SYSV filesystem from using iget..., David Howells, (Thu Oct 4, 11:58 am)

[PATCH 25/32] IGET: Stop QNX4 from using iget() and read_ino..., David Howells, (Thu Oct 4, 11:58 am)

[PATCH 23/32] IGET: Stop the MINIX filesystem from using ige..., David Howells, (Thu Oct 4, 11:57 am)

[PATCH 32/32] IGET: Remove iget() and the read_inode() super..., David Howells, (Thu Oct 4, 11:58 am)

[PATCH 24/32] IGET: Stop PROCFS from using iget() and read_i..., David Howells, (Thu Oct 4, 11:58 am)

[PATCH 28/32] IGET: Stop UFS from using iget() and read_inod..., David Howells, (Thu Oct 4, 11:58 am)

[PATCH 26/32] IGET: Stop ROMFS from using iget() and read_in..., David Howells, (Thu Oct 4, 11:58 am)

[PATCH 21/32] IGET: Stop JFFS2 from using iget() and read_in..., David Howells, (Thu Oct 4, 11:57 am)

[PATCH 22/32] IGET: Stop JFS from using iget() and read_inod..., David Howells, (Thu Oct 4, 11:57 am)

[PATCH 20/32] IGET: Stop ISOFS from using read_inode() [try ..., David Howells, (Thu Oct 4, 11:57 am)

[PATCH 19/32] IGET: Stop HFSPLUS from using iget() and read_..., David Howells, (Thu Oct 4, 11:57 am)

[PATCH 15/32] IGET: Stop EXT4 from using iget() and read_ino..., David Howells, (Thu Oct 4, 11:57 am)

Re: [PATCH 15/32] IGET: Stop EXT4 from using iget() and read..., Jan Kara, (Tue Oct 9, 11:45 am)

[PATCH 18/32] IGET: Stop FUSE from using iget() and read_ino..., David Howells, (Thu Oct 4, 11:57 am)

[PATCH 17/32] IGET: Stop FreeVXFS from using iget() and read..., David Howells, (Thu Oct 4, 11:57 am)

[PATCH 16/32] IGET: Stop FAT from using iget() and read_inod..., David Howells, (Thu Oct 4, 11:57 am)

[PATCH 14/32] IGET: Stop EXT3 from using iget() and read_ino..., David Howells, (Thu Oct 4, 11:57 am)

Re: [PATCH 14/32] IGET: Stop EXT3 from using iget() and read..., Jan Kara, (Tue Oct 9, 11:41 am)

[PATCH 13/32] IGET: Stop EXT2 from using iget() and read_ino..., David Howells, (Thu Oct 4, 11:57 am)

Re: [PATCH 13/32] IGET: Stop EXT2 from using iget() and read..., Theodore Tso, (Fri Oct 5, 8:05 am)

[PATCH 11/32] IGET: Stop CIFS from using iget() and read_ino..., David Howells, (Thu Oct 4, 11:56 am)

[PATCH 10/32] IGET: Stop BFS from using iget() and read_inod..., David Howells, (Thu Oct 4, 11:56 am)

[PATCH 12/32] IGET: Stop EFS from using iget() and read_inod..., David Howells, (Thu Oct 4, 11:57 am)

[PATCH 07/32] IGET: Stop AFFS from using iget() and read_ino..., David Howells, (Thu Oct 4, 11:56 am)

[PATCH 08/32] IGET: Stop autofs from using iget() and read_i..., David Howells, (Thu Oct 4, 11:56 am)

[PATCH 06/32] IGET: Mark iget() and read_inode() as being ob..., David Howells, (Thu Oct 4, 11:56 am)

Re: [PATCH 06/32] IGET: Mark iget() and read_inode() as bein..., Christoph Hellwig, (Fri Oct 5, 10:47 am)

Re: [PATCH 06/32] IGET: Mark iget() and read_inode() as bein..., David Howells, (Fri Oct 5, 11:12 am)

Re: [PATCH 06/32] IGET: Mark iget() and read_inode() as bein..., David Howells, (Fri Oct 5, 11:21 am)

Re: [PATCH 06/32] IGET: Mark iget() and read_inode() as bein..., Christoph Hellwig, (Fri Oct 5, 11:29 am)

[PATCH 09/32] IGET: Stop BEFS from using iget() and read_ino..., David Howells, (Thu Oct 4, 11:56 am)

[PATCH 05/32] IGET: Use iget_failed() in GFS2 [try #2], David Howells, (Thu Oct 4, 11:56 am)

[PATCH 04/32] IGET: Use iget_failed() in AFS [try #2], David Howells, (Thu Oct 4, 11:56 am)

[PATCH 01/32] Add an ERR_CAST() macro to complement ERR_PTR ..., David Howells, (Thu Oct 4, 11:56 am)

Re: [PATCH 01/32] Add an ERR_CAST() macro to complement ERR_..., Randy Dunlap, (Fri Oct 5, 12:21 pm)

Re: [PATCH 01/32] Add an ERR_CAST() macro to complement ERR_..., Christoph Hellwig, (Fri Oct 5, 10:46 am)

Re: [PATCH 01/32] Add an ERR_CAST() macro to complement ERR_..., David Howells, (Fri Oct 5, 11:47 am)

Re: [PATCH 01/32] Add an ERR_CAST() macro to complement ERR_..., Sam Ravnborg, (Fri Oct 5, 12:07 pm)

Re: [PATCH 01/32] Add an ERR_CAST() macro to complement ERR_..., David Howells, (Fri Oct 5, 12:19 pm)

[PATCH 02/32] Convert ERR_PTR(PTR_ERR(p)) instances to ERR_C..., David Howells, (Thu Oct 4, 11:56 am)

[PATCH 03/32] IGET: Introduce a function to register iget fa..., David Howells, (Thu Oct 4, 11:56 am)

Re: [PATCH 03/32] IGET: Introduce a function to register ige..., Christoph Hellwig, (Fri Oct 5, 10:47 am)

Navigation

Popular discussions


linux-kernel:
David Miller	Re: Slow DOWN, please!!!
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Bart Van Assche	Integration of SCST in the mainstream Linux kernel
Heiko Carstens	Re: -mm merge plans for 2.6.23 -- sys_fallocate
git:

linux-netdev:
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller	[GIT]: Networking
Jan Engelhardt	Re: iptables very slow after commit 784544739a25c30637397ace5489eeb6e15d7d49
openbsd-misc:

Colocation donated by:

Who's online

There are currently 1 user and 1033 guests online.

Online users

hamidmushtaq

Syndicate